The patch is probably OK as it is, and it's needed since it fixes crash-bugs.
However, it might now be somewhat slower to use the shuffler with 'pure' FD:s. I don't really know, though, since I have not checked the new backend code (the change in the backend code is most likely the reason for the crash)
/ Per Hedbor ()
Previous text:
2004-06-21 10:44: Subject: Re: Bilaga till: Re: Bilaga till: Drowning in the Shuffler (SEGV)
Per Hedbor () @ Pike (-) developers forum wrote:
Well, it looks good except for one problem: If I am not incorrect this no longer bypass the pike-level code when reading from 'pure' FD:s.
That was the reason for the check for t->fd, anyway.
So that means that:
- The patch is ok as such, and needed anyway?
- The patch is incomplete, and needs to be extended with ...
to be able to read from pure FDs?
Or does it mean that the whole if check for t->fd can be scrapped because all things are equal now?
I'm confused, but this is my normal state :-).
Sincerely, srb@cuci.nl Stephen R. van den Berg (AKA BuGless).
"People who think they know everything are annoying to those of us who do."
/ Brevbäraren