The check is there for a reason...
Hint: Check the macro DO_CALL_BUILTIN in interpret_functions.h. What do you think happens if s->subtype isn't FUNCTION_BUILTIN?
I tried to decypher the definition in interpret_functions_fixed.h I failed :-). Sorry, my knowledge of Pike internals is not enough (yet) to understand the implications.
The loading is so much faster now, the memory usage is down, the logfiles are clean(er).
The logfiles are cleaner as long as those werrors aren't called...
Ok, fair enough. I'll exercise some of these, and will let you know what happens.
The reasons why I suspect the change is correct anyway, is because: - We don't do anything funny in feeding the encoder/compiler. - All we feed it is: add_constant("werror", roxen_werror); which, when addressed from within another module as werror() produces the warning mentioned (and hence, the compiled object is discarded).
But, we'll see.