Yes, that seems like a good idea.
There is really no need to keep compatibility for pre-8.0 versions, I think, I doubt anyone has code that explicitly checks for the ERROR_DIRECTORY errno but not ENOTDIR (well, I hope so at least).
On Wed, Sep 10, 2014 at 1:31 PM, Martin Karlgren marty@roxen.com wrote:
Hey everybody,
Shouldn't Windows' ERROR_DIRECTORY (267) code map to ENOTDIR? dosmaperr doesn't care about it for some reason, but still, it seems like a logical thing to do. Python does it since a couple of years (http://bugs.python.org/issue12802). set_errno_from_win32_error mentions winsock codes being passed through as-is though.
What do you all think, is it likely that code depends on errno being ERROR_DIRECTORY in those cases? Do we need compat code for <= 7.8?
Best regards, Marty -- Roxen Internet Software Martin Karlgren (Jonsson), Developer/Consultant Box 449, SE-581 05 Linköping, Sweden T: +46 13 376800 marty@roxen.com