30 Mar
2009
30 Mar
'09
11:15 a.m.
Commit from Per:
Line 3997: */ PIKEFUN float|int(0..0) `()(void|float|int(0..0) sleep_time) { - struct timeval timeout; /* Got bogus gcc warning on timeout.tv_usec. */ + struct timeval timeout; /* Got correct gcc warning on timeout.tv_usec. */
if (sleep_time && sleep_time->type == PIKE_T_FLOAT) { timeout.tv_sec = (long) floor (sleep_time->u.float_number);
No, the warning is indeed bogus since the tv_usec field isn't relevant when the tv_sec field is -1. The added assignment is completely unnecessary work.