Arne Goedeke wrote:
I also pondered moving that into do_async_post.. but maybe someone is relying on that somewhere.
thanks
arne
On Fri, 30 Oct 2009, Martin Stjernholm, Roxen IS @ Pike developers forum wrote:
Looks reasonable, since (afaics) that method doesn't do anything with the data. It'd be a different matter if it took the variables and encoded them into the body, for instance.
Considering that it doesn't do anything with the data at all, I'd say it really has no business setting a content type, but I guess it's better left in place for compatibility.
Patch applied in 7.8. Thanks.
the same seems to be happening in the blocking variant do_method_url. There is also a bug in Tools.Hilfe.GenericAsyncHilfe, where the write callback is triggered permanently because an empty string is written in case the outbuffer is empty. I attached a patch for hilfe.
arne
diff --git a/lib/modules/Tools.pmod/Hilfe.pmod b/lib/modules/Tools.pmod/Hilfe.pmod index aafa465..64a746c 100644 --- a/lib/modules/Tools.pmod/Hilfe.pmod +++ b/lib/modules/Tools.pmod/Hilfe.pmod @@ -2973,6 +2973,7 @@ class GenericAsyncHilfe
void write_callback() { + if (!sizeof(outbuffer)) return; int i=outfile->write(outbuffer); outbuffer=outbuffer[i..]; }