I've mentioned this before, but I really think something should be done about the error macros. It takes something like 50 bytes _more_ to use a SIMPLE_ERROR macro compared to writing the Pike_error yourself. And you really shouldn't have to write the name of the function youself. There are probably lots of places where the wrong function name is used. Even though I try to audit the code for this occasionally, new places keep popping up.
/ Martin Nilsson (räfsfiskal)
Previous text:
2004-05-18 01:28: Subject: Re: Nettle cmod segfault
As we are speaking of that, wouldn't it be possible to make this macros with a little less code in it (and generally in macros used in Pike)?
Possible - yes. A good idea - probably not. I've looked at many of the macros and usually think they make sense, at least when rtldebug and dmalloc isn't enabled. For the most part, they get overly bloated only when debug is enabled; it's not uncommon that the debug parts are a bit sloppy and don't bother to isolate some overly long debug checks into functions.
/ Martin Stjernholm, Roxen IS