I think extract_autodoc should exit with a non-0 exitcode whenever it produces an error message. Right now, it doesn't, which can cause documentation markup errors to go unnoticed.
[...]
The patch below is one way of making sure that extract_autodoc fails. Maybe there are better ways.
diff --git a/lib/modules/Tools.pmod/Standalone.pmod/extract_autodoc.pike b/lib/modules/Tools.pmod/Standalone.pmod/extract_autodoc.pike index a3fb82645c..a346f9a132 100644 --- a/lib/modules/Tools.pmod/Standalone.pmod/extract_autodoc.pike +++ b/lib/modules/Tools.pmod/Standalone.pmod/extract_autodoc.pike @@ -717,6 +717,8 @@ string extract(string filename, string imgdest, if (!verbosity) ; werror("\nERROR: %s\n", describe_error(err));
- if (!(flags & Tools.AutoDoc.FLAG_KEEP_GOING))
exit(1);
I believe that reenabling the return 0 should be sufficient.
Fixed in Pike 8.0 and 8.1.
And the actual documentation markup error is trivial to fix:
diff --git a/src/cpp.cmod b/src/cpp.cmod index 3b98d89746..440dceb3c7 100644 --- a/src/cpp.cmod +++ b/src/cpp.cmod @@ -5018,7 +5018,7 @@ static void insert_callback_define_no_args(struct object *cpp_obj, *! it will default to @expr{"-"@}. *! *! @param charset
- *! Turn on automatic character set detection if @expr{1}, otherwise
- *! Turn on automatic character set detection if @expr{1@}, otherwise *! specifies the character set used by the input. *! Defaults to @expr{"ISO-10646"@}. *!
Fixed in Pike 8.1.
Thanks.