I’ve committed a new feature to 8.1 that I’d like to get feedback on. The feature extends master()->add_module_path() to allow the path to point to a ZIP archive which will be searched as if it were a regular module directory.
Things I’d especially like feedback on:
1. Is the current API acceptable (the simplest form is built into add_module_path(), more complex use cases may be accounted for using lower level APIs) 2. A minor overhead exists (a mapping lookup on the path prefix) which may impact performance for non-archive path searches. Since classes are cached after lookup, is this overhead a concern? Quick benchmarking doesn’t seem to indicate a significant performance change, however I’d like to hear thoughts from users whose use case may vary from my own. 3. Does it make sense to extend this feature to add_*_path? My sense is yes, but wanted to check.
Sample Usage:
1. Create a zip file with the following structure: modules/ modules/Some.pmod/ … etc 2. Run pike -M path/to/some.zip 3. Access Some.whatever…
Bill