I've got a patch to sslfile.pike which may be of interest. It solves a problem very similar to bug #2117 (lots of warnings for destructed files when running Roxen; in my case only reproducible using Safari on OS X) but I really don't know why.
Should I commit it to 7.4 and/or only 7.5? Anyone feeling responsible for this code and willing to dig into the actual reasons why the thread callbacks are mixed up?
Index: sslfile.pike =================================================================== RCS file: /pike/data/cvsroot/Pike/7.4/lib/modules/SSL.pmod/sslfile.pike,v retrieving revision 1.50 diff -u -r1.50 sslfile.pike --- sslfile.pike 29 Nov 2002 01:22:14 -0000 1.50 +++ sslfile.pike 12 Sep 2003 16:13:08 -0000 @@ -371,8 +371,13 @@ } }
+private Thread.Mutex write_mutex = Thread.Mutex(); + private void ssl_write_callback(mixed id) { + Thread.MutexKey mutex_key = write_mutex->lock(2); + if (!socket) return; + #ifdef SSL3_DEBUG werror(sprintf("SSL.sslfile->ssl_write_callback: handshake_finished = %d\n" "blocking = %d, write_callback = %O\n",
/ Jonas Walldén
Previous text:
2003-09-11 20:42: Subject: Pike 7.4.30
How about making a new 7.4 release this week? I've already taken the time to do the most boring part; updating CHANGES.
/ Martin Nilsson (ja till euro, nej till cent)