12 Apr
2006
12 Apr
'06
5:29 p.m.
In the function file_connect_unix(), Pike_sp[-args].u.string->len is checked against PATH_MAX, and then its strcpy'd into name.sun_path. The size of a sockaddr_un.sun_path isn't standard, and can be much smaller than PATH_MAX.
How should this be fixed, changing the PATH_MAX test to a sizeof(name.sun_path)? Or removing that check altogether, using strncpy and then checking for truncation and giving a "path too long" error instead of the current "Illegal argument. Expected string(8bit)"?
Is it worth adding configure tests for strlcpy/cat and using those instead of strncpy/cat?
Adam