Mirar @ Pike developers forum wrote:
It's probably a good idea to implement, yes. (But not for 7.8...?)
It works with supplying the query object with the mapping you are using for the session. From HTTP/Session.pike:
q->hostname_cache=hostname_cache;
For a session. Hrm. Well, let's put it this way, I've recently solved a similar problem in mailfromd which supports connections to spamd and clamd over TCP/IP, however the clamd sessions (at least) operate in such a way that *after* the initial connect session, they open up a secondary datachannel (a bit like FTP) over which they send the mail content.
The silly thing here is that if the clamd host is loadbalanced over DNS, this second connection has a high probability of being to the wrong server. So in that case I would like the session/DNS cache to supply me with the exact same IP it did in the previous query.
If that is what this is about, then your patch is fine; if it is not, I'd even advise against having an extra DNS-cache layer (at least as long as it doesn't take the TTL into account).