Pike-devel

pike-devel@lists.lysator.liu.se

1 participants
3041 discussions

Segmentation fault cause
by Stephen R. van den Berg 28 Aug '20

28 Aug '20

Running without these commits, it runs forever. Running with these commits results in segmentation faults every few minutes to hours (this is in heavy threaded/lock code: pgsql driver). I cannot offer a stacktrace yet. commit 4781e5e4fe034cc8b2acef468131d5dbc51ca21f Author: Henrik Grubbström (Grubba) <grubba(a)grubba.org> Date: Sun Jun 28 16:33:02 2020 +0200 Threads.Mutex: Added {try_,}shared_lock(). src/threads.c | 256 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 246 insertions(+), 10 deletions(-) commit 35fa44331e70809a86a97a91bf80e27a38a6f35b Author: Henrik Grubbström (Grubba) <grubba(a)grubba.org> Date: Sat Jun 27 13:58:46 2020 +0200 Thread.Mutex: Keep track of pending locks. Mutex locks are now taken in the same order as the calls to lock(). This prevents potential starvation. src/threads.c | 181 +++++++++++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 137 insertions(+), 44 deletions(-) commit d461910bac03f0fddf714dff8794e73988d07ea6 Author: Henrik Grubbström (Grubba) <grubba(a)grubba.org> Date: Fri Jun 26 12:34:34 2020 +0200 Thread.Mutex: The key pointer is now to the storage (and not the object). src/threads.c | 69 ++++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 39 insertions(+), 30 deletions(-) commit 37406b33d5670026537d4a9aca4776a88a94380b Author: Henrik Grubbström (Grubba) <grubba(a)grubba.org> Date: Thu Jun 25 15:37:42 2020 +0200 Build: Fixed some warnings. src/post_modules/GSSAPI/gssapi.cmod | 1 + src/post_modules/Nettle/hogweed.cmod | 1 + src/post_modules/SDL/SDL.cmod | 2 +- src/post_modules/ZXID/zxid.cmod | 2 +- 4 files changed, 4 insertions(+), 2 deletions(-) commit ea9a8260156eca36ceb1f555fd1c04c9f1c71685 Author: Henrik Grubbström (Grubba) <grubba(a)grubba.org> Date: Wed Jun 24 18:16:52 2020 +0200 Thread.MutexKey: Some preparations for having different kinds of keys. src/threads.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- Stephen.

3 30

Pike, WebSockets, and SSL
by Chris Angelico 12 Aug '20

12 Aug '20

Closing an SSL websocket bombs out. SSL sockets can only be closed in both directions at once, but websockets send a FRAME_CLOSE and then close in the write direction only. Is it necessary to close in the write direction only, or can the websocket simply close both ends at once? The exception can't easily be dealt with, since it happens in the backend. Demo code available here. If you don't have a certificate, it'll generate a self-signed; the behaviour is the same. https://github.com/Rosuav/StilleBot/blob/master/ws_halfclose.pike ChrisA

2 4

Re: Type checking of exponentiation
by Chris Angelico 09 Aug '20

09 Aug '20

On Mon, Aug 10, 2020 at 1:02 AM Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) @ Pike (-) developers forum <10353(a)lyskom.lysator.liu.se> wrote: > > 4^-2 is not an integer. It's 0.0625 (or 1/16, if expressed as a > fraction, which seems to be what 8.1 has chosen here). True. In the original, though, this was guarded such that this expression would only ever have a positive exponent. I couldn't figure out a way to force STR to be interpreted as int(2..) though. The original was more like this, but the effect is the same: calc("STR < 2 ? STR : 4 ** (STR - 2)"); In theory, static analysis should show that the exponent has to be 0 or greater, but if it can't figure that out, I'd be okay with telling it that (eg with a cast). Attempting to add the cast just produces a warning "Soft cast of zero to int(2..) is a noop" and the same exception. ChrisA

1 0

Type checking of exponentiation
by Chris Angelico 09 Aug '20

09 Aug '20

In order to implement an expression evaluator, I have a two-pass compilation that first uses a magic resolver to find external name references, and then compiles the actual code to get a function back. This cut-down version of it showcases a strange phenomenon: //Magic resolver. Any symbol at all can be resolved; it'll come through as 0, but the name //will be retained. Used in the precompilation stage to capture external references. multiset(string) symbols; mixed resolv(string symbol, string fn, object handler) {symbols[symbol] = 1;} void calc(string formula) { //Precompile to get a list of used symbols symbols = (<>); //Note: As of Pike 8.1, p must be retained or the compile() call will be optimized out. program p = compile("mixed _ = " + formula + ";", this); //Compile the formula calculator itself. function f1 = compile(sprintf( "int _(mapping data) {%{int %s = (int)data->%<s;\n%}return %s;}", (array)symbols,formula ))()->_; write("Successfully compiled %O\n", formula); } int main() { calc("STR - 2"); calc("4 ** STR"); calc("4 ** (STR + 2)"); calc("4 ** (STR - 2)"); } Everything works fine (using Pike from master branch, c5decfee5) except the very last one, which complains that soft-casting an mpq object to int isn't valid. Other variants of this issue exhibit themselves as saying that "void" is invalid in some context. Any idea where to look for this? ChrisA

2 1

Crypto.Password and Blowfish
by Stephen R. van den Berg 19 Jul '20

19 Jul '20

Has anyone attempted to add support for Blowfish encryption to Crypto.Password? I have some $2y$... prefixed passwords (interfacing with the PHP password_verify()) which I need to verify. -- Stephen.

4 11

Re: Operator assignment and strict_types
by Marc Simpson 07 Jul '20

07 Jul '20

Thanks! On Tue, Jul 7, 2020 at 5:00 AM Henrik Grubbström (Lysator) @ Pike (-) developers forum <10353(a)lyskom.lysator.liu.se> wrote: > > > Hi folks, > > Hi Marc. > > It took some time, but... > > > It looks like operator assignment (op=), increment and decrement > > statements aren't subjected to the same typechecks as their more > > explicit equivalents. > > Correct. > > > For example, neither the post-increment nor += statements below warn > > with strict_types enabled, even though they assign values outside of > > foo's restricted int domain: > > > > int(3..3) foo = 3; > > foo++; // no warning > > foo += 1; // no warning > > foo = foo + 1; // warning from strict_types > > > > Similarly, operator assignment on aggregates fails to elicit a warning: > [...] > > Fixed in Pike devel. > > The operator assignment expressions now warn in the same places as > their corresponding explict syntax does. > > The ++ and -- operators have not been modified (yet). > > > I'm guessing this is because the checks provided by the > > F_ASSIGN/F_ASSIGN_SELF case (las.c) only apply to direct assignment; > > op= and friends are presumably not instrumented for strict_types in > > the same manner. > > Correct. > > > Have there been any discussions around addressing this inconsistency? > > Now there has... > > /grubba

1 0

Operator assignment and strict_types
by Marc Simpson 07 Jul '20

07 Jul '20

Hi folks, It looks like operator assignment (op=), increment and decrement statements aren't subjected to the same typechecks as their more explicit equivalents. For example, neither the post-increment nor += statements below warn with strict_types enabled, even though they assign values outside of foo's restricted int domain: int(3..3) foo = 3; foo++; // no warning foo += 1; // no warning foo = foo + 1; // warning from strict_types Similarly, operator assignment on aggregates fails to elicit a warning: array(int) a = ({}); multiset(int) b = (<>); mapping(int:int) c = ([]); // no warnings a += ({ "hey" }); b += (< "hey" >); c += ([ "hey": "there" ]); // warnings from strict_types a = a + ({ "hey" }); b = b + (< "hey" >); c = c + ([ "hey": "there" ]); I'm guessing this is because the checks provided by the F_ASSIGN/F_ASSIGN_SELF case (las.c) only apply to direct assignment; op= and friends are presumably not instrumented for strict_types in the same manner. Have there been any discussions around addressing this inconsistency? Thanks, Marc

3 3

an automap bug
by Mateusz Krawczuk 06 Jul '20

06 Jul '20

Reproduces both on pike 8 from apt repository and pike compiled on master: $ ./pike -v Pike v8.1 release 13 Copyright © 1994-2018 Linköping University Pike comes with ABSOLUTELY NO WARRANTY; This is free software and you are welcome to redistribute it under certain conditions; read the files COPYING and COPYRIGHT in the Pike distribution for more details. $ $ cat automap1.pike int main() { write( "%O\n", combine_path("foo", ({ "abc", "cde" })[*] ) ); } $ $ cat automap2.pike int main() { string s = "foo"; write("%O\n", combine_path(s, ({ "abc", "cde" })[*] ) ); } $ $ ./pike automap1.pike ({ /* 2 elements */ "foo/abc", "foo/cde" }) $ $ ./pike automap2.pike automap2.pike:4:[*] not supported here. Pike: Failed to compile script. $ $ pike -v Pike v8.0 release 498 Copyright © 1994-2017 Linköping University Pike comes with ABSOLUTELY NO WARRANTY; This is free software and you are welcome to redistribute it under certain conditions; read the files COPYING and COPYRIGHT in the Pike distribution for more details. $ pike automap1.pike ({ /* 2 elements */ "foo/abc", "foo/cde" }) $ $ pike automap2.pike automap2.pike:4:[*] not supported here.

2 1

Recursive typedefs and add_constant
by Chris Angelico 28 Jun '20

28 Jun '20

I've run into a weirdness involving a recursive typedef and adding a constant. Example: typedef string|int|array(foo) foo; If compiled on its own, this creates a recursive typedef that can handle arbitrarily-nested arrays of strings and ints. Contrast: typedef multiset(string|int) strint; add_constant("strint", strint); typedef string|int|array(strint) foo; This will reference the added constant, and will allow strings, integers, and multisets of strings/ints, but not recursively. What if both names are the same? constant code = #" typedef string|int|array(foo) foo; foo x = 1.0; "; typedef multiset(string|int) strint; void compile_error(string filename, int line, string msg) {write("%s\n", msg);} int main() { write("Without constant:\n"); catch {compile_string(code, "-", this);}; add_constant("foo", strint); write("\nWith constant:\n"); catch {compile_string(code, "-", this);}; } Is the array of foo supposed to be a recursive reference, or a reference to the constant? And is there a way to force one interpretation or the other? A related problem (or a consequence of this) is that repeatedly recompiling a provider of constants can cause strangenesses, up to and including quadratically-increasing compilation time. Consider this cut-down version of part of one of my apps: constant code = #" #ifdef FAST typedef string|mapping(string:string|_echoable_message)|array(_echoable_message) _echoable_message; typedef _echoable_message echoable_message; #else typedef string|mapping(string:string|echoable_message)|array(echoable_message) echoable_message; #endif typedef echoable_message|function(object,object,string:echoable_message) command_handler; bool assess_command(command_handler f) { object|mapping flags = functionp(f) ? function_object(f) : mappingp(f) ? f : ([]); return flags->ok; } protected void create(string n) { #ifndef FAST2 add_constant(\"echoable_message\", echoable_message); #endif add_constant(\"assess_command\", assess_command); } "; int main() { add_constant("commands", ([])); System.Timer tm = System.Timer(); while (1) { compile_string(code)(); write("Compiled in %.2fs\n", tm->get()); } } Running this with -DFAST uses a different name temporarily, dodging the problem. Using -DFAST2 doesn't add the typedef as a constant, also dodging the problem. But otherwise, it quickly starts taking notable time to run each compilation - each iteration about 3-4 times as long as the previous. The question is: Should echoable_message be using the added constant, or should it be defined recursively? I actually don't know what is correct behaviour here. ChrisA

1 0

`-> and the context argument
by Stephen R. van den Berg 20 Jun '20

20 Jun '20

The docs say this: mixed `->(string index, object|void context, int|void access) Parameter context Context in the current object to start the search from. If UNDEFINED or left out, this_program::this is to be be used (ie start at the current context and ignore any overloaded symbols). Can someone illustrate this with an example which shows how context can differ and how it could be used? -- Stephen.

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel