Pike-devel

pike-devel@lists.lysator.liu.se

3041 discussions

Start a nNew thread

pike-svn.lysator.liu.se
by Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum 02 Sep '08

02 Sep '08

Using "svn export" will of course also expand the keyword.

1 0

xenofarm fuzz
by Mirar ＠ Pike developers forum 02 Sep '08

02 Sep '08

Hm. Ok, so if I run "make verify" myself: | Subresult: 40406 tests, 0 failed, 9 skipped | Accumulated: 158118 tests, 0 failed, 217 skipped | Total tests: 158118 (217 tests skipped) | Finished tests at Mon Sep 1 08:42:06 2008 but if xenofarm runs it, | Doing tests in testsuite (11197 tests) [2 cpu-hours worth of computrons] | No result from subprocess (died of signal SIGKILL) can anyone explain this? :p

4 7

Indexing the empty array with a string should MAYBE throw, or perhaps it should never throw? [4574]
by Johan Sundstr�m (Achtung Liebe!) ＠ Pike (-) developers forum 01 Sep '08

01 Sep '08

Indexing array(string-indexables) with a string works, indexing array(non-string-indexables) does not. I don't see how that is a problem, but maybe my pragmatism is broken. (String-indexables being mappings and, likely, any kind of objects.) / Johan Sundström (Achtung Liebe!) Previous text: >16753605 2008-09-01 16:04 /40 lines/ Brevbäraren >Recipients: Pike (-) ticket import >Subject: Indexing the empty array with a string should MAYBE throw, or perhaps it should never throw? [4574] >-------------------------------------------------------------------- > > Product: Pike > Version: 7.7 > Component: Compiler > Reporter: peter(a)bortas.org > URL: https://community.roxen.com/crunch/show_bug.cgi?id=4574 > >> array a = ({}); >> a->apa; >(1) Result: ({ }) >> a = ({ "banan" }); >(2) Result: ({ /* 1 element */ > "banan" > }) >> a->apa; >Expected integer as string index, got "apa". >HilfeInput:1: HilfeInput()->___HilfeWrapper() >> a = ({ "banan":(["a":1]) }); >Compiler Error: 1:Missing '}'. >Compiler Error: 1:syntax error, unexpected ':', expecting ')' >Compiler Error: 1:syntax error, unexpected '}', expecting TOK_LEX_EOF or >';' >> a = ({ (["banan":(["a":1])]) }); >(3) Result: ({ /* 1 element */ > ([ /* 1 element */ > "banan": ([ /* 1 element */ > "a": 1 > ]) > ]) > }) >> a->banan; >(4) Result: ({ /* 1 element */ > ([ /* 1 element */ > "a": 1 > ]) > }) > > >This seems a bit inconsistent. > > >(16753605) /Brevbäraren/-------------------------------------------- >

2 1

Split?
by Martin Stjernholm, Roxen IS ＠ Pike developers forum 01 Sep '08

01 Sep '08

>From my point of view now would be a good time to split. Or, at least, it doesn't look likely to get much better. The recent yellow dots is due to a test case I added for a type check problem. I can disable that test again if it make things look bad.. So, opinions about splitting?

13 58

master()->add_predefine()
by Henrik Grubbstr�m (Lysator) ＠ Pike (-) developers forum 01 Sep '08

01 Sep '08

Hmm... Seems the strengthened type of error() caught a few more bugs...

1 0

xenofarm fuzz
by Mirar ＠ Pike developers forum 01 Sep '08

01 Sep '08

(Disregarding the latest totally fatal checkin, that is.)

1 0

master()->add_predefine()
by Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum 31 Aug '08

31 Aug '08

It was discovered that master()->add_predefine() does not work in 7.6 compat mode in 7.8. The predefine functions has been present since 7.4, so they should be added to the Pike_7_4_master class. Is it ok to commit this fix (yes, I have tested it)? Index: master.pike.in =================================================================== RCS file: /pike/data/cvsroot/Pike/7.8/lib/master.pike.in,v retrieving revision 1.451 diff -u -r1.451 master.pike.in --- master.pike.in 14 Aug 2008 13:14:10 -0000 1.451 +++ master.pike.in 30 Aug 2008 21:39:12 -0000 @@ -643,6 +643,9 @@ if ((major == 7) && (minor > 0)) return Pike_7_2_master::this; return Pike_7_2_master::get_compat_master(major, minor); } + void add_predefine (string name, string value); + void remove_predefine (string name); + mapping get_predefines(); } //! Pike 7.6 master compatibility interface.

3 3

7.8 alpha 2
by Mirar ＠ Pike developers forum 29 Aug '08

29 Aug '08

That doesn't break hilfe either. Only that exact order breaks: | > string s = Stdio.read_bytes("sugar.jpg"); | > object i = Image.JPEG.decode(s); | >> i; | (1) Result: Image.Image( 300 x 300 /* 263.7Kb */) | > Image.JPEG.encode(i); | *** glibc detected *** /usr/local/bin/pike: double free or corruption (out): 0x0000000000b52860 *** | Error while mapping shared library sections: | ¹=ãÈ¬àx¬<5`Ó 3Ú9ÿ: No such file or directory. | ======= Backtrace: ========= | /lib/libc.so.6[0x2b5197a4f08a] | /lib/libc.so.6(cfree+0x8c)[0x2b5197a52c1c] | ... Skipping the "i;" doesn't lead to a fault. Replacing the "i;" with werror("%O\n",i); stops it from breaking as well. This bug goes away if you look at it the wrong way. :P

6 23

RFC int2string optimisation
by Stephen R. van den Berg 28 Aug '08

28 Aug '08

It seemed like a good idea. commit beeba499793328cc118992884d8e175caffa6433 Author: Stephen R. van den Berg <srb(a)cuci.nl> Date: Thu Aug 21 13:17:21 2008 +0200 Optimise optimisation and move inline int2string from roxen.c to operators.c diff --git a/src/modules/_Roxen/roxen.c b/src/modules/_Roxen/roxen.c index 253f2b3..dcf6086 100644 --- a/src/modules/_Roxen/roxen.c +++ b/src/modules/_Roxen/roxen.c @@ -456,33 +456,6 @@ static void f_html_encode_string( INT32 args ) void o_cast_to_string(); case PIKE_T_INT: - /* Optimization, this is basically a inlined cast_int_to_string */ - { - char buf[21], *b = buf+19; - int neg, i, j=0; - i = Pike_sp[-1].u.integer; - pop_stack(); - if( i < 0 ) - { - neg = 1; - i = -i; - } - else - neg = 0; - - buf[20] = 0; - - while( i >= 10 ) - { - b[ -j++ ] = '0'+(i%10); - i /= 10; - } - b[ -j++ ] = '0'+(i%10); - if( neg ) b[ -j++ ] = '-'; - push_text( b-j+1 ); - } - return; - case PIKE_T_FLOAT: /* Optimization, no need to check the resultstring for * unsafe characters. diff --git a/src/operators.c b/src/operators.c index 3d12cbd..d1eaf75 100644 --- a/src/operators.c +++ b/src/operators.c @@ -343,11 +343,10 @@ PMOD_EXPORT void o_cast_to_int(void) /* Special case for casting to string. */ PMOD_EXPORT void o_cast_to_string(void) { - char buf[200]; switch(sp[-1].type) { case PIKE_T_STRING: - return; + break; case T_OBJECT: if(!sp[-1].u.object->prog) { @@ -387,10 +386,40 @@ PMOD_EXPORT void o_cast_to_string(void) get_name_of_type(sp[-1].type)); } } - return; + break; case T_INT: +#if 0 sprintf(buf, "%"PRINTPIKEINT"d", sp[-1].u.integer); +#else + { +#define sizeNUM(v) (8*sizeof(v)*4/10+1+1) + INT32 org; + char buf[sizeNUM(org)]; + register char*b = buf+sizeof buf-1; + register unsigned i; + org = sp[-1].u.integer; + pop_stack(); + *b-- = '\0'; + i = org; + + if( org < 0 ) + i = -i; + + goto jin; + do { + i /= 10; +jin: *b-- = '0'+(i%10); + } + while( i >= 10 ); + + if( org<0 ) + *b = '-'; + else + b++; + push_text( b ); + } +#endif break; case T_ARRAY: @@ -462,18 +491,18 @@ PMOD_EXPORT void o_cast_to_string(void) pop_stack(); push_string(s); } - return; + break; - case T_FLOAT: + case T_FLOAT: { + char buf[sizeNUM(double)*2]; sprintf(buf, "%f", (double)sp[-1].u.float_number); + push_text(buf); break; + } default: Pike_error("Cannot cast %s to string.\n", get_name_of_type(sp[-1].type)); } - - sp[-1].type = PIKE_T_STRING; - sp[-1].u.string = make_shared_string(buf); } PMOD_EXPORT void o_cast(struct pike_type *type, INT32 run_time_type) -- Sincerely, Stephen R. van den Berg. "I was standing in the park wondering why frisbees got bigger as they get closer. Then it hit me."

5 19

7.8 build fix for native Java methods
by Jonas Walld�n ＠ Pike developers forum 28 Aug '08

28 Aug '08

I'd like to enable native Java methods on OS X x86_64. Unfortunately the current configuration code fails to find ffi headers in Apple's standard location (/usr/include/ffi/ffi.h) so I've got a small patch for that: ceylon:Java $ cvs diff -u configure.in jvm.c Index: configure.in =================================================================== RCS file: /pike/data/cvsroot/Pike/7.8/src/modules/Java/configure.in,v retrieving revision 1.71 diff -u -r1.71 configure.in --- configure.in 18 Jul 2008 20:23:03 -0000 1.71 +++ configure.in 28 Aug 2008 13:36:22 -0000 @@ -313,9 +313,19 @@ PIKE_PKG_CONFIG(libffi) - AC_CHECK_HEADERS(jni.h winbase.h setjmp.h ffi.h) + # FFI on OS X (10.5 or newer) expects MACOSX defined + DO_IF_OS(Darwin, + [ + AC_SYS_COMPILER_FLAG(-DMACOSX, define_macosx, CPPFLAGS) + ]) + + AC_CHECK_HEADERS(jni.h winbase.h setjmp.h ffi.h ffi/ffi.h) AC_CHECK_TYPES([ffi_arg, ffi_sarg],,,[#ifdef HAVE_FFI_H #include <ffi.h> +#else +#ifdef HAVE_FFI_FFI_H +#include <ffi/ffi.h> +#endif #endif]) pike_cv_java=no @@ -413,7 +423,7 @@ pike_java_ffi=no AC_CHECK_LIB(ffi, ffi_prep_closure, [ - if test "$ac_cv_header_ffi_h" = yes; then + if test "$ac_cv_header_ffi_h" = yes -o "$ac_cv_header_ffi_ffi_h" = yes; then LIBS="-lffi $LIBS" JAVA_LIBS="-lffi ${JAVA_LIBS}" AC_DEFINE(HAVE_FFI) Index: jvm.c =================================================================== RCS file: /pike/data/cvsroot/Pike/7.8/src/modules/Java/jvm.c,v retrieving revision 1.91 diff -u -r1.91 jvm.c --- jvm.c 13 May 2008 16:00:07 -0000 1.91 +++ jvm.c 28 Aug 2008 13:36:22 -0000 @@ -50,6 +50,10 @@ #ifdef HAVE_FFI_H #include <ffi.h> +#else +#ifdef HAVE_FFI_FFI_H +#include <ffi/ffi.h> +#endif /* HAVE_FFI_FFI_H */ #endif /* HAVE_FFI_H */ #ifdef _REENTRANT Roxen will need it for 7.8 so ok to commit now?

3 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel