Pike-devel November 2017

pike-devel@lists.lysator.liu.se

7 participants
46 discussions

Re: Conditional inclusion of inotify_config.h?
by Chris Angelico 23 Nov '17

23 Nov '17

On Thu, Nov 23, 2017 at 7:58 AM, Martin Nilsson (Coppermist) @ Pike (-) developers forum <10353(a)lyskom.lysator.liu.se> wrote: > The change look good. I've no idea when you posted this, but I only just saw it. So I've merged that branch in now. The lyskom => mailing list gateway must have been down again. ChrisA

1 0

Abbreviated function definitions
by Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum 23 Nov '17

23 Nov '17

The "return void values from functions" issue reminded me of an idea I had several years ago for shorter "functional programming" style function definitions. The idea is that a function that just returns an expression can be written without the block and return statement: int add(int a, int b) = a + b; string `id() = "foo"; void delay(int ms) = sleep(ms*0.001); (The last example is where the "returning void" thing becomes relevant. :) It turns out that this can be implemented by adding a single line to language.yacc, so I pushed an implementation to the branch marcus/short_func. Opinions on adding this to 8.1?

5 6

Returning void from void functions
by Martin Nilsson (Coppermist) ＠ Pike (-) developers forum 23 Nov '17

23 Nov '17

Could we make this work without errors and warnings? Pike v8.1 release 9 running Hilfe v3.5 (Incremental Pike Frontend) > void foo() { } > void bar() { return foo(); } Compiler Warning: 1: Returning a void expression. Converted to zero. Compiler Error: 1: Wrong return type. Compiler Error: 1: Expected: void. Compiler Error: 1: Got : zero.

2 4

Handling errors in Protocols.DNS.server
by ceder (-) Per Cederqvist ＠ Pike (-) developers forum 23 Nov '17

23 Nov '17

Branches: ceder/7.8/override-decode-error ceder/8.0/override-decode-error ceder/8.1/override-decode-error If there is an error decoding a DNS message, the current code in Protocols.DNS.server prints a backtrace using werror() and responds to the request with a FORMERR response. In some settings, you might want to treat this (especially the error reporting) differently. The code on the branches I just pushed adds two methods to Protocols.DNS.server: - report_decode_error() is used to report errors. The default implementation uses the current werror() message, but derived classes may override it. - handle_decode_error() sends the FORMERR response. Derived classes may override it. We've been using Pike 7.8 with this change for a long time at Opera. (We don't actually override handle_decode_error(), only report_decode_error().) I just forwardported out change to Pike 8.0 as well, and it seems to work there as well. (I have not tested the Pike 8.1 implementation, but reading the source code I think it should also work.) Can I push these commits to the 7.8, 8.0 and 8.1 branches?

2 1

Conditional inclusion of inotify_config.h?
by Chris Angelico 23 Nov '17

23 Nov '17

Branch: rosuav/inotify-config Currently, inotify.cmod won't go looking for inotify_config.h unless HAVE_INOTIFY_CONFIG_H is defined. This doesn't seem to match the way other autoheader files get included, and it results in System.Inotify not being available even on systems that support inotify. How does this system work? Is the config file absent in some situations? Not merging this change into trunk yet in case it breaks stuff. ChrisA

2 1

MSYS again
by Martin Nilsson (Coppermist) ＠ Pike (-) developers forum 23 Nov '17

23 Nov '17

So I just started looking at building with MSYS/MingW, with some progress, so I thought I'd share some notes. Install using the installer from msys2.org and then follow the steps listed (run pacman -Syu, close shell and in a new one run pacman -Su) Then install additional packages: pacman -S gcc gmp-devel tar diffutils Copy and unpack a Pike source export. Run make. Now to the problems. I have issues with compiling threads.c in CONFIGURE_TEST mode. I think it has to do with configure doing too many assumptions on what works on Windows_NT, but just disabling NT_THREADS doesn't work either. There are packages for Nettle (pacman -S nettle libhogweed), but they lack header files. Latest Nettle builds and installs cleanly, but isn't properly detected by configure. There are some issues with mysql and jpeg that I'm ignoring for now with --without-mysql --without-jpeg.

3 4

RFC arne/large_reads
by el ＠ Pike developers forum 23 Nov '17

23 Nov '17

I just pushed a branch which makes Stdio.File()->read able to read more than 2GB at once. This in turn fixes Stdio.read_file() on large files. The new code also does not re-acquire the interpreter lock after every read in blocking mode, but instead only when it has been interrupted by a signal. I would like to add this to Pike 8.1, does anyone see any problems with this commit? Do we care about compat and can you imagine code which relies on the previous behavior? Arne

2 1

more on smartlink on darwin
by H. William Welliver III 23 Nov '17

23 Nov '17

I’ve looked a little more into the linking problems I’ve been having and noticed that on Darwin, smartlink.c is compiled to use LD_LIBRARY_PATH/LD_RUN_PATH. That’s problematic, because Darwin uses DYLD_LIBRARY_PATH and doesn’t have an equivalent of LD_RUN_PATH, so it doesn’t seem like smart link is doing much of anything for us on Darwin. I considered switching it to use -Wl,-rpath, however the darwin linker -rpath flag works differently from all of the other variants in that it only accepts one path per instance of the flag. smartlink.c seems to be set up to use a colon delimited list, which won’t work on Darwin (well, it isn’t rejected but won’t work as required). Before I start cluttering up smartlink.c with the code necessary to properly support the Darwin linker, does anyone have any thoughts? Bill

2 1

8.0 dump issues.
by Martin Nilsson (Coppermist) ＠ Pike (-) developers forum 23 Nov '17

23 Nov '17

In current 8.0 from git the JSON and BSON test suites do not work when running dumped Pike (make verify). Works fine with non-dumped (make just_verify).

1 0

The Crypto module and mere mortals
by Pontus Östlund 23 Nov '17

23 Nov '17

Everytime I need to use the Crypto module, a great wave of anxiety sweeps over me. For most common programmers the case is usually that you need to MD5 or SHA256 som some data to send over HTTP to some REST API or something like that, or compare something to a hash stored in a database or something like that. I had to make HMAC-SHA256 hash yesterday and it took me like 1,5 hours to figure that stuff out: String.string2hex(Crypto.HMAC(Crypto.SHA256)(secret)(data)); Not the most intuitive stuff if you ask me. That led me to the question: Why aren't there any helper methods directly in Crypto, for the more common use cases? So I've been fiddling around with it some and though that maybe something like below could be nice to have. This is just a mockup so feel free to point out if there are better ways to write the code, and if this is something that would fit at all. //! Typedef for a generic hashing function that takes a string as argument //! and returnes a hashed and @[String.string2hex]'ed string. typedef function(string(8bit):string(8bit)) hash_func_t; //! Typedef for a generic HMAC hash function that takes data and a secret as //! arguments and returns a hashed and @[String.string2hex]'ed string typedef function(string(8bit),string(8bit):string(8bit)) hash_hmac_func_t; protected hash_func_t make_hash_func(Crypto.Hash hash, void|bool raw) { return lambda (string in) { string s = hash->hash(in); return raw ? s : String.string2hex(s); }; } protected hash_hmac_func_t make_hash_hmac_func(Crypto.Hash hash, void|bool raw) { return lambda (string data, string secret) { string s = Crypto.HMAC(hash)(secret)(data); return raw ? s : String.string2hex(s); }; } //! Create a HMAC hash of @[data] and @[secret] using the Crypto module @[hash]. //! //! @param hash //! @param data //! @param secret string hash_hmac(Crypto.Hash hash, string data, string secret) { return make_hash_hmac_func(hash)(data, secret); } //! Creates a HMAC hashing function using the Crypto module @[hash]. This can //! later be called with the data and secret to make a hash of. //! //! @returns //! @tt{function(string, string : string)@} variant hash_hmac_func_t hash_hmac(Crypto.Hash hash) { return make_hash_hmac_func(hash); } //! Creates a hash of @[data] using the hashing algorithm in @[hash]. //! If @[raw] is given the hash will not pass through @[String.string2hex]. string hash(Crypto.Hash hash, string data, void|bool raw) { return make_hash_func(hash, raw)(data); } //! Creates a hashing function using the Crypto module @[hash]. This can later //! be called with the data to make a hash of. //! If @[raw] is given the hash will not pass through @[String.string2hex]. //! //! @returns //! @tt{function(string : string)@} variant hash_func_t hash(Crypto.Hash hash, void|bool raw) { return make_hash_func(hash, raw); } hash_hmac_func_t hmac_sha256 = hash_hmac(Crypto.SHA256); hash_hmac_func_t hmac_md5 = hash_hmac(Crypto.MD5); hash_func_t md5 = hash(Crypto.MD5); hash_func_t sha256 = hash(Crypto.SHA256); int main(int argc, array(string) argv) { string data = "my data"; string secret = "abc123"; write("%-20s %s\n", "hash_hmac(MD5):", hash_hmac(Crypto.MD5, data, secret)); write("%-20s %s\n", "hash_hmac_md5:", hmac_md5(data, secret)); write("%-20s %s\n", "hash_hmac_sha256:", hmac_sha256(data, secret)); write("%-20s %s\n", "hash(md5):", hash(Crypto.MD5, data)); write("%-20s %s\n", "hash(md5:raw):", hash(Crypto.MD5, data, true)); write("%-20s %s\n", "md5:", md5(data)); write("%-20s %s\n", "sha256:", sha256(data)); return 0; } Regards ----------------------------- Pontus Östlund Developer • Roxen AB +46 70-662 81 69 www.roxen.com <http://www.roxen.com/> | twitter.com/roxen <https://twitter.com/roxen>

3 2

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel November 2017