Pike-devel November 2017

pike-devel@lists.lysator.liu.se

7 participants
42 discussions

Conditional inclusion of inotify_config.h?
by Chris Angelico 22 Nov '17

22 Nov '17

Branch: rosuav/inotify-config Currently, inotify.cmod won't go looking for inotify_config.h unless HAVE_INOTIFY_CONFIG_H is defined. This doesn't seem to match the way other autoheader files get included, and it results in System.Inotify not being available even on systems that support inotify. How does this system work? Is the config file absent in some situations? Not merging this change into trunk yet in case it breaks stuff. ChrisA

2 1

MSYS again
by Martin Nilsson (Coppermist) ＠ Pike (-) developers forum 22 Nov '17

22 Nov '17

So I just started looking at building with MSYS/MingW, with some progress, so I thought I'd share some notes. Install using the installer from msys2.org and then follow the steps listed (run pacman -Syu, close shell and in a new one run pacman -Su) Then install additional packages: pacman -S gcc gmp-devel tar diffutils Copy and unpack a Pike source export. Run make. Now to the problems. I have issues with compiling threads.c in CONFIGURE_TEST mode. I think it has to do with configure doing too many assumptions on what works on Windows_NT, but just disabling NT_THREADS doesn't work either. There are packages for Nettle (pacman -S nettle libhogweed), but they lack header files. Latest Nettle builds and installs cleanly, but isn't properly detected by configure. There are some issues with mysql and jpeg that I'm ignoring for now with --without-mysql --without-jpeg.

3 4

RFC arne/large_reads
by el ＠ Pike developers forum 22 Nov '17

22 Nov '17

I just pushed a branch which makes Stdio.File()->read able to read more than 2GB at once. This in turn fixes Stdio.read_file() on large files. The new code also does not re-acquire the interpreter lock after every read in blocking mode, but instead only when it has been interrupted by a signal. I would like to add this to Pike 8.1, does anyone see any problems with this commit? Do we care about compat and can you imagine code which relies on the previous behavior? Arne

2 1

more on smartlink on darwin
by H. William Welliver III 22 Nov '17

22 Nov '17

I’ve looked a little more into the linking problems I’ve been having and noticed that on Darwin, smartlink.c is compiled to use LD_LIBRARY_PATH/LD_RUN_PATH. That’s problematic, because Darwin uses DYLD_LIBRARY_PATH and doesn’t have an equivalent of LD_RUN_PATH, so it doesn’t seem like smart link is doing much of anything for us on Darwin. I considered switching it to use -Wl,-rpath, however the darwin linker -rpath flag works differently from all of the other variants in that it only accepts one path per instance of the flag. smartlink.c seems to be set up to use a colon delimited list, which won’t work on Darwin (well, it isn’t rejected but won’t work as required). Before I start cluttering up smartlink.c with the code necessary to properly support the Darwin linker, does anyone have any thoughts? Bill

2 1

8.0 dump issues.
by Martin Nilsson (Coppermist) ＠ Pike (-) developers forum 22 Nov '17

22 Nov '17

In current 8.0 from git the JSON and BSON test suites do not work when running dumped Pike (make verify). Works fine with non-dumped (make just_verify).

1 0

The Crypto module and mere mortals
by Pontus Östlund 22 Nov '17

22 Nov '17

Everytime I need to use the Crypto module, a great wave of anxiety sweeps over me. For most common programmers the case is usually that you need to MD5 or SHA256 som some data to send over HTTP to some REST API or something like that, or compare something to a hash stored in a database or something like that. I had to make HMAC-SHA256 hash yesterday and it took me like 1,5 hours to figure that stuff out: String.string2hex(Crypto.HMAC(Crypto.SHA256)(secret)(data)); Not the most intuitive stuff if you ask me. That led me to the question: Why aren't there any helper methods directly in Crypto, for the more common use cases? So I've been fiddling around with it some and though that maybe something like below could be nice to have. This is just a mockup so feel free to point out if there are better ways to write the code, and if this is something that would fit at all. //! Typedef for a generic hashing function that takes a string as argument //! and returnes a hashed and @[String.string2hex]'ed string. typedef function(string(8bit):string(8bit)) hash_func_t; //! Typedef for a generic HMAC hash function that takes data and a secret as //! arguments and returns a hashed and @[String.string2hex]'ed string typedef function(string(8bit),string(8bit):string(8bit)) hash_hmac_func_t; protected hash_func_t make_hash_func(Crypto.Hash hash, void|bool raw) { return lambda (string in) { string s = hash->hash(in); return raw ? s : String.string2hex(s); }; } protected hash_hmac_func_t make_hash_hmac_func(Crypto.Hash hash, void|bool raw) { return lambda (string data, string secret) { string s = Crypto.HMAC(hash)(secret)(data); return raw ? s : String.string2hex(s); }; } //! Create a HMAC hash of @[data] and @[secret] using the Crypto module @[hash]. //! //! @param hash //! @param data //! @param secret string hash_hmac(Crypto.Hash hash, string data, string secret) { return make_hash_hmac_func(hash)(data, secret); } //! Creates a HMAC hashing function using the Crypto module @[hash]. This can //! later be called with the data and secret to make a hash of. //! //! @returns //! @tt{function(string, string : string)@} variant hash_hmac_func_t hash_hmac(Crypto.Hash hash) { return make_hash_hmac_func(hash); } //! Creates a hash of @[data] using the hashing algorithm in @[hash]. //! If @[raw] is given the hash will not pass through @[String.string2hex]. string hash(Crypto.Hash hash, string data, void|bool raw) { return make_hash_func(hash, raw)(data); } //! Creates a hashing function using the Crypto module @[hash]. This can later //! be called with the data to make a hash of. //! If @[raw] is given the hash will not pass through @[String.string2hex]. //! //! @returns //! @tt{function(string : string)@} variant hash_func_t hash(Crypto.Hash hash, void|bool raw) { return make_hash_func(hash, raw); } hash_hmac_func_t hmac_sha256 = hash_hmac(Crypto.SHA256); hash_hmac_func_t hmac_md5 = hash_hmac(Crypto.MD5); hash_func_t md5 = hash(Crypto.MD5); hash_func_t sha256 = hash(Crypto.SHA256); int main(int argc, array(string) argv) { string data = "my data"; string secret = "abc123"; write("%-20s %s\n", "hash_hmac(MD5):", hash_hmac(Crypto.MD5, data, secret)); write("%-20s %s\n", "hash_hmac_md5:", hmac_md5(data, secret)); write("%-20s %s\n", "hash_hmac_sha256:", hmac_sha256(data, secret)); write("%-20s %s\n", "hash(md5):", hash(Crypto.MD5, data)); write("%-20s %s\n", "hash(md5:raw):", hash(Crypto.MD5, data, true)); write("%-20s %s\n", "md5:", md5(data)); write("%-20s %s\n", "sha256:", sha256(data)); return 0; } Regards ----------------------------- Pontus Östlund Developer • Roxen AB +46 70-662 81 69 www.roxen.com <http://www.roxen.com/> | twitter.com/roxen <https://twitter.com/roxen>

3 2

Unaligned memory access
by Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum 22 Nov '17

22 Nov '17

Why do we have two sets of unaligned memory access functions? One is EXTRACT_xxx() in port.h (available since antiquity) which uses raw access iff the arch is IA32. The other is get_unaligned_xxx() in pike_memory.h (available since 2014) which uses raw access iff the arch is EM64T. Both have exactly the same implementation, except for the obvious descripancy in the list of arches getting special treatment. Shouldn't we consolidate this to just one copy of the implementation, and a consistent list of arches using raw access (preferrably using the define HANDLES_UNALIGNED_MEMORY_ACCESS which has also been available since antiquity...)?

2 2

IEEE floats
by Martin Nilsson (Coppermist) ＠ Pike (-) developers forum 22 Nov '17

22 Nov '17

Is there any platform we need to support that doesn't have IEEE floats?

2 9

UINT
by Martin Nilsson (Coppermist) ＠ Pike (-) developers forum 22 Nov '17

22 Nov '17

Is there a reason why we have UINT64 and UINT128 but not UINT32/16/8?

2 1

Buffer objects in SQLite
by el ＠ Pike developers forum 22 Nov '17

22 Nov '17

I agree, that Buffer objects (Stdio.Buffer, String.Buffer, etc.) are the natural API for binary data, however, they are not thread safe. As far as I can tell the SQLite module will allow other threads to run, who may invalidate the buffer storage (realloc or similar). We probably need to use SQLITE_TRANSIENT there. The same problem was (I think) also present in the previous version using strings in multisets.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel November 2017