Pike-devel July 2012

pike-devel@lists.lysator.liu.se

7 participants
25 discussions

Another minor Filesystem.Base complaint
by Bill Welliver 28 Jul '12

28 Jul '12

Is there a particular reason why the Stat object one gets from a Filesystem.Base object is different than a Stdio.Stat object? In particular, isdir and friends are flags in the Stdio.Stat object, while they're functions in Filesystem.Stat. Bill

2 2

Windows build environment / testing
by Tobias S. Josefowitz ＠ Pike developers forum 27 Jul '12

27 Jul '12

Hey all and Bill, I was wondering if there is any chance of getting hands on a windows build environment for debugging purposes. The nature of the build environment (and lack of windows) does not invite one to set it up himself, but it could be very helpful if we were able to check issues ourselves. Additionally, it would reduce Bill's workload on releases :) Best, Tobi

1 0

CMOD version 4 problem (was Re: CritBit build on Windows)
by H. William Welliver III 24 Jul '12

24 Jul '12

Hi Arne, Thanks… that seems to have resolved that set of errors. Unfortunately, I get a new error. I'm not actually sure it has anything to do with CritBit in particular, but rather the templated CMOD features. Here's the error: Z:/pike-git/src/post_modules/CritBit/redefine.H(54) : error C2010: '.' : unexpected in macro formal parameter list CL returned error code 2. Compilation command was: /Users/hww3/pike-git/bin/smartlink rntcl -I. -I/Users/hww3/pike-git/src/post_modules/CritBit -I/Users/hww3/pike-git/build/windows_xp-5.1.2600-i686 -I/Users/hww3/pike-git/src -IZ:/win32libs/include -I/Users/hww3/pike-git/build/windows_xp-5.1.2600-i686/bundles/include -DHAVE_CONFIG_H -g -MD -DDYNAMIC_MODULE -c /Users/hww3/pike-git/src/post_modules/CritBit/inttree.c -o inttree.o Obviously, redefine.H doesn't have 54 lines, so I dumped the precompiler output. I started looking for the problem but quickly went cross-eyed. I'll try to take a closer look when I'm more fully rested. I put a copy of the file at the following URL if anyone wants to have a look. http://bill.welliver.org/dist/pike/inttree.c.cppout Bill On Jul 23, 2012, at 3:15 AM, Arne Goedeke wrote: > hey bill, > > i think i found the last culprit. hope that fixes it now. > > arne

2 1

CritBit build on Windows
by H. William Welliver III 22 Jul '12

22 Jul '12

I'm in the middle of building Pike 7.9 on windows and am running into a few problems getting CritBit to compile. I've only spent a few minutes looking into the problems, but thought I should report them here, in case anyone has insight into how they should be resolved: 1. Windows doesn't have stdint.h; depending on how heavily CritBit relies on this header, it may be possible to use a substitute file from the following project (it at least shuts the compiler up): http://code.google.com/p/msinttypes/ 2. There seems to be some sort of problem with the generated C code from the new template based CMOD. The .c file was generated by 7.9.5 running on my Darwin system, so it just seems like the MS C compiler (CL.EXE) doesn't like something. I suspect it has something to do with lines like the following: # 1 "src/post_modules/CritBit/inttree.cmod" I've included the error below. Do let me know if I can provide any additional details. Best, Bill Compiling post_modules/CritBit/inttree.c src/post_modules/CritBit/inttree.cmod(1) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(1) : error C2019: expected preprocessor directive, found '2' /usr/local/pike/7.9.5/lib/modules/Tools.pmod/Standalone.pmod/precompile.pike(2739) : error C2019: expected preprocessor directive, found '1' z:\pike-git\src\post_modules\critbit\tree_low.c(185) : warning C4028: formal parameter 2 different from declaration z:\pike-git\src\post_modules\critbit\tree_low.c(365) : warning C4028: formal parameter 1 different from declaration z:\pike-git\src\post_modules\critbit\tree_high.c(46) : warning C4028: formal parameter 2 different from declaration src/post_modules/CritBit/inttree.cmod(39) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/redefine.H(54) : error C2010: '.' : unexpected in macro formal parameter list /Users/hww3/pike-git/src/post_modules/CritBit/redefine.H(61) : error C2019: expected preprocessor directive, found '3' src/post_modules/CritBit/inttree.cmod(41) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/tree_header.H(141) : error C2019: expected preprocessor directive, found '4' src/post_modules/CritBit/inttree.cmod(42) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/iterator_source.H(249) : error C2019: expected preprocessor directive, found '4' src/post_modules/CritBit/inttree.cmod(45) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/tree_source.H(689) : error C2019: expected preprocessor directive, found '4' src/post_modules/CritBit/inttree.cmod(128) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/redefine.H(61) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(130) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/tree_header.H(141) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(131) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/iterator_source.H(249) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(134) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/prefix.H(13) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(135) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/tree_source.H(689) : error C2019: expected preprocessor directive, found '1' CL returned error code 2. WARNING: Compiler failure! Trying without optimization! src/post_modules/CritBit/inttree.cmod(1) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(1) : error C2019: expected preprocessor directive, found '2' /usr/local/pike/7.9.5/lib/modules/Tools.pmod/Standalone.pmod/precompile.pike(2739) : error C2019: expected preprocessor directive, found '1' z:\pike-git\src\post_modules\critbit\tree_low.c(185) : warning C4028: formal parameter 2 different from declaration z:\pike-git\src\post_modules\critbit\tree_low.c(365) : warning C4028: formal parameter 1 different from declaration z:\pike-git\src\post_modules\critbit\tree_high.c(46) : warning C4028: formal parameter 2 different from declaration src/post_modules/CritBit/inttree.cmod(39) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/redefine.H(54) : error C2010: '.' : unexpected in macro formal parameter list /Users/hww3/pike-git/src/post_modules/CritBit/redefine.H(61) : error C2019: expected preprocessor directive, found '3' src/post_modules/CritBit/inttree.cmod(41) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/tree_header.H(141) : error C2019: expected preprocessor directive, found '4' src/post_modules/CritBit/inttree.cmod(42) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/iterator_source.H(249) : error C2019: expected preprocessor directive, found '4' src/post_modules/CritBit/inttree.cmod(45) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/tree_source.H(689) : error C2019: expected preprocessor directive, found '4' src/post_modules/CritBit/inttree.cmod(128) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/redefine.H(61) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(130) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/tree_header.H(141) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(131) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/iterator_source.H(249) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(134) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/prefix.H(13) : error C2019: expected preprocessor directive, found '1' src/post_modules/CritBit/inttree.cmod(135) : error C2019: expected preprocessor directive, found '1' /Users/hww3/pike-git/src/post_modules/CritBit/tree_source.H(689) : error C2019: expected preprocessor directive, found '1' CL returned error code 2. Compilation command was: /Users/hww3/pike-git/bin/smartlink rntcl -I. -I/Users/hww3/pike-git/src/post_modules/CritBit -I/Users/hww3/pike-git/build/windows_xp-5.1.2600-i686 -I/Users/hww3/pike-git/src -IZ:/win32libs/include -I/Users/hww3/pike-git/build/windows_xp-5.1.2600-i686/bundles/include -DHAVE_CONFIG_H -g -MD -DDYNAMIC_MODULE -c /Users/hww3/pike-git/src/post_modules/CritBit/inttree.c -o inttree.o

2 3

Re: Filesystem.System: get_dir and get_stat behave differently?
by Tobias S. Josefowitz 22 Jul '12

22 Jul '12

On Fri, Jul 20, 2012 at 11:55 PM, Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) @ Pike (-) developers forum <10353(a)lyskom.lysator.liu.se> wrote: > should be relative to the chroot point. The correct value is the of > full before the initial / was removed. But you could also use > "/"+full. Apparently full does not neccessarily include the / anyway. :)

2 1

Re: Filesystem.System: get_dir and get_stat behave differently?
by Tobias S. Josefowitz 21 Jul '12

21 Jul '12

On Fri, Jul 20, 2012 at 2:20 PM, Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) @ Pike (-) developers forum <10353(a)lyskom.lysator.liu.se> wrote: > variable "full"). So putting back the / should restore compatibility > with how it used to (and was supposed to) work before May 2001. .) - ok then.

3 2

Re: Filesystem.System: get_dir and get_stat behave differently?
by Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum 20 Jul '12

20 Jul '12

Before dcde88c3, the fullpath was set including the /. Mirar added stripping of the initial / to fix a chroot bug, which presumably means that he wanted to change the third parameter to combine_path(), not the value stored in stat->fullpath (which is set from the same local variable "full"). So putting back the / should restore compatibility with how it used to (and was supposed to) work before May 2001.

1 2

Re: Filesystem.System: get_dir and get_stat behave differently?
by Tobias S. Josefowitz 20 Jul '12

20 Jul '12

Hmm. I doubt I can just make fullpath contain the leading / because of compat etc, and the Filesystem.System()->cd() cannot just add it either. Any suggestions?

2 1

Filesystem.System: get_dir and get_stat behave differently?
by Bill Welliver 20 Jul '12

20 Jul '12

I noticed that if I have a Filesystem.System object and I chroot(), calling get_dir() with an absolute path will break out of the chroot. This doesn't happen with get_stat(), and it seems like it might be a bug. For example: Filesystem.System("/etc")->chroot("/etc")->get_dir("/") returns a list of items in the system root (/). If I do the same thing but replace the get_dir with get_stat(), I get a list of stat objects for /etc. The latter (get_stat) behavior seems correct to me. Can anyone confirm that the current behavior is actually correct? If not, I'll look into fixing it. Best, Bill

3 2

Failed test on 7.8.695
by Bill Welliver 18 Jul '12

18 Jul '12

I'm getting a test failure on the latest 7.8 build, and it looks like it exists to check a fix from last week. Please have a look and let me know if I should hold off on doing a new build for a fix. Thanks! Bill testsuite:2: syntax error, unexpected TOK_CONSTANT /Users/hww3/pike-git/src/testsuite.in:544: Test 138 (shift 0) failed. 1: mixed a() { return 2: constant foo = 5; 3: 4: // Test that it survives a F_ARG_LIST with CAR == CDR. 5: return foo%foo; 6: ; } 7: mixed b() { return 0; } 8:

4 4

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel July 2012