Pike-devel July 2008

pike-devel@lists.lysator.liu.se

8 participants
41 discussions

7.8 blockers
by Peter Bortas ＠ Pike developers forum 14 Aug '08

14 Aug '08

7.8 blockers: Owner Issue [/] Fallback to poll from epoll (from the conference road map). Implemented, but further testing is needed, as well as updated documentation. [ ] Fix gc of Stdio.File (from the conference road map). [ ] mast/zino New Windows build environment. [ ] per/marcus Performance regression --with-assembler. (per and marcus weren't present so item assigned without consent... per says memprotect() is responsible as far as -x benchmark goes.) [ ] zino/mast Building external modules should work. [ ] nilsson Write ChangeLog. [/] Module dumping should succeed for all modules. Currently it succeeds for all modules but 3: [ ] Tools.Standalone.dump [ ] Local [ ] Locale Non-blockers: [ ] jhs Build (SVG) graph from the -x benchmark results Pikefarm delivers to track development. [ ] An API for safely creating temporary files. Possibly wrapping mkstemp/mkdtemp. If you think you could help with any of the items please do. Especially the items that have no one assigned to them yet.

9 81

Re: SQLite glue segfault in 7.7
by Martin Stjernholm, Roxen IS ＠ Pike developers forum 04 Aug '08

04 Aug '08

> Not sure how you define "new"... I don't believe it's been available > before 7.7. I never looked at it because I have my own, but figured > it might be worthwhile to start using the one bundled. A bit late reply, but anyway: If SQLite is new in 7.7 I definitely think this should be fixed.

4 4

'if' with failing 'else' block
by Arjan van Staalduijnen 01 Aug '08

01 Aug '08

This morning I've been busy tracking a bug in my code, for which I have no explanation as to why it is a bug. The situation is I have an if-else test where, in case of a match, the if-block gets executed, but in case of a non-match, the else-block does NOT get executed. If I turn the whole test around by adding a NOT to the test, and swapping the if and else blocks, everything works. This is the code which has the bug: string key_name = "IssueID_shortname"; array qresult = myDB->Query("SHOW keys FROM dbFinalPublicationPassive.tbIssueDetails"); if (qresult && has_value(qresult->Key_name || ({}), key_name)) do_log("Index %O was already set", key_name); else { do_log("Adding index %O", key_name); myDB->Query("ALTER TABLE dbFinalPublicationPassive.tbIssueDetails" " ADD INDEX IssueID_shortname (IssueID, ShortName)"); } This code does not have the bug: string key_name = "IssueID_shortname"; array qresult = myDB->Query("SHOW keys FROM dbFinalPublicationPassive.tbIssueDetails"); if (!(qresult && has_value(qresult->Key_name || ({}), key_name))) { do_log("Adding index %O", key_name); myDB->Query("ALTER TABLE dbFinalPublicationPassive.tbIssueDetails" " ADD INDEX IssueID_shortname (IssueID, ShortName)"); } else do_log("Index %O was already set", key_name); Anyone has a clue? (Pike 7.4.464) Regards, Arjan __________________________________________________________ Deze e-mail en de inhoud is vertrouwelijk en uitsluitend bestemd voor de geadresseerde(n). Indien u niet de geadresseerde bent van deze e-mail verzoeken wij u dit direct door te geven aan de verzender door middel van een reply e-mail en de ontvangen e-mail uit uw systemen te verwijderen. Als u geen geadresseerde bent, is het niet toegestaan om kennis te nemen van de inhoud, deze te kopieren, te verspreiden, bekend te maken aan derden noch anderszins te gebruiken. The information contained in this e-mail is confidential and may be legally privileged. It is intended solely for the addressee. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful. Please notify us immediately if you have received it in error by reply e-mail and then delete this message from your system. __________________________________________________________

5 7

file_peek() minimum delay set to 1 millisecond
by Stephen R. van den Berg 31 Jul '08

31 Jul '08

In the poll() branch, files/file.c:file_peek() raises the minimum poll time from zero to one millisecond. This is wreaking havoc on poll-performance. Is there any reason to do so? I.e. I was trying to refactor _PGsql and downsize it is much as possible, i.e. trying to use Pike native modules instead of direct system calls, and it seems to work rather nicely, except for this poll-mess. I.e. I could take out the special poll code, if the standard files/file.c module would not introduce that extra delay. This is what we're talking about: diff --git a/src/modules/files/file.c b/src/modules/files/file.c index 6daf5c3..642f951 100644 --- a/src/modules/files/file.c +++ b/src/modules/files/file.c @@ -844,14 +844,20 @@ static void file_peek(INT32 args) struct pollfd fds; int timeout; timeout = (int)(tf*1000); /* ignore overflow for now */ +#if 0 if (!timeout) timeout = 1; +#endif fds.fd=FD; fds.events=POLLIN; fds.revents=0; - THREADS_ALLOW(); - ret=poll(&fds, 1, timeout); - THREADS_DISALLOW(); + if(timeout) { + THREADS_ALLOW(); + ret=poll(&fds, 1, timeout); + THREADS_DISALLOW(); + } + else + ret=poll(&fds, 1, 0); if(ret < 0) { It's a 40% speed difference caused by extra latency in the pgsql driver case. -- Sincerely, Stephen R. van den Berg. "Very funny, Mr. Scott. Now beam down my clothes!"

9 114

Re: werwhat? two bugs
by Mirar ＠ Pike developers forum 31 Jul '08

31 Jul '08

4 7

werwhat? two bugs
by Mirar ＠ Pike developers forum 31 Jul '08

31 Jul '08

What's going on here? | > for (int i=0; i<20; i++) werror((int)(((array(string))map(allocate(4,10000),random))*"")+"\n"); | 893854041314521p21222729747995344996322460933134167912308396922p465893192590510p409578404318720p249661099356465p9779173639706553527891623852799p763437599009880p923963626066665p195530491701805328348545865448 | 914429367511157p851488744731279p771291049428341p3407258449383175982468099614413597240422810389 Where did my linebreaks go and where did the p come from? In a sidenote, why doesn't | > random(10000000000000000); | (3) Result: 694383321 work as expected, when | > random(100000000000000000000000000000); | (2) Result: 1637481850962819326860743609 does?

4 7

Git repository bug
by Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum 30 Jul '08

30 Jul '08

I found a bug in the git repository: git blame README-CVS gives the following output at the end: 9eb55816 (Mikael Brandström 2002-04-06 20:49:08 +0000 250) o A descripti 9eb55816 (Mikael Brandström 2002-04-06 20:49:08 +0000 251) o If you know 9eb55816 (Mikael Brandström 2002-04-06 20:49:08 +0000 252) variables a 9eb55816 (Mikael Brandström 2002-04-06 20:49:08 +0000 253) o Or, if you 9eb55816 (Mikael Brandström 2002-04-06 20:49:08 +0000 254) bugfix alon but these lines are older, and were copied from the file README. Even CVS gets the annotations correct here, because in fact the ,v file was copied: 1.9 (nilsson 16-Oct-01): o A description of what it is that bugs and when. 1.11 (jhs 15-Feb-02): o If you know how, then also give us a backtrace and dump of vital 1.10 (nilsson 05-Nov-01): variables at the point of crash. 1.11 (jhs 15-Feb-02): o Or, if you found the error and corrected it, just send us the 1.10 (nilsson 05-Nov-01): bugfix along with a description of what you did and why. (OTOH, the CVS repository will of course give you incorrect results if you check out an old version of Pike, as README-CVS will appear alongside README even before it shoud exist.)

2 5

Svn repository
by Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum 30 Jul '08

30 Jul '08

A new Subversion conversion of the Pike repository, with better properties, is now available at svn+ssh://pike.ida.liu.se/pike/data/repos/Pike/ Please report any errors. Suggestions for even more improved properties are also welcome.

1 0

hostname_cache bug in Query.pike
by Mirar ＠ Pike developers forum 30 Jul '08

30 Jul '08

Would it be possible for someone to sneak in this bugfix in Query.pike at some stage? --- lib/modules/Protocols.pmod/HTTP.pmod/Query.pike.old 2007-04-15 14:24:41.000000000 +0200 +++ lib/modules/Protocols.pmod/HTTP.pmod/Query.pike 2008-07-29 09:04:35.000000000 +0200 @@ -500,7 +500,9 @@ array hosts = (Protocols.DNS.client()->gethostbyname( hostname )|| ({ 0, 0 }))[1]; - return sizeof(hosts) && hosts[random(sizeof( hosts ))]; + return + hostname_cache[hostname] = + ( sizeof(hosts) && hosts[random(sizeof( hosts ))] ); } to make the hostname_cache in Protocols.HTTP.Session work as intended.

3 7

Re: hostname_cache bug in Query.pike
by Mirar ＠ Pike developers forum 30 Jul '08

30 Jul '08

...so, for a new Query object the hostname_cache will always be empty, unless you supply it from some other direction before you start using the query object. So this doesn't affect for instance Protocols.HTTP.get_url et al, but it will affect Protocols.HTTP.Session()->get_url.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel July 2008