Pike-devel March 2006

pike-devel@lists.lysator.liu.se

5 participants
23 discussions

Getting GObjects from mixin objects
by davve (David Vest) ＠ Pike (-) developers forum 26 Mar '06

26 Mar '06

Trying to get a simple TreeView to display a list of strings I tried something like this: g_ui = GTK2.GladeXML("some_ui.glade"); g_ui->get_widget("test_treeview")->set_model(GTK2.ListStore(({"string"}))); To my surprise, the following returns zero: g_ui->get_widget("test_treeview")->get_model(); After some digging I found out that the generated code for GTK2.TreeView set_model failes to get a GObject from argument when it does something like this (returns NULL): GTK_TREE_MODEL(get_pg2object(<obj_on_stack>, pgtk2_tree_model_program)); For reference, the meat in get_pg2object does this: o=(struct object_wrapper *)get_storage(from,type); return o->obj; But the storage for pgtk2_tree_model_program is a 'struct mixin_wrapper' so the cast seems dubious in this case. I suspect that the content of the mixin_wrapper (offset) should be used to pin-point the relevant 'object_wrapper' for a given program. Should some find of specialized function be introduced for this? I have this in my source/support.c just to get my simple example to work: GObject *get_pg2object_mixin(struct object *from, struct program *type) { struct object_wrapper * o; struct mixin_wrapper * m; if (!from) return NULL; m=(struct mixin_wrapper *)get_storage(from,type); o=(struct object_wrapper *)from->storage + m->offset; return o->obj; } and then uses that in TreeView.set_model() This requires the caller to know if an object is a mixin-object or not. Is it better so to mark mixin-programs in some way so that get_pg2object() knows better how to extract object_wrappers from storage? Or have I missed something fundamental?

1 0

upgrading modules crashes pike?
by Adam Montague 24 Mar '06

24 Mar '06

Does pike not load modules completely when they are first accessed? I have some long running (24/7) pike scripts, and I just noticed that if I upgrade a C module they use, all those pikes will segfault. Adam

3 2

Re: sprintf %O
by Henrik Grubbstr�m (Lysator) ＠ Pike (-) developers forum 21 Mar '06

21 Mar '06

I suggest %Q for the new format.

7 28

sprintf %O
by Martin Nilsson (Opera) ＠ Pike (-) developers forum 20 Mar '06

20 Mar '06

While the new multiline sprintf %O looks snazzy, it will break code for everyone that uses it to ensure that a string contains no "bad" characters. Think log files, one line per entry. This needs to be reverted IMO as the effects on applications are hard to determine. For reference: Pike v7.7 release 23 running Hilfe v3.5 (Incremental Pike Frontend) > "foo\nbar"; (1) Result: "foo\n" "bar"

9 19

Pike on OS X/x86
by Jonas Walld�n ＠ Pike developers forum 18 Mar '06

18 Mar '06

We're going to get an Intel-based OS X machine next week, but I heard that other people have already experimented with compiling Pike for it. Any patches to e.g. configure scripts that can be checked in? Getting machine code to work shouldn't be too hard either I believe.

3 2

common_draw.inc
by davve (David Vest) ＠ Pike (-) developers forum 15 Mar '06

15 Mar '06

The following testcase crashes 7.7 HEAD: ----------- void handle_expose(GTK2.Widget widget, array events, int dummy) { int width = widget->allocation()->width; int height = widget->allocation()->height; Image.Image image = Image.Image(width,height,0,255,0); GTK2.GdkPixmap pixmap = GTK2.GdkPixmap(image); widget->draw_pixmap(GTK2.GdkGC(widget), pixmap, 0, 0, 0, 0, width, height); } int main(int argc, array(string) argv) { GTK2.Widget drawing_area; GTK2.setup_gtk(); GTK2.Widget window = GTK2.Window(GTK2.GTK_WINDOW_TOPLEVEL); window->set_default_size(300, 300); window->signal_connect("destroy", GTK2.main_quit); drawing_area = GTK2.DrawingArea(); window->add(drawing_area); drawing_area->signal_connect("expose-event", handle_expose); window->show_all(); GTK2.main(); } ----------- The error lies in 7.7/src/post_modules/GTK2/source/common_draw.inc and the following patch fixes the problem for draw_pixmap(): =================================================================== RCS file: /cvs/Pike/7.7/src/post_modules/GTK2/source/common_draw.inc,v retrieving revision 1.6 diff -u -r1.6 common_draw.inc --- common_draw.inc 27 Feb 2006 12:23:15 -0000 1.6 +++ common_draw.inc 15 Mar 2006 08:46:02 -0000 @@ -144,7 +144,7 @@ get_all_args("draw_pixmap",args,"%o%o%+%+%+%+%i%i", &g,&p,&xs,&ys,&xd,&yd,&w,&h); if (w>0 && h>0) - gdk_draw_pixmap(TWIN,GC(g),GDK_DRAWABLE(p),xs,ys,xd,yd,w,h); + gdk_draw_pixmap(TWIN,GC(g),GDK_DRAWABLE(get_gdkobject(p, pixmap)),xs,ys,xd,yd,w,h); RETURN_THIS(); } Some of the other draw_* in common_draw.inc do the same kind of strange casts from pike-objects to gtk-objects, so they should probably be looked at too.

1 0

[REVIEW] mapping.c: Double free
by Peter Bortas (nu med mindre Opera) ＠ Pike (-) developers forum 15 Mar '06

15 Mar '06

On about line 1658: if(ai->size > 1) { ... free((char *)zipper); } ... free((char *)zipper);

2 2

rbtree.c: grandparentless?
by Peter Bortas (nu med mindre Opera) ＠ Pike (-) developers forum 08 Mar '06

08 Mar '06

I'm doing a code review fixing up some things while I'm going. Code in the intricate core parts will be untouched until discussed here though. On line 340 of rbtree.c we belive that granparent might be 0, but a few lines down it's dereferenced as if that was not an option. Either the first if in assignment of top is unneeded and should go, or things will blow up. If PIKE_DEBUG is set it will fatal on grandparenslessness, but that also makes the top assignment above it useless.

2 11

New beta: 7.6.68
by Peter Bortas (nu med mindre Opera) ＠ Pike (-) developers forum 06 Mar '06

06 Mar '06

http://pike.ida.liu.se/pub/pike/beta/7.6.68/Pike-v7.6.68.tar.gz Not very well tested and unlikely to be the final release, but give it a whirl and you if your most hated bug is still in it.

2 4

make doc broken
by Peter Bortas (nu med mindre Opera) ＠ Pike (-) developers forum 06 Mar '06

06 Mar '06

make doc has was broken somewhere between 7.6.66 and now. Whoever did it feel free to fix. /home/zino/hack/Pike/7.6/build/linux-2.6.12-1-686-smp-i686/pike -DNOT_INSTALLED -DPRECOMPILED_SEARCH_MORE -m/home/zino/hack/Pike/7.6/build/linux-2.6.12-1-686-smp-i686/master.pike -x extract_autodoc -q --srcdir=/home/zino/hack/Pike/7.6/lib \ --imgsrc=/home/zino/hack/Pike/7.6/refdoc/src_images --builddir=doc_build/lib \ --imgdir=doc_build/images Bad argument 1 to `()(). Expected string. Unknown program: `()(743)

3 15

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel March 2006