I've waved a magic wand at the players command, let me know what you think.
Changes: * Removed -l, --league option * Fetches team_id and season if they aren't specified * Added some documentation * Changed some write's to make it possible to translate them
On Tue, 27 Jan 2004, Kent Karlsson wrote:
I've waved a magic wand at the players command, let me know what you think.
Changes:
- Removed -l, --league option
- Fetches team_id and season if they aren't specified
- Added some documentation
- Changed some write's to make it possible to translate them
Ok, I applied the patch. I had to do it manually though, since it for some reason didn't want to apply to the codebase.
Also, normal comments begins with "#". The """bla bla""" type of documentation is for functions and classes.
Another thing: Are the problems with the Matchviewer still there? I don't know how to fix the things. It would be nice if you tried something yourself.
/Ragnar
On 2004-01-27, at 19.49, Ragnar Ouchterlony wrote:
Ok, I applied the patch. I had to do it manually though, since it for some reason didn't want to apply to the codebase.
Strange, the diff was to the latest cvs.
Also, normal comments begins with "#". The """bla bla""" type of documentation is for functions and classes.
Ah, I just assumed """bla bla""" was like /* */
Another thing: Are the problems with the Matchviewer still there? I don't know how to fix the things. It would be nice if you tried something yourself.
I haven't had the time to watch any games with it and I'm going to northern sweden for a couple of days off, starting tomorrow.
-- kent
On Tue, 27 Jan 2004, Kent Karlsson wrote:
On 2004-01-27, at 19.49, Ragnar Ouchterlony wrote:
Ok, I applied the patch. I had to do it manually though, since it for some reason didn't want to apply to the codebase.
Strange, the diff was to the latest cvs.
Yes, I know, but it wouldn't apply. Maybe I did something wrong.
Also, normal comments begins with "#". The """bla bla""" type of documentation is for functions and classes.
Ah, I just assumed """bla bla""" was like /* */
No, that stuff is a language construct to help retrieve documentation with tools like pydoc.
Another thing: Are the problems with the Matchviewer still there? I don't know how to fix the things. It would be nice if you tried something yourself.
I haven't had the time to watch any games with it and I'm going to northern sweden for a couple of days off, starting tomorrow.
Ok, we will probably get out with a release candidate very soon, though and it would be good to fix as many problems as possible before the big release.
/Ragnar
Hi guys,
today at 20 minutes in friendly game, I got this error message. in matchviewer
Traceback (most recent call last): File "/root/Mattricks/Mattricks/TeamList.py", line 131, in OnAddMatch Main.notebook_pages["matchview"].AddMatchFromTeamID(team_id) File "/root/Mattricks/Mattricks/MatchViewerPage.py", line 161, in AddMatchFromTeamID match_info=MatchInfo.CurrentMatches(team_id, force_update=True) File "/root/Mattricks/Mattricks/MatchInfo.py", line 28, in __init__ self.__extract_data(team_id, force_update, progress_dialog) File "/root/Mattricks/Mattricks/MatchInfo.py", line 41, in __extract_data if not self.match.has_key(int(ind)): ValueError: invalid literal for int():
greets bart
On Wed, 28 Jan 2004, bart van der hall wrote:
Hi guys,
today at 20 minutes in friendly game, I got this error message. in matchviewer
Traceback (most recent call last): File "/root/Mattricks/Mattricks/TeamList.py", line 131, in OnAddMatch
...
if not self.match.has_key(int(ind)):ValueError: invalid literal for int():
I've got the same thing earlier today. I believe it has something to do with a strange reply from the HT server not being caught. I'll add some code later on tonight that hopefully will make it go away...
/Oscar
Yesterday evening I added some error checking to the relevant places. So now, these errors will not appear (that often...).
I think it is caused by the HT database timing out, the nice white page with just some text at the top.
We'll see if it works this weekend...
/Oscar
Hello,
27 jan 2004 16:08, Kent Karlsson wrote:
I've waved a magic wand at the players command, let me know what you think.
Changes:
- Removed -l, --league option
- Fetches team_id and season if they aren't specified
- Added some documentation
- Changed some write's to make it possible to translate them
wishlist: * copy option --user, --pasword, -d from command fetch to command players (or better move these options to main options). For instance $> mattricks.py -u narepl -p xxx players -s 9 -t 264971
Regards,
mattricks@lists.lysator.liu.se
-
Arkadiusz Kindziuk -
bart van der hall -
Kent Karlsson -
Oscar Gustafsson -
Ragnar Ouchterlony