Hi;
I've make a patch to get more information from the event keys in the match viewer, file attached.
I have a very basic english and this is my first time with python :-( the code and the text strings should be reviewed.
PS: Should I apply as a CHPP developer to send patchs for mattricks?
Regards;
I've make a patch to get more information from the event keys in the match viewer, file attached.
Thanks, really nice!
I have a very basic english and this is my first time with python :-( the code and the text strings should be reviewed.
Looks good. There are, off course, things that can be written differently, but it works and that's the most important thing! It takes a while to learn all python's nice features.
PS: Should I apply as a CHPP developer to send patchs for mattricks?
No, there is no need for that. However, if you would like to continue developing Mattricks (which would be nice) we can set up cvs-access for you, so that you can commit your own patches.
I have checked it in and is planning to make it optional (I try to make most features optional), so expect one more check in, soon.
/Oscar
I posted a link to the source in the CHPP conference in a discussion about event keys. Here is the reply:
---
Looks pretty much the same. Let me point out the differences:
* 106/206 is missing in your version, however I have seen examples of it * 118 is classified as corner (Hattristics: corner+head) and 119 as co+head (Hattristics: head) Let me check that again with the German texts * In your opinion, is 119 regular chance? Does it not involve a head specialist? * 137 is "winger to head". Does that mean, it needs a head specialist in the middle? * 138: does it need to be a winger who has the passing, is there a specialty involved? * 238 is mentioned, have you ever seen it?
---
If you would like to comment on it, I can forward your comments to the conference.
/Oscar
En/na Oscar Gustafsson ha escrit:
I posted a link to the source in the CHPP conference in a discussion about event keys. Here is the reply:
Thanks, I only reviewed matches and I didn't retain the match ids :(
Looks pretty much the same. Let me point out the differences:
- 106/206 is missing in your version, however I have seen examples of it
Ooops! I've lost this one :-( What SE is 106/206?
- 118 is classified as corner (Hattristics: corner+head) and 119 as
co+head (Hattristics: head) Let me check that again with the German texts
- In your opinion, is 119 regular chance? Does it not involve a head
specialist?
I think that there are 2 corner S.E. one involving a head specialist and scored with the head (118) and other with a non-head specialist (119).
- 137 is "winger to head". Does that mean, it needs a head specialist in
the middle?
- 138: does it need to be a winger who has the passing, is there a
specialty involved?
I think that there is at least two winger S.E. one passing to a winger and/or forward head specialist (and scored with head) (137) and other scored by a forward and may be a winger non-head specialist with sufficient scoring skill.
Reviewing the texts and the rules I think that we should change "winger pass to forw." to winger pass to f/w".
- 238 is mentioned, have you ever seen it?
I'm not sure, when I fond a 2xx chance or a 1xx goal I put the other in the code; and the winger S.E. is very rare and it's possible that I onlu found the 138.
I reviewed more than a hundred matches to get that S.E. but I'm sure that there are some ones that I didn't found, when a not know S.E. is shown in the viewed the code is shown in the viewer, I hope they will be reported in the conference.
If you would like to comment on it, I can forward your comments to the conference.
Thanks.
Regards,
En/na Oscar Gustafsson ha escrit:
PS: Should I apply as a CHPP developer to send patchs for mattricks?
No, there is no need for that. However, if you would like to continue developing Mattricks (which would be nice) we can set up cvs-access for you, so that you can commit your own patches.
Thanks, but before getting cvs-access I preffer to improve my knowledge about python and wxpython; I don't want to break mattricks ;) sending patches to you (or the mattricks list) is fine for me.
Regards;
mattricks@lists.lysator.liu.se