- Pike-automation - lists.lysator.liu.se

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 13 Nov '20

13 Nov '20

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 3 new defect(s) introduced to Pike-master found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1458076: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3724 in yysyntax_error() ________________________________________________________________________________________________________ *** CID 1458076: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3724 in yysyntax_error() 3718 } 3719 3720 if (*yymsg_alloc < yysize) 3721 { 3722 *yymsg_alloc = 2 * yysize; 3723 if (! (yysize <= *yymsg_alloc >>> CID 1458076: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> "*yymsg_alloc <= 9223372036854775807L /* (long)((9223372036854775807L < (unsigned long)-1) ? 9223372036854775807L : (unsigned long)-1) */" is always true regardless of the values of its operands. This occurs as the logical second operand of "&&". 3724 && *yymsg_alloc <= YYSTACK_ALLOC_MAXIMUM)) 3725 *yymsg_alloc = YYSTACK_ALLOC_MAXIMUM; 3726 return 1; 3727 } 3728 3729 /* Avoid sprintf, as that infringes on the user's name space. ** CID 1458072: (CONSTANT_EXPRESSION_RESULT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3714 in yysyntax_error() /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3685 in yysyntax_error() ________________________________________________________________________________________________________ *** CID 1458072: (CONSTANT_EXPRESSION_RESULT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3714 in yysyntax_error() 3708 } 3709 3710 { 3711 /* Don't count the "%s"s in the final size, but reserve room for 3712 the terminator. */ 3713 YYPTRDIFF_T yysize1 = yysize + (yystrlen (yyformat) - 2 * yycount) + 1; >>> CID 1458072: (CONSTANT_EXPRESSION_RESULT) >>> "yysize1 <= 9223372036854775807L /* (long)((9223372036854775807L < (unsigned long)-1) ? 9223372036854775807L : (unsigned long)-1) */" is always true regardless of the values of its operands. This occurs as the logical second operand of "&&". 3714 if (yysize <= yysize1 && yysize1 <= YYSTACK_ALLOC_MAXIMUM) 3715 yysize = yysize1; 3716 else 3717 return 2; 3718 } 3719 /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3685 in yysyntax_error() 3679 break; 3680 } 3681 yyarg[yycount++] = yytname[yyx]; 3682 { 3683 YYPTRDIFF_T yysize1 3684 = yysize + yytnamerr (YY_NULLPTR, yytname[yyx]); >>> CID 1458072: (CONSTANT_EXPRESSION_RESULT) >>> "yysize1 <= 9223372036854775807L /* (long)((9223372036854775807L < (unsigned long)-1) ? 9223372036854775807L : (unsigned long)-1) */" is always true regardless of the values of its operands. This occurs as the logical second operand of "&&". 3685 if (yysize <= yysize1 && yysize1 <= YYSTACK_ALLOC_MAXIMUM) 3686 yysize = yysize1; 3687 else 3688 return 2; 3689 } 3690 } ** CID 20290: Control flow issues (MISSING_BREAK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3580 in yytnamerr() ________________________________________________________________________________________________________ *** CID 20290: Control flow issues (MISSING_BREAK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/language.c_src: 3580 in yytnamerr() 3574 switch (*++yyp) 3575 { 3576 case '\'': 3577 case ',': 3578 goto do_not_strip_quotes; 3579 >>> CID 20290: Control flow issues (MISSING_BREAK) >>> The case for value "'\\'" is not terminated by a 'break' statement. 3580 case '\\': 3581 if (*++yyp != '\\') 3582 goto do_not_strip_quotes; 3583 else 3584 goto append; 3585 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for Pike-stable
by scan-admin＠coverity.com 01 Jul '20

01 Jul '20

Hi, Please find the latest report on new defect(s) introduced to Pike-stable found with Coverity Scan. 21 new defect(s) introduced to Pike-stable found with Coverity Scan. 13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 21 defect(s) ** CID 1465079: (USE_AFTER_FREE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2018 in multiset_insert_2() /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2018 in multiset_insert_2() /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2018 in multiset_insert_2() ________________________________________________________________________________________________________ *** CID 1465079: (USE_AFTER_FREE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2018 in multiset_insert_2() 2012 else 2013 switch (find_type) { 2014 case FIND_LESS: 2015 case FIND_GREATER: 2016 sub_extra_ref (msd); 2017 if (prepare_for_add (l, 1)) { >>> CID 1465079: (USE_AFTER_FREE) >>> Dereferencing freed pointer "msd". 2018 rbstack_shift (rbstack, HDR (msd->nodes), HDR (l->msd->nodes)); 2019 msd = l->msd; 2020 } 2021 ALLOC_MSNODE (msd, l->node_refs, new); 2022 goto insert; 2023 /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2018 in multiset_insert_2() 2012 else 2013 switch (find_type) { 2014 case FIND_LESS: 2015 case FIND_GREATER: 2016 sub_extra_ref (msd); 2017 if (prepare_for_add (l, 1)) { >>> CID 1465079: (USE_AFTER_FREE) >>> Dereferencing freed pointer "msd". 2018 rbstack_shift (rbstack, HDR (msd->nodes), HDR (l->msd->nodes)); 2019 msd = l->msd; 2020 } 2021 ALLOC_MSNODE (msd, l->node_refs, new); 2022 goto insert; 2023 /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2018 in multiset_insert_2() 2012 else 2013 switch (find_type) { 2014 case FIND_LESS: 2015 case FIND_GREATER: 2016 sub_extra_ref (msd); 2017 if (prepare_for_add (l, 1)) { >>> CID 1465079: (USE_AFTER_FREE) >>> Dereferencing freed pointer "msd". 2018 rbstack_shift (rbstack, HDR (msd->nodes), HDR (l->msd->nodes)); 2019 msd = l->msd; 2020 } 2021 ALLOC_MSNODE (msd, l->node_refs, new); 2022 goto insert; 2023 ** CID 1465078: (USE_AFTER_FREE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2871 in merge_multisets() /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2824 in merge_multisets() /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2824 in merge_multisets() /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2871 in merge_multisets() ________________________________________________________________________________________________________ *** CID 1465078: (USE_AFTER_FREE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2871 in merge_multisets() 2865 val_types |= 1 << TYPEOF(RBNODE (m.b_node)->iv.val); 2866 } 2867 }, { /* Free m.b_node. */ 2868 }); 2869 2870 else /* Destructive on a. */ >>> CID 1465078: (USE_AFTER_FREE) >>> Passing freed pointer "res_msd" as an argument to "merge_shift_ptrs". 2871 LOW_RB_MERGE ( 2872 ic_da, m.a_node, m.b_node, 2873 m.res_list, m.res_length, operation, 2874 2875 { 2876 low_use_multiset_index (RBNODE (m.a_node), a_ind); /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2824 in merge_multisets() 2818 if (TYPEOF(m.res->msd->cmp_less) == T_INT) { 2819 struct multiset_data *res_msd = m.res->msd; 2820 struct svalue a_ind, b_ind; 2821 m.a_node = HDR (m.a->msd->root), m.b_node = HDR (m.rd.b_msd->root); 2822 2823 if (m.rd.a_msd) /* Not destructive on a. */ >>> CID 1465078: (USE_AFTER_FREE) >>> Passing freed pointer "res_msd" as an argument to "merge_shift_ptrs". 2824 LOW_RB_MERGE ( 2825 ic_nd, m.a_node, m.b_node, 2826 m.res_list, m.res_length, operation, 2827 2828 { 2829 low_use_multiset_index (RBNODE (m.a_node), a_ind); /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2824 in merge_multisets() 2818 if (TYPEOF(m.res->msd->cmp_less) == T_INT) { 2819 struct multiset_data *res_msd = m.res->msd; 2820 struct svalue a_ind, b_ind; 2821 m.a_node = HDR (m.a->msd->root), m.b_node = HDR (m.rd.b_msd->root); 2822 2823 if (m.rd.a_msd) /* Not destructive on a. */ >>> CID 1465078: (USE_AFTER_FREE) >>> Passing freed pointer "res_msd" as an argument to "merge_shift_ptrs". 2824 LOW_RB_MERGE ( 2825 ic_nd, m.a_node, m.b_node, 2826 m.res_list, m.res_length, operation, 2827 2828 { 2829 low_use_multiset_index (RBNODE (m.a_node), a_ind); /home/covbuilder/pike/Pike-v8.0-snapshot/src/multiset.c: 2871 in merge_multisets() 2865 val_types |= 1 << TYPEOF(RBNODE (m.b_node)->iv.val); 2866 } 2867 }, { /* Free m.b_node. */ 2868 }); 2869 2870 else /* Destructive on a. */ >>> CID 1465078: (USE_AFTER_FREE) >>> Passing freed pointer "res_msd" as an argument to "merge_shift_ptrs". 2871 LOW_RB_MERGE ( 2872 ic_da, m.a_node, m.b_node, 2873 m.res_list, m.res_length, operation, 2874 2875 { 2876 low_use_multiset_index (RBNODE (m.a_node), a_ind); ** CID 1465072: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 431 in f_exp() ________________________________________________________________________________________________________ *** CID 1465072: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 431 in f_exp() 425 *! 426 *! @seealso 427 *! @[pow()], @[log()] 428 */ 429 void f_exp(INT32 args) 430 { >>> CID 1465072: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 431 ARG_CHECK("exp"); 432 SET_SVAL(sp[-1], T_FLOAT, 0, float_number, FL1(exp,sp[-1].u.float_number)); 433 } 434 435 /*! @decl int|float pow(float|int n, float|int x) 436 *! @decl mixed pow(object n, float|int|object x) ** CID 1465071: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 414 in f_log() ________________________________________________________________________________________________________ *** CID 1465071: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 414 in f_log() 408 *! 409 *! @seealso 410 *! @[pow()], @[exp()] 411 */ 412 void f_log(INT32 args) 413 { >>> CID 1465071: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 414 ARG_CHECK("log"); 415 if(sp[-1].u.float_number <=0.0) 416 Pike_error("Log on number less or equal to zero.\n"); 417 418 sp[-1].u.float_number = FL1(log,sp[-1].u.float_number); 419 } ** CID 1465069: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 495 in f_floor() ________________________________________________________________________________________________________ *** CID 1465069: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 495 in f_floor() 489 *! 490 *! @seealso 491 *! @[ceil()], @[round()] 492 */ 493 void f_floor(INT32 args) 494 { >>> CID 1465069: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 495 ARG_CHECK("floor"); 496 sp[-1].u.float_number = FL1(floor,sp[-1].u.float_number); 497 } 498 499 /*! @decl float ceil(int|float f) 500 *! ** CID 1465068: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 161 in f_acos() ________________________________________________________________________________________________________ *** CID 1465068: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 161 in f_acos() 155 *! 156 *! @seealso 157 *! @[cos()], @[asin()] 158 */ 159 void f_acos(INT32 args) 160 { >>> CID 1465068: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 161 ARG_CHECK("acos"); 162 if ((sp[-1].u.float_number >= -1.0) && 163 (sp[-1].u.float_number <= 1.0)) { 164 sp[-1].u.float_number = FL1(acos,sp[-1].u.float_number); 165 } else { 166 DECLARE_NAN; ** CID 1465067: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 182 in f_tan() ________________________________________________________________________________________________________ *** CID 1465067: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 182 in f_tan() 176 *! @seealso 177 *! @[atan()], @[sin()], @[cos()] 178 */ 179 void f_tan(INT32 args) 180 { 181 FLOAT_ARG_TYPE f; >>> CID 1465067: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 182 ARG_CHECK("tan"); 183 184 f = (sp[-1].u.float_number-M_PI/2) / M_PI; 185 if(f==floor(f+0.5)) 186 { 187 Pike_error("Impossible tangent.\n"); ** CID 1465066: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 239 in f_sinh() ________________________________________________________________________________________________________ *** CID 1465066: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 239 in f_sinh() 233 *! @seealso 234 *! @[asinh()], @[cosh()], @[tanh()] 235 */ 236 void f_sinh(INT32 args) 237 { 238 FLOAT_ARG_TYPE x; >>> CID 1465066: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 239 ARG_CHECK("sinh"); 240 x=sp[-1].u.float_number; 241 242 sp[-1].u.float_number = 243 DO_NOT_WARN ((FLOAT_TYPE) (0.5*(FA1(exp,x)-FA1(exp,-x)))); 244 } ** CID 1465065: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 512 in f_ceil() ________________________________________________________________________________________________________ *** CID 1465065: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 512 in f_ceil() 506 *! 507 *! @seealso 508 *! @[floor()], @[round()] 509 */ 510 void f_ceil(INT32 args) 511 { >>> CID 1465065: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 512 ARG_CHECK("ceil"); 513 sp[-1].u.float_number = FL1(ceil,sp[-1].u.float_number); 514 } 515 516 /*! @decl float round(int|float f) 517 *! ** CID 1465064: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 1864 in image_tuned_box_topbottom() ________________________________________________________________________________________________________ *** CID 1465064: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 1864 in image_tuned_box_topbottom() 1858 memcpy(dest,dest-xsize,length*sizeof(rgb_group)); 1859 dest+=xsize; 1860 } else { 1861 from = dest; 1862 for(x=0; x<64; x++) *(dest++) = color; 1863 for(;x<length-64;x+=64,dest+=64) >>> CID 1465064: Memory - corruptions (OVERLAPPING_COPY) >>> Copying 192 bytes from "from" to "dest", which point to overlapping memory locations. 1864 memcpy(dest, from, 64*sizeof(rgb_group)); 1865 for(;x<length; x++) *(dest++) = color; 1866 dest += xsize-length; 1867 old = color; 1868 } 1869 } ** CID 1465063: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 203 in f_atan() ________________________________________________________________________________________________________ *** CID 1465063: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 203 in f_atan() 197 *! 198 *! @seealso 199 *! @[tan()], @[asin()], @[acos()], @[atan2()] 200 */ 201 void f_atan(INT32 args) 202 { >>> CID 1465063: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 203 ARG_CHECK("atan"); 204 sp[-1].u.float_number = FL1(atan,sp[-1].u.float_number); 205 } 206 207 /*! @decl float atan2(float f1, float f2) 208 *! ** CID 1465062: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 113 in f_sin() ________________________________________________________________________________________________________ *** CID 1465062: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 113 in f_sin() 107 *! 108 *! @seealso 109 *! @[asin()], @[cos()], @[tan()] 110 */ 111 void f_sin(INT32 args) 112 { >>> CID 1465062: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 113 ARG_CHECK("sin"); 114 sp[-1].u.float_number = FL1(sin,sp[-1].u.float_number); 115 } 116 117 /*! @decl float asin(int|float f) 118 *! ** CID 1465061: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 290 in f_acosh() ________________________________________________________________________________________________________ *** CID 1465061: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 290 in f_acosh() 284 *! @seealso 285 *! @[cosh()], @[asinh()] 286 */ 287 void f_acosh(INT32 args) 288 { 289 FLOAT_ARG_TYPE x; >>> CID 1465061: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 290 ARG_CHECK("acosh"); 291 x=sp[-1].u.float_number; 292 293 sp[-1].u.float_number = 294 DO_NOT_WARN ((FLOAT_TYPE) (2*FA1(log,FA1(sqrt,0.5*(x+1))+FA1(sqrt,0.5*(x-1))))); 295 } ** CID 1465060: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 324 in f_atanh() ________________________________________________________________________________________________________ *** CID 1465060: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 324 in f_atanh() 318 *! @seealso 319 *! @[tanh()], @[asinh()], @[acosh()] 320 */ 321 void f_atanh(INT32 args) 322 { 323 FLOAT_ARG_TYPE x; >>> CID 1465060: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 324 ARG_CHECK("atanh"); 325 x=sp[-1].u.float_number; 326 327 sp[-1].u.float_number = 328 DO_NOT_WARN ((FLOAT_TYPE) (0.5*(FA1(log,1+x)-FA1(log,1-x)))); 329 } ** CID 1465059: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 127 in f_asin() ________________________________________________________________________________________________________ *** CID 1465059: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 127 in f_asin() 121 *! 122 *! @seealso 123 *! @[sin()], @[acos()] 124 */ 125 void f_asin(INT32 args) 126 { >>> CID 1465059: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 127 ARG_CHECK("asin"); 128 if ((sp[-1].u.float_number >= -1.0) && 129 (sp[-1].u.float_number <= 1.0)) { 130 sp[-1].u.float_number = FL1(asin,sp[-1].u.float_number); 131 } else { 132 DECLARE_NAN; ** CID 1465058: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 273 in f_cosh() ________________________________________________________________________________________________________ *** CID 1465058: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 273 in f_cosh() 267 *! @seealso 268 *! @[acosh()], @[sinh()], @[tanh()] 269 */ 270 void f_cosh(INT32 args) 271 { 272 FLOAT_ARG_TYPE x; >>> CID 1465058: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 273 ARG_CHECK("cosh"); 274 x=sp[-1].u.float_number; 275 276 sp[-1].u.float_number = 277 DO_NOT_WARN ((FLOAT_TYPE) (0.5*(FA1(exp,x)+FA1(exp,-x)))); 278 } ** CID 1465057: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 147 in f_cos() ________________________________________________________________________________________________________ *** CID 1465057: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 147 in f_cos() 141 *! 142 *! @seealso 143 *! @[acos()], @[sin()], @[tan()] 144 */ 145 void f_cos(INT32 args) 146 { >>> CID 1465057: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 147 ARG_CHECK("cos"); 148 sp[-1].u.float_number = FL1(cos,sp[-1].u.float_number); 149 } 150 151 /*! @decl float acos(int|float f) 152 *! ** CID 1465056: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 256 in f_asinh() ________________________________________________________________________________________________________ *** CID 1465056: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 256 in f_asinh() 250 *! @seealso 251 *! @[sinh()], @[acosh()] 252 */ 253 void f_asinh(INT32 args) 254 { 255 FLOAT_ARG_TYPE x; >>> CID 1465056: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 256 ARG_CHECK("asinh"); 257 x=sp[-1].u.float_number; 258 259 sp[-1].u.float_number = 260 DO_NOT_WARN ((FLOAT_TYPE) (FA1(log,x+FA1(sqrt,1+x*x)))); 261 } ** CID 1465055: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 307 in f_tanh() ________________________________________________________________________________________________________ *** CID 1465055: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/_math/math.c: 307 in f_tanh() 301 *! @seealso 302 *! @[atanh()], @[sinh()], @[cosh()] 303 */ 304 void f_tanh(INT32 args) 305 { 306 FLOAT_ARG_TYPE x; >>> CID 1465055: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 307 ARG_CHECK("tanh"); 308 x=sp[-1].u.float_number; 309 310 sp[-1].u.float_number = 311 DO_NOT_WARN ((FLOAT_TYPE) ((FA1(exp,x)-FA1(exp,-x))/(FA1(exp,x)+FA1(exp,-x)))); 312 } ** CID 1465054: (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/operators.c: 2233 in float_promote() /home/covbuilder/pike/Pike-v8.0-snapshot/src/operators.c: 2228 in float_promote() ________________________________________________________________________________________________________ *** CID 1465054: (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.0-snapshot/src/operators.c: 2233 in float_promote() 2227 { 2228 SET_SVAL(sp[-2], T_FLOAT, 0, float_number, (FLOAT_TYPE)sp[-2].u.integer); 2229 return 1; 2230 } 2231 else if(TYPEOF(sp[-1]) == T_INT && TYPEOF(sp[-2]) == T_FLOAT) 2232 { >>> CID 1465054: (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 2233 SET_SVAL(sp[-1], T_FLOAT, 0, float_number, (FLOAT_TYPE)sp[-1].u.integer); 2234 return 1; 2235 } 2236 2237 if(is_bignum_object_in_svalue(sp-2) && TYPEOF(sp[-1]) == T_FLOAT) 2238 { /home/covbuilder/pike/Pike-v8.0-snapshot/src/operators.c: 2228 in float_promote() 2222 } 2223 2224 static int float_promote(void) 2225 { 2226 if(TYPEOF(sp[-2]) == T_INT && TYPEOF(sp[-1]) == T_FLOAT) 2227 { >>> CID 1465054: (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-2].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 2228 SET_SVAL(sp[-2], T_FLOAT, 0, float_number, (FLOAT_TYPE)sp[-2].u.integer); 2229 return 1; 2230 } 2231 else if(TYPEOF(sp[-1]) == T_INT && TYPEOF(sp[-2]) == T_FLOAT) 2232 { 2233 SET_SVAL(sp[-1], T_FLOAT, 0, float_number, (FLOAT_TYPE)sp[-1].u.integer); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPkl…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 01 Jul '20

01 Jul '20

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 20 new defect(s) introduced to Pike-master found with Coverity Scan. 12 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 20 defect(s) ** CID 1465072: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 355 in f_exp() ________________________________________________________________________________________________________ *** CID 1465072: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 355 in f_exp() 349 *! 350 *! @seealso 351 *! @[pow()], @[log()] 352 */ 353 void f_exp(INT32 args) 354 { >>> CID 1465072: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 355 ARG_CHECK("exp"); 356 SET_SVAL(sp[-1], T_FLOAT, 0, float_number, FL(exp)(sp[-1].u.float_number)); 357 } 358 359 /*! @decl int|float pow(float|int n, float|int x) 360 *! @decl mixed pow(object n, float|int|object x) ** CID 1465071: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 338 in f_log() ________________________________________________________________________________________________________ *** CID 1465071: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 338 in f_log() 332 *! 333 *! @seealso 334 *! @[pow()], @[exp()] 335 */ 336 void f_log(INT32 args) 337 { >>> CID 1465071: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 338 ARG_CHECK("log"); 339 if(sp[-1].u.float_number <=0.0) 340 Pike_error("Log on number less or equal to zero.\n"); 341 342 sp[-1].u.float_number = FL(log)(sp[-1].u.float_number); 343 } ** CID 1465070: (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 1466 in pair_add() /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 1458 in pair_add() ________________________________________________________________________________________________________ *** CID 1465070: (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 1466 in pair_add() 1460 } 1461 } 1462 else if( TYPEOF(Pike_sp[-1]) == PIKE_T_FLOAT ) 1463 { 1464 if( TYPEOF(Pike_sp[-2]) == PIKE_T_INT ) 1465 { >>> CID 1465070: (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-2].u.integer" to "Pike_interpreter_pointer->stack_pointer[-2].u.float_number", which have overlapping memory locations and different types. 1466 Pike_sp[-2].u.float_number = Pike_sp[-2].u.integer; 1467 TYPEOF(Pike_sp[-2]) = PIKE_T_FLOAT; 1468 } 1469 } 1470 1471 if (TYPEOF(Pike_sp[-2]) != TYPEOF(Pike_sp[-1])) /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 1458 in pair_add() 1452 stack_swap(); 1453 } 1454 else if( TYPEOF(Pike_sp[-2]) == PIKE_T_FLOAT ) 1455 { 1456 if( TYPEOF(Pike_sp[-1]) == PIKE_T_INT ) 1457 { >>> CID 1465070: (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "Pike_interpreter_pointer->stack_pointer[-1].u.float_number", which have overlapping memory locations and different types. 1458 Pike_sp[-1].u.float_number = Pike_sp[-1].u.integer; 1459 TYPEOF(Pike_sp[-1]) = PIKE_T_FLOAT; 1460 } 1461 } 1462 else if( TYPEOF(Pike_sp[-1]) == PIKE_T_FLOAT ) 1463 { ** CID 1465069: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 384 in f_floor() ________________________________________________________________________________________________________ *** CID 1465069: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 384 in f_floor() 378 *! 379 *! @seealso 380 *! @[ceil()], @[round()] 381 */ 382 void f_floor(INT32 args) 383 { >>> CID 1465069: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 384 ARG_CHECK("floor"); 385 sp[-1].u.float_number = FL(floor)(sp[-1].u.float_number); 386 } 387 388 /*! @decl float ceil(int|float f) 389 *! ** CID 1465068: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 115 in f_acos() ________________________________________________________________________________________________________ *** CID 1465068: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 115 in f_acos() 109 *! 110 *! @seealso 111 *! @[cos()], @[asin()] 112 */ 113 void f_acos(INT32 args) 114 { >>> CID 1465068: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 115 ARG_CHECK("acos"); 116 if ((sp[-1].u.float_number >= -1.0) && 117 (sp[-1].u.float_number <= 1.0)) { 118 sp[-1].u.float_number = FL(acos)(sp[-1].u.float_number); 119 } else { 120 sp[-1].u.float_number = (FLOAT_TYPE) MAKE_NAN(); ** CID 1465067: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 135 in f_tan() ________________________________________________________________________________________________________ *** CID 1465067: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 135 in f_tan() 129 *! @seealso 130 *! @[atan()], @[sin()], @[cos()] 131 */ 132 void f_tan(INT32 args) 133 { 134 FLOAT_ARG_TYPE f; >>> CID 1465067: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 135 ARG_CHECK("tan"); 136 137 f = (sp[-1].u.float_number-M_PI/2) / M_PI; 138 if(f==floor(f+0.5)) 139 { 140 Pike_error("Impossible tangent.\n"); ** CID 1465066: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 191 in f_sinh() ________________________________________________________________________________________________________ *** CID 1465066: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 191 in f_sinh() 185 *! 186 *! @seealso 187 *! @[asinh()], @[cosh()], @[tanh()] 188 */ 189 void f_sinh(INT32 args) 190 { >>> CID 1465066: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 191 ARG_CHECK("sinh"); 192 sp[-1].u.float_number = FL(sinh)(sp[-1].u.float_number); 193 } 194 195 /*! @decl float asinh(int|float f) 196 *! ** CID 1465065: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 401 in f_ceil() ________________________________________________________________________________________________________ *** CID 1465065: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 401 in f_ceil() 395 *! 396 *! @seealso 397 *! @[floor()], @[round()] 398 */ 399 void f_ceil(INT32 args) 400 { >>> CID 1465065: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 401 ARG_CHECK("ceil"); 402 sp[-1].u.float_number = FL(ceil)(sp[-1].u.float_number); 403 } 404 405 /*! @decl float round(int|float f) 406 *! ** CID 1465064: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 1784 in image_tuned_box_topbottom() ________________________________________________________________________________________________________ *** CID 1465064: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 1784 in image_tuned_box_topbottom() 1778 memcpy(dest,dest-xsize,length*sizeof(rgb_group)); 1779 dest+=xsize; 1780 } else { 1781 from = dest; 1782 for(x=0; x<64; x++) *(dest++) = color; 1783 for(;x<length-64;x+=64,dest+=64) >>> CID 1465064: Memory - corruptions (OVERLAPPING_COPY) >>> Copying 192 bytes from "from" to "dest", which point to overlapping memory locations. 1784 memcpy(dest, from, 64*sizeof(rgb_group)); 1785 for(;x<length; x++) *(dest++) = color; 1786 dest += xsize-length; 1787 old = color; 1788 } 1789 } ** CID 1465063: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 156 in f_atan() ________________________________________________________________________________________________________ *** CID 1465063: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 156 in f_atan() 150 *! 151 *! @seealso 152 *! @[tan()], @[asin()], @[acos()], @[atan2()] 153 */ 154 void f_atan(INT32 args) 155 { >>> CID 1465063: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 156 ARG_CHECK("atan"); 157 sp[-1].u.float_number = FL(atan)(sp[-1].u.float_number); 158 } 159 160 /*! @decl float atan2(float f1, float f2) 161 *! ** CID 1465062: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 68 in f_sin() ________________________________________________________________________________________________________ *** CID 1465062: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 68 in f_sin() 62 *! 63 *! @seealso 64 *! @[asin()], @[cos()], @[tan()] 65 */ 66 void f_sin(INT32 args) 67 { >>> CID 1465062: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 68 ARG_CHECK("sin"); 69 sp[-1].u.float_number = FL(sin)(sp[-1].u.float_number); 70 } 71 72 /*! @decl float asin(int|float f) 73 *! ** CID 1465061: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 230 in f_acosh() ________________________________________________________________________________________________________ *** CID 1465061: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 230 in f_acosh() 224 *! 225 *! @seealso 226 *! @[cosh()], @[asinh()] 227 */ 228 void f_acosh(INT32 args) 229 { >>> CID 1465061: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 230 ARG_CHECK("acosh"); 231 sp[-1].u.float_number = FL(acosh)(sp[-1].u.float_number); 232 } 233 234 /*! @decl float tanh(int|float f) 235 *! ** CID 1465060: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 256 in f_atanh() ________________________________________________________________________________________________________ *** CID 1465060: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 256 in f_atanh() 250 *! 251 *! @seealso 252 *! @[tanh()], @[asinh()], @[acosh()] 253 */ 254 void f_atanh(INT32 args) 255 { >>> CID 1465060: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 256 ARG_CHECK("atanh"); 257 sp[-1].u.float_number = FL(atanh)(sp[-1].u.float_number); 258 } 259 260 /*! @decl float sqrt(float f) 261 *! @decl int sqrt(int i) ** CID 1465059: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 82 in f_asin() ________________________________________________________________________________________________________ *** CID 1465059: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 82 in f_asin() 76 *! 77 *! @seealso 78 *! @[sin()], @[acos()] 79 */ 80 void f_asin(INT32 args) 81 { >>> CID 1465059: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 82 ARG_CHECK("asin"); 83 if ((sp[-1].u.float_number >= -1.0) && 84 (sp[-1].u.float_number <= 1.0)) { 85 sp[-1].u.float_number = FL(asin)(sp[-1].u.float_number); 86 } else { 87 sp[-1].u.float_number = (FLOAT_TYPE) MAKE_NAN(); ** CID 1465058: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 217 in f_cosh() ________________________________________________________________________________________________________ *** CID 1465058: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 217 in f_cosh() 211 *! 212 *! @seealso 213 *! @[acosh()], @[sinh()], @[tanh()] 214 */ 215 void f_cosh(INT32 args) 216 { >>> CID 1465058: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 217 ARG_CHECK("cosh"); 218 sp[-1].u.float_number = FL(cosh)(sp[-1].u.float_number); 219 } 220 221 /*! @decl float acosh(int|float f) 222 *! ** CID 1465057: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 101 in f_cos() ________________________________________________________________________________________________________ *** CID 1465057: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 101 in f_cos() 95 *! 96 *! @seealso 97 *! @[acos()], @[sin()], @[tan()] 98 */ 99 void f_cos(INT32 args) 100 { >>> CID 1465057: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 101 ARG_CHECK("cos"); 102 sp[-1].u.float_number = FL(cos)(sp[-1].u.float_number); 103 } 104 105 /*! @decl float acos(int|float f) 106 *! ** CID 1465056: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 204 in f_asinh() ________________________________________________________________________________________________________ *** CID 1465056: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 204 in f_asinh() 198 *! 199 *! @seealso 200 *! @[sinh()], @[acosh()] 201 */ 202 void f_asinh(INT32 args) 203 { >>> CID 1465056: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 204 ARG_CHECK("asinh"); 205 sp[-1].u.float_number = FL(asinh)(sp[-1].u.float_number); 206 } 207 208 /*! @decl float cosh(int|float f) 209 *! ** CID 1465055: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 243 in f_tanh() ________________________________________________________________________________________________________ *** CID 1465055: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 243 in f_tanh() 237 *! 238 *! @seealso 239 *! @[atanh()], @[sinh()], @[cosh()] 240 */ 241 void f_tanh(INT32 args) 242 { >>> CID 1465055: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 243 ARG_CHECK("tanh"); 244 sp[-1].u.float_number = FL(tanh)(sp[-1].u.float_number); 245 } 246 247 /*! @decl float atanh(int|float f) 248 *! ** CID 1465054: (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 2104 in float_promote() /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 2099 in float_promote() ________________________________________________________________________________________________________ *** CID 1465054: (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 2104 in float_promote() 2098 { 2099 SET_SVAL(Pike_sp[-2], T_FLOAT, 0, float_number, (FLOAT_TYPE)Pike_sp[-2].u.integer); 2100 return 1; 2101 } 2102 else if(TYPEOF(Pike_sp[-1]) == T_INT && TYPEOF(Pike_sp[-2]) == T_FLOAT) 2103 { >>> CID 1465054: (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 2104 SET_SVAL(Pike_sp[-1], T_FLOAT, 0, float_number, (FLOAT_TYPE)Pike_sp[-1].u.integer); 2105 return 1; 2106 } 2107 2108 if(is_bignum_object_in_svalue(Pike_sp-2) && TYPEOF(Pike_sp[-1]) == T_FLOAT) 2109 { /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 2099 in float_promote() 2093 } 2094 2095 static int float_promote(void) 2096 { 2097 if(TYPEOF(Pike_sp[-2]) == T_INT && TYPEOF(Pike_sp[-1]) == T_FLOAT) 2098 { >>> CID 1465054: (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-2].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 2099 SET_SVAL(Pike_sp[-2], T_FLOAT, 0, float_number, (FLOAT_TYPE)Pike_sp[-2].u.integer); 2100 return 1; 2101 } 2102 else if(TYPEOF(Pike_sp[-1]) == T_INT && TYPEOF(Pike_sp[-2]) == T_FLOAT) 2103 { 2104 SET_SVAL(Pike_sp[-1], T_FLOAT, 0, float_number, (FLOAT_TYPE)Pike_sp[-1].u.integer); ** CID 1465053: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 418 in f_round() ________________________________________________________________________________________________________ *** CID 1465053: Memory - corruptions (OVERLAPPING_COPY) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_math/math.c: 418 in f_round() 412 *! 413 *! @seealso 414 *! @[floor()], @[ceil()] 415 */ 416 void f_round(INT32 args) 417 { >>> CID 1465053: Memory - corruptions (OVERLAPPING_COPY) >>> Assigning "Pike_interpreter_pointer->stack_pointer[-1].u.integer" to "__sv_ptr->u.float_number", which have overlapping memory locations and different types. 418 ARG_CHECK("round"); 419 sp[-1].u.float_number = FL(rint)(sp[-1].u.float_number); 420 } 421 422 423 /*! @decl int|float|object limit(int|float|object minval, int|float|object x, int|float|object maxval) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPkl…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 02 Apr '20

02 Apr '20

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 2 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1461177: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/docode.c: 3274 in docode() ________________________________________________________________________________________________________ *** CID 1461177: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/docode.c: 3274 in docode() 3268 struct byte_buffer instrbuf_save = instrbuf; 3269 struct statement_label *label_save; 3270 3271 PUSH_STATEMENT_LABEL; 3272 label_save = current_label->prev; 3273 current_label->prev = NULL; >>> CID 1461177: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "current_label->prev". 3274 PUSH_CLEANUP_FRAME(NULL, NULL); 3275 label_no=1; 3276 current_stack_depth = 0; 3277 Pike_compiler->compiler_frame->generator_local = -1; 3278 init_bytecode(); 3279 ** CID 1461176: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/docode.c: 3033 in do_code_block() ________________________________________________________________________________________________________ *** CID 1461176: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/docode.c: 3033 in do_code_block() 3027 3028 init_bytecode(); 3029 label_no=1; 3030 PUSH_STATEMENT_LABEL; 3031 save_label = current_label->prev; 3032 current_label->prev = NULL; >>> CID 1461176: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "current_label->prev". 3033 PUSH_CLEANUP_FRAME(NULL, NULL); 3034 current_stack_depth = 0; 3035 3036 /* NOTE: This is no ordinary label... */ 3037 low_insert_label(0); 3038 emit0(F_ENTRY); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPkl…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 21 Jan '20

21 Jan '20

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1457890: Resource leaks (RESOURCE_LEAK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_Stdio/file.c: 2747 in my_openpty() ________________________________________________________________________________________________________ *** CID 1457890: Resource leaks (RESOURCE_LEAK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/_Stdio/file.c: 2747 in my_openpty() 2741 * Not required on Solaris 11.4 and later. 2742 */ 2743 ioctl(s, I_PUSH, "ptem"); /* Pseudo terminal emulation mode */ 2744 ioctl(s, I_PUSH, "ldterm"); /* Terminal line discipline */ 2745 ioctl(s, I_PUSH, "ttcompat"); /* BSD terminal compatibility */ 2746 #endif >>> CID 1457890: Resource leaks (RESOURCE_LEAK) >>> Handle variable "s" going out of scope leaks the handle. 2747 return 0; 2748 } 2749 } 2750 close(m); 2751 return -1; 2752 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 14 Nov '19

14 Nov '19

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1455693: (NEGATIVE_RETURNS) /home/covbuilder/pike/Pike-v8.1-snapshot/src/peep_engine.c: 772 in _asm_peep_11() /home/covbuilder/pike/Pike-v8.1-snapshot/src/peep_engine.c: 760 in _asm_peep_11() ________________________________________________________________________________________________________ *** CID 1455693: (NEGATIVE_RETURNS) /home/covbuilder/pike/Pike-v8.1-snapshot/src/peep_engine.c: 772 in _asm_peep_11() 766 break; 767 768 case F_VOLATILE_RETURN: 769 /* ASSIGN_LOCAL VOLATILE_RETURN 770 [!(Pike_compiler->compiler_frame->variable[$1a].flags & 771 LOCAL_VAR_USED_IN_SCOPE)]: VOLATILE_RETURN */ >>> CID 1455693: (NEGATIVE_RETURNS) >>> Using variable "argument(1)" as an index to array "Pike_compiler->compiler_frame->variable". 772 if(!(Pike_compiler->compiler_frame->variable[argument(1)].flags & 773 LOCAL_VAR_USED_IN_SCOPE)) 774 { 775 do_optimization(2, 1, 1, F_VOLATILE_RETURN, 0); 776 return 1; 777 } /home/covbuilder/pike/Pike-v8.1-snapshot/src/peep_engine.c: 760 in _asm_peep_11() 754 break; 755 756 case F_RETURN: 757 /* ASSIGN_LOCAL RETURN 758 [!(Pike_compiler->compiler_frame->variable[$1a].flags & 759 LOCAL_VAR_USED_IN_SCOPE)]: RETURN */ >>> CID 1455693: (NEGATIVE_RETURNS) >>> Using variable "argument(1)" as an index to array "Pike_compiler->compiler_frame->variable". 760 if(!(Pike_compiler->compiler_frame->variable[argument(1)].flags & 761 LOCAL_VAR_USED_IN_SCOPE)) 762 { 763 do_optimization(2, 1, 1, F_RETURN, 0); 764 return 1; 765 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 27 Aug '19

27 Aug '19

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1452817: Resource leaks (RESOURCE_LEAK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/docode.c: 3128 in do_code_block() ________________________________________________________________________________________________________ *** CID 1452817: Resource leaks (RESOURCE_LEAK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/docode.c: 3128 in do_code_block() 3122 DO_CODE_BLOCK(n); 3123 } 3124 entry_point = assemble(1); 3125 3126 current_stack_depth = save_stack_depth; 3127 label_no = save_label_no; >>> CID 1452817: Resource leaks (RESOURCE_LEAK) >>> Variable "generator_jumptable" going out of scope leaks the storage it points to. 3128 return entry_point; 3129 } 3130 3131 /* Used by eval_low() to build code for constant expressions. */ 3132 INT32 docode(node *n) 3133 { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 30 Jul '19

30 Jul '19

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 3 new defect(s) introduced to Pike-master found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1452124: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/b_source_normal_file.c: 96 in source_normal_file_make() ________________________________________________________________________________________________________ *** CID 1452124: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/b_source_normal_file.c: 96 in source_normal_file_make() 90 pop_stack(); 91 92 if (fd_fstat(fd, &st) < 0 || !S_ISREG(st.st_mode)) 93 return 0; 94 95 if (start) >>> CID 1452124: Error handling issues (CHECKED_RETURN) >>> Calling "lseek(fd, (off_t)start, 1)" without checking return value. This library function may fail and return an error code. 96 fd_lseek(fd, (off_t)start, SEEK_CUR); 97 98 if (!(res = calloc(1, sizeof(struct fd_source)))) 99 return 0; 100 101 res->fd = fd; ** CID 1452123: (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/e_source_block_pikestream.c: 79 in get_data() /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/c_source_stream.c: 118 in get_data() /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/d_source_pikestream.c: 99 in get_data() ________________________________________________________________________________________________________ *** CID 1452123: (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/e_source_block_pikestream.c: 79 in get_data() 73 } 74 if (s->len >= 0) { 75 s->len -= res.len; 76 if(!s->len) 77 s->s.eof = 1; 78 } >>> CID 1452123: (UNINIT) >>> Using uninitialized value "res". Field "res.data" is uninitialized. 79 return res; 80 } 81 82 static void free_source( struct source *src ) 83 { 84 struct pf_source *s = (struct pf_source *)src; /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/c_source_stream.c: 118 in get_data() 112 * source_stream_make) 113 */ 114 res.len = -2; 115 setup_callbacks(src); 116 } 117 >>> CID 1452123: (UNINIT) >>> Using uninitialized value "res". Field "res.data" is uninitialized. 118 return res; 119 } 120 121 static void 122 set_callback(struct source *src, void (*cb)( void *a ), struct object *a) { 123 struct fd_source *s = (struct fd_source *)src; /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/d_source_pikestream.c: 99 in get_data() 93 * out of the range of data to send as specified by the arguments to 94 * source_stream_make) 95 */ 96 res.len = -2; 97 setup_callbacks(src); 98 } >>> CID 1452123: (UNINIT) >>> Using uninitialized value "res". Field "res.data" is uninitialized. 99 return res; 100 } 101 102 static void f_got_data( INT32 args ) 103 { 104 struct pf_source *s = (struct pf_source*)Pike_fp->current_object->storage; ** CID 1452122: Parse warnings (PW.PARAM_SET_BUT_NOT_USED) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/c_source_stream.c: 93 in () ________________________________________________________________________________________________________ *** CID 1452122: Parse warnings (PW.PARAM_SET_BUT_NOT_USED) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/c_source_stream.c: 93 in () 87 88 static void setup_callbacks( struct source *src ) { 89 struct fd_source *s = (struct fd_source *)src; 90 set_read_callback( s->fd, (void*)read_callback, s ); 91 } 92 >>> CID 1452122: Parse warnings (PW.PARAM_SET_BUT_NOT_USED) >>> parameter "len" was set but never used 93 static struct data get_data(struct source *src, off_t len) 94 { 95 struct fd_source *s = (struct fd_source *)src; 96 struct data res; 97 98 reload: ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 17 Nov '18

17 Nov '18

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1441424: Control flow issues (UNEXPECTED_CONTROL_FLOW) /home/covbuilder/pike/Pike-v8.1-snapshot/src/program.c: 5187 in lower_inherit() ________________________________________________________________________________________________________ *** CID 1441424: Control flow issues (UNEXPECTED_CONTROL_FLOW) /home/covbuilder/pike/Pike-v8.1-snapshot/src/program.c: 5187 in lower_inherit() 5181 5182 /* Restore annotations (if any) to and from the inherited program. */ 5183 do { 5184 struct inherit *src_inh = p->inherits; 5185 struct inherit *dst_inh = 5186 Pike_compiler->new_program->inherits + inherit_offset; >>> CID 1441424: Control flow issues (UNEXPECTED_CONTROL_FLOW) >>> A continue statement within a do-while loop only continues execution of the loop body if the loop continuation condition is still true. Since the condition will never be true in a "do ... while (false);" loop the continue statement has the same effect as a break statement. Did you intend execution to continue at the top of the loop? 5187 if (!src_inh->annotations) continue; 5188 5189 dst_inh->annotations = copy_array(src_inh->annotations); 5190 } while(0); 5191 5192 if (Pike_compiler->compiler_pass == COMPILER_PASS_EXTRA) { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 09 Aug '18

09 Aug '18

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 4 new defect(s) introduced to Pike-master found with Coverity Scan. 8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1438385: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/cpp.cmod: 230 in f_define_cq__backtick_28_29() ________________________________________________________________________________________________________ *** CID 1438385: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/cpp.cmod: 230 in f_define_cq__backtick_28_29() 224 init_string_builder(&s, 0); 225 if(d->magic) 226 { 227 struct pike_string *a = NULL; 228 229 if (d->args > 0) { >>> CID 1438385: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "arguments". 230 a = ITEM(arguments)[0].u.string; 231 } 232 d->magic(context_obj, d, a, &s); 233 234 /* NB: The variable 'a' does not holdany refs. */ 235 ** CID 1438384: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1438384: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/cpp.cmod: 302 in f_define_cq__backtick_28_29() 296 /* NB: Evaluate the argument before insertion. */ 297 int save_flags = d->flags; 298 d->flags |= CPP_MACRO_IN_USE; 299 300 ref_push_string(str); 301 push_int(flags & ~(CPP_EXPECT_ENDIF | CPP_EXPECT_ELSE)); >>> CID 1438384: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "context_obj" to "safe_apply", which dereferences it. 302 safe_apply(context_obj, "cpp", 2); 303 string_builder_shared_strcat(&s, Pike_sp[-1].u.string); 304 pop_stack(); 305 306 d->flags = save_flags; 307 ** CID 1438383: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 362 in _pixel_apply_matrix() ________________________________________________________________________________________________________ *** CID 1438383: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 362 in _pixel_apply_matrix() 356 sumb += (int)matrix[i+j*width].b; 357 } 358 if (sumr) res.r=testrange(default_rgb.r+r/(sumr*div)); 359 else res.r=testrange(r*qdiv+default_rgb.r); 360 if (sumg) res.g=testrange(default_rgb.g+g/(sumg*div)); 361 else res.g=testrange(g*qdiv+default_rgb.g); >>> CID 1438383: Incorrect expression (COPY_PASTE_ERROR) >>> "g" in "default_rgb.g" looks like a copy-paste error. 362 if (sumb) res.b=testrange(default_rgb.g+b/(sumb*div)); 363 else res.b=testrange(b*qdiv+default_rgb.b); 364 #ifdef MATRIX_DEBUG 365 fprintf(stderr,"->%d,%d,%d\n",res.r,res.g,res.b); 366 #endif 367 return res; ** CID 1438382: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/search.c: 481 in _pixel_apply_max() ________________________________________________________________________________________________________ *** CID 1438382: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/search.c: 481 in _pixel_apply_max() 475 res.r = (COLORTYPE)testrange(r * qdiv + default_rgb.r); 476 if (sumg) 477 res.g = (COLORTYPE)testrange(default_rgb.g + g/(sumg * div)); 478 else 479 res.g = (COLORTYPE)testrange(g * qdiv + default_rgb.g); 480 if (sumb) >>> CID 1438382: Incorrect expression (COPY_PASTE_ERROR) >>> "g" in "default_rgb.g" looks like a copy-paste error. 481 res.b = (COLORTYPE)testrange(default_rgb.g + b/(sumb * div)); 482 else 483 res.b = (COLORTYPE)testrange(b * qdiv + default_rgb.b); 484 #ifdef MATRIX_DEBUG 485 fprintf(stderr,"->%d,%d,%d\n",res.r,res.g,res.b); 486 #endif ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0