Pike-automation

pike-automation@lists.lysator.liu.se

55 discussions

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 17 Nov '18

17 Nov '18

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1441424: Control flow issues (UNEXPECTED_CONTROL_FLOW) /home/covbuilder/pike/Pike-v8.1-snapshot/src/program.c: 5187 in lower_inherit() ________________________________________________________________________________________________________ *** CID 1441424: Control flow issues (UNEXPECTED_CONTROL_FLOW) /home/covbuilder/pike/Pike-v8.1-snapshot/src/program.c: 5187 in lower_inherit() 5181 5182 /* Restore annotations (if any) to and from the inherited program. */ 5183 do { 5184 struct inherit *src_inh = p->inherits; 5185 struct inherit *dst_inh = 5186 Pike_compiler->new_program->inherits + inherit_offset; >>> CID 1441424: Control flow issues (UNEXPECTED_CONTROL_FLOW) >>> A continue statement within a do-while loop only continues execution of the loop body if the loop continuation condition is still true. Since the condition will never be true in a "do ... while (false);" loop the continue statement has the same effect as a break statement. Did you intend execution to continue at the top of the loop? 5187 if (!src_inh->annotations) continue; 5188 5189 dst_inh->annotations = copy_array(src_inh->annotations); 5190 } while(0); 5191 5192 if (Pike_compiler->compiler_pass == COMPILER_PASS_EXTRA) { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 09 Aug '18

09 Aug '18

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 4 new defect(s) introduced to Pike-master found with Coverity Scan. 8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1438385: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/cpp.cmod: 230 in f_define_cq__backtick_28_29() ________________________________________________________________________________________________________ *** CID 1438385: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/cpp.cmod: 230 in f_define_cq__backtick_28_29() 224 init_string_builder(&s, 0); 225 if(d->magic) 226 { 227 struct pike_string *a = NULL; 228 229 if (d->args > 0) { >>> CID 1438385: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "arguments". 230 a = ITEM(arguments)[0].u.string; 231 } 232 d->magic(context_obj, d, a, &s); 233 234 /* NB: The variable 'a' does not holdany refs. */ 235 ** CID 1438384: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1438384: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/cpp.cmod: 302 in f_define_cq__backtick_28_29() 296 /* NB: Evaluate the argument before insertion. */ 297 int save_flags = d->flags; 298 d->flags |= CPP_MACRO_IN_USE; 299 300 ref_push_string(str); 301 push_int(flags & ~(CPP_EXPECT_ENDIF | CPP_EXPECT_ELSE)); >>> CID 1438384: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "context_obj" to "safe_apply", which dereferences it. 302 safe_apply(context_obj, "cpp", 2); 303 string_builder_shared_strcat(&s, Pike_sp[-1].u.string); 304 pop_stack(); 305 306 d->flags = save_flags; 307 ** CID 1438383: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 362 in _pixel_apply_matrix() ________________________________________________________________________________________________________ *** CID 1438383: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 362 in _pixel_apply_matrix() 356 sumb += (int)matrix[i+j*width].b; 357 } 358 if (sumr) res.r=testrange(default_rgb.r+r/(sumr*div)); 359 else res.r=testrange(r*qdiv+default_rgb.r); 360 if (sumg) res.g=testrange(default_rgb.g+g/(sumg*div)); 361 else res.g=testrange(g*qdiv+default_rgb.g); >>> CID 1438383: Incorrect expression (COPY_PASTE_ERROR) >>> "g" in "default_rgb.g" looks like a copy-paste error. 362 if (sumb) res.b=testrange(default_rgb.g+b/(sumb*div)); 363 else res.b=testrange(b*qdiv+default_rgb.b); 364 #ifdef MATRIX_DEBUG 365 fprintf(stderr,"->%d,%d,%d\n",res.r,res.g,res.b); 366 #endif 367 return res; ** CID 1438382: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/search.c: 481 in _pixel_apply_max() ________________________________________________________________________________________________________ *** CID 1438382: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/search.c: 481 in _pixel_apply_max() 475 res.r = (COLORTYPE)testrange(r * qdiv + default_rgb.r); 476 if (sumg) 477 res.g = (COLORTYPE)testrange(default_rgb.g + g/(sumg * div)); 478 else 479 res.g = (COLORTYPE)testrange(g * qdiv + default_rgb.g); 480 if (sumb) >>> CID 1438382: Incorrect expression (COPY_PASTE_ERROR) >>> "g" in "default_rgb.g" looks like a copy-paste error. 481 res.b = (COLORTYPE)testrange(default_rgb.g + b/(sumb * div)); 482 else 483 res.b = (COLORTYPE)testrange(b * qdiv + default_rgb.b); 484 #ifdef MATRIX_DEBUG 485 fprintf(stderr,"->%d,%d,%d\n",res.r,res.g,res.b); 486 #endif ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 27 Dec '17

27 Dec '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 2 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1426990: Uninitialized variables (MISSING_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/GL/GLSL.cmod: 812 in init_pike_GLSL() ________________________________________________________________________________________________________ *** CID 1426990: Uninitialized variables (MISSING_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/GL/GLSL.cmod: 812 in init_pike_GLSL() 806 init_pike_GLSL(void) 807 { 808 INIT; 809 #ifndef HAVE_GLSL 810 HIDE_MODULE(); 811 #endif /* HAVE_GLSL */ >>> CID 1426990: Uninitialized variables (MISSING_RETURN) >>> Arriving at the end of a function without returning a value. 812 } 813 814 exit_pike_GLSL(void) 815 { 816 EXIT; ** CID 1426989: Uninitialized variables (MISSING_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/GL/GLSL.cmod: 817 in exit_pike_GLSL() ________________________________________________________________________________________________________ *** CID 1426989: Uninitialized variables (MISSING_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/GL/GLSL.cmod: 817 in exit_pike_GLSL() 811 #endif /* HAVE_GLSL */ 812 } 813 814 exit_pike_GLSL(void) 815 { 816 EXIT; >>> CID 1426989: Uninitialized variables (MISSING_RETURN) >>> Arriving at the end of a function without returning a value. ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 25 Dec '17

25 Dec '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1426948: Uninitialized variables (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 593 in f_TM_create_3() ________________________________________________________________________________________________________ *** CID 1426948: Uninitialized variables (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 593 in f_TM_create_3() 587 PIKEFUN void create( int year, int(0..11) mon, int(1..31) mday, 588 int(0..24) hour, int(0..59) min, int(0..59) sec, 589 string|void timezone ) 590 { 591 struct tm *t = &THIS->t; 592 int use_utc; >>> CID 1426948: Uninitialized variables (UNINIT) >>> Using uninitialized value "use_utc". 593 t->tm_isdst = use_utc ? 0 : -1; 594 t->tm_year = year - 1900; 595 t->tm_mon = mon; 596 t->tm_mday = mday; 597 t->tm_hour = hour; 598 t->tm_min = min; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 26 Nov '17

26 Nov '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1423308: Control flow issues (DEADCODE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/las.c: 1632 in resolv_type() ________________________________________________________________________________________________________ *** CID 1423308: Control flow issues (DEADCODE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/las.c: 1632 in resolv_type() 1626 } 1627 } 1628 1629 switch(TYPEOF(Pike_sp[-1])) { 1630 case T_FUNCTION: 1631 if((p = program_from_function(Pike_sp-1))) { >>> CID 1423308: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "0" inside this statement: "debug_push_object_type(0, (...". 1632 push_object_type(0, p?(p->id):0); 1633 break; 1634 } else { 1635 /* Attempt to get the return type for the function. */ 1636 struct pike_type *a, *b; 1637 a = get_type_of_svalue(Pike_sp-1); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 08 Oct '17

08 Oct '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1419034: Uninitialized variables (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/code/amd64.c: 2809 in ins_f_byte() ________________________________________________________________________________________________________ *** CID 1419034: Uninitialized variables (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/code/amd64.c: 2809 in ins_f_byte() 2803 #endif /* MACHINE_CODE_STACK_FRAMES */ 2804 } 2805 2806 amd64_call_c_opcode(addr,flags); 2807 2808 if (instrs[b].flags & I_RETURN) { >>> CID 1419034: Uninitialized variables (UNINIT) >>> Declaring variable "label_C" without initializer. 2809 LABELS(); 2810 2811 if ((b + F_OFFSET) == F_RETURN_IF_TRUE) { 2812 /* Kludge. We must check if the ret addr is 2813 * PC + JUMP_EPILOGUE_SIZE. */ 2814 mov_rip_imm_reg(JUMP_EPILOGUE_SIZE, P_REG_RCX); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 07 Oct '17

07 Oct '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 3 new defect(s) introduced to Pike-master found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1418981: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/multiset.c: 2876 in multiset_equal_p() ________________________________________________________________________________________________________ *** CID 1418981: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/multiset.c: 2876 in multiset_equal_p() 2870 if (p->pointer_a == (void *) a && p->pointer_b == (void *) b) 2871 return 1; 2872 2873 add_ref (rd.a_msd); 2874 add_ref (rd.b_msd); 2875 SET_ONERROR (uwp, free_recovery_data, &rd); >>> CID 1418981: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "rd.a_msd->root". 2876 a_node = low_multiset_first (rd.a_msd); 2877 b_node = low_multiset_first (rd.b_msd); 2878 res = 1; 2879 2880 #define WITH_NODES_BLOCK(TYPE, IND) \ 2881 do { \ ** CID 742549: (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/stralloc.c: 2038 in string_replace() /home/covbuilder/pike/Pike-v8.1-snapshot/src/stralloc.c: 2056 in string_replace() ________________________________________________________________________________________________________ *** CID 742549: (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/stralloc.c: 2038 in string_replace() 2032 { 2033 case 0: f=(replace_searchfunc)mojt.vtab->func0; break; 2034 case 1: f=(replace_searchfunc)mojt.vtab->func1; break; 2035 case 2: f=(replace_searchfunc)mojt.vtab->func2; break; 2036 } 2037 >>> CID 742549: (FORWARD_NULL) >>> Dereferencing null pointer "f". 2038 while((s = f(mojt.data, s, (end-s)>>str->size_shift))) 2039 { 2040 delimeters++; 2041 s+=del->len << str->size_shift; 2042 } 2043 /home/covbuilder/pike/Pike-v8.1-snapshot/src/stralloc.c: 2056 in string_replace() 2050 2051 ret=begin_wide_shared_string(str->len + (to->len-del->len)*delimeters, shift); 2052 } 2053 s=str->str; 2054 r=MKPCHARP_STR(ret); 2055 >>> CID 742549: (FORWARD_NULL) >>> Dereferencing null pointer "f". 2056 while((tmp = f(mojt.data, s, (end-s)>>str->size_shift))) 2057 { 2058 #ifdef PIKE_DEBUG 2059 if(tmp + (del->len << str->size_shift) > end) 2060 Pike_fatal("SearchMojt found a match beyond end of string!!!\n"); 2061 #endif ** CID 742518: (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 3859 in f_single_string_replace_cq__backtick_28_29() /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 3877 in f_single_string_replace_cq__backtick_28_29() ________________________________________________________________________________________________________ *** CID 742518: (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 3859 in f_single_string_replace_cq__backtick_28_29() 3853 ret = begin_wide_shared_string(str->len, shift); 3854 } else { 3855 INT32 delimiters = 0; 3856 3857 s = str->str; 3858 >>> CID 742518: (FORWARD_NULL) >>> Dereferencing null pointer "f". 3859 while((s = f(mojt_data, s, (end-s)>>str->size_shift))) 3860 { 3861 delimiters++; 3862 s += del->len << str->size_shift; 3863 } 3864 /home/covbuilder/pike/Pike-v8.1-snapshot/src/builtin.cmod: 3877 in f_single_string_replace_cq__backtick_28_29() 3871 (to->len-del->len)*delimiters, shift); 3872 } 3873 3874 s = str->str; 3875 r = MKPCHARP_STR(ret); 3876 >>> CID 742518: (FORWARD_NULL) >>> Dereferencing null pointer "f". 3877 while((tmp = f(mojt_data, s, (end-s)>>str->size_shift))) 3878 { 3879 #ifdef PIKE_DEBUG 3880 if(tmp + (del->len << str->size_shift) > end) 3881 Pike_fatal("SearchMojt found a match beyond end of string!\n"); 3882 #endif ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-stable
by scan-admin＠coverity.com 08 Jul '17

08 Jul '17

Hi, Please find the latest report on new defect(s) introduced to Pike-stable found with Coverity Scan. 1 new defect(s) introduced to Pike-stable found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1414703: Memory - corruptions (ARRAY_VS_SINGLETON) /home/covbuilder/pike/Pike-v8.0-snapshot/src/post_modules/SQLite/sqlite.cmod: 135 in bind_arguments() ________________________________________________________________________________________________________ *** CID 1414703: Memory - corruptions (ARRAY_VS_SINGLETON) /home/covbuilder/pike/Pike-v8.0-snapshot/src/post_modules/SQLite/sqlite.cmod: 135 in bind_arguments() 129 130 case T_MULTISET: 131 if(multiset_sizeof(k->val.u.multiset) == 1) { 132 struct pike_string *s; 133 { 134 struct svalue tmp; >>> CID 1414703: Memory - corruptions (ARRAY_VS_SINGLETON) >>> Using "&k->val.u.multiset->msd->nodes->i" as an array. This might corrupt or misinterpret adjacent memory locations. 135 if (TYPEOF(*use_multiset_index (k->val.u.multiset, 136 multiset_first (k->val.u.multiset), 137 tmp)) == T_STRING) 138 s = tmp.u.string; 139 else 140 s = NULL; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 07 Jul '17

07 Jul '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1414685: Memory - illegal accesses (NEGATIVE_RETURNS) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/SQLite/sqlite.cmod: 131 in bind_arguments() ________________________________________________________________________________________________________ *** CID 1414685: Memory - illegal accesses (NEGATIVE_RETURNS) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/SQLite/sqlite.cmod: 131 in bind_arguments() 125 break; 126 case T_MULTISET: 127 if(multiset_sizeof(k->val.u.multiset) == 1) { 128 struct pike_string *s; 129 { 130 struct svalue tmp; >>> CID 1414685: Memory - illegal accesses (NEGATIVE_RETURNS) >>> Using variable "multiset_first(k->val.u.multiset)" as an index to array "k->val.u.multiset->msd->nodes". 131 if (TYPEOF(*use_multiset_index (k->val.u.multiset, 132 multiset_first (k->val.u.multiset), 133 tmp)) == T_STRING) 134 s = tmp.u.string; 135 else 136 s = NULL; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-stable
by scan-admin＠coverity.com 14 Mar '17

14 Mar '17

Hi, Please find the latest report on new defect(s) introduced to Pike-stable found with Coverity Scan. 7 new defect(s) introduced to Pike-stable found with Coverity Scan. 13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 7 of 7 defect(s) ** CID 1402583: Control flow issues (DEADCODE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/operators.c: 841 in o_cast() ________________________________________________________________________________________________________ *** CID 1402583: Control flow issues (DEADCODE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/operators.c: 841 in o_cast() 835 #ifdef PIKE_DEBUG 836 struct svalue *save_sp=sp+1; 837 #endif 838 839 ptrdiff_t nodepos; 840 if (multiset_indval (tmp)) >>> CID 1402583: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "Pike_error("FIXME: Casting ...". 841 Pike_error ("FIXME: Casting not implemented for multisets with values.\n"); 842 push_multiset (m = allocate_multiset (multiset_sizeof (tmp), 843 multiset_get_flags (tmp), 844 multiset_get_cmp_less (tmp))); 845 846 SET_CYCLIC_RET(m); ** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 744 in i_img_bmp__decode() /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 757 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 744 in i_img_bmp__decode() 738 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 739 push_int(2); 740 push_object(o=clone_object(image_colortable_program,2)); 741 nct=get_storage(o,image_colortable_program); 742 743 s+=(4<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (4 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 744 len-=(4<<bpp); 745 } 746 else 747 { 748 if ((3<<bpp)>len) 749 Pike_error("Image.BMP.decode: unexpected EOF in palette\n"); /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 757 in i_img_bmp__decode() 751 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 752 push_int(1); 753 push_object(o=clone_object(image_colortable_program,2)); 754 nct=get_storage(o,image_colortable_program); 755 756 s+=(3<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (3 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 757 len-=(3<<bpp); 758 } 759 760 n++; 761 } 762 ** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 743 in i_img_bmp__decode() /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 756 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 743 in i_img_bmp__decode() 737 738 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 739 push_int(2); 740 push_object(o=clone_object(image_colortable_program,2)); 741 nct=get_storage(o,image_colortable_program); 742 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (4 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 743 s+=(4<<bpp); 744 len-=(4<<bpp); 745 } 746 else 747 { 748 if ((3<<bpp)>len) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/encodings/bmp.c: 756 in i_img_bmp__decode() 750 751 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 752 push_int(1); 753 push_object(o=clone_object(image_colortable_program,2)); 754 nct=get_storage(o,image_colortable_program); 755 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (3 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 756 s+=(3<<bpp); 757 len-=(3<<bpp); 758 } 759 760 n++; 761 } ** CID 1400857: (UNINIT) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 4113 in image_apply_curve() /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 4193 in image_apply_curve() ________________________________________________________________________________________________________ *** CID 1400857: (UNINIT) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 4113 in image_apply_curve() 4107 pop_n_elems( args ); 4108 image_apply_curve_3( curve ); 4109 return; 4110 } 4111 case 2: 4112 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4113 unsigned char curve[256]; 4114 int chan = 0, co = 0; 4115 struct object *o; 4116 4117 if( TYPEOF(sp[-args]) != T_STRING ) 4118 SIMPLE_BAD_ARG_ERROR("apply_curve", 1, "string"); /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Image/image.c: 4193 in image_apply_curve() 4187 pop_stack(); 4188 } 4189 return; 4190 } 4191 case 1: 4192 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4193 unsigned char curve[256]; 4194 if( TYPEOF(sp[-args]) != T_ARRAY || 4195 sp[-args].u.array->size != 256 ) 4196 bad_arg_error("apply_curve", 4197 sp-args, args, 0, "", sp-args, 4198 "Bad arguments to apply_curve.\n" ); ** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Gz/zlibmod.c: 966 in low_zlibmod_unpack() ________________________________________________________________________________________________________ *** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Gz/zlibmod.c: 966 in low_zlibmod_unpack() 960 else 961 Pike_error("Failed to initialize Gz.uncompress (%d).\n", ret); 962 } 963 964 mt_init(&z.lock); 965 ret = do_inflate(buf, &z, Z_SYNC_FLUSH); >>> CID 1400856: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 966 mt_destroy(&z.lock); 967 inflateEnd( &z.gz ); 968 969 if(ret==Z_OK) 970 Pike_error("Compressed data is truncated.\n"); 971 if(ret!=Z_STREAM_END) ** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Gz/zlibmod.c: 448 in low_zlibmod_pack() ________________________________________________________________________________________________________ *** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.0-snapshot/src/modules/Gz/zlibmod.c: 448 in low_zlibmod_pack() 442 443 mt_init(&z.lock); 444 445 ret = do_deflate(buf, &z, Z_FINISH); 446 447 deflateEnd(&z.gz); >>> CID 1400855: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 448 mt_destroy(&z.lock); 449 450 if(ret != Z_STREAM_END) 451 Pike_error("Error while deflating data (%d).\n",ret); 452 } 453 ** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/Pike-v8.0-snapshot/src/array.c: 95 in real_allocate_array() ________________________________________________________________________________________________________ *** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/Pike-v8.0-snapshot/src/array.c: 95 in real_allocate_array() 89 /* Limits size to (1<<29)-4 */ 90 if( (size_t)(size+extra_space-1) > 91 (LONG_MAX-sizeof(struct array))/sizeof(struct svalue) ) 92 Pike_error("Too large array (size %ld exceeds %ld).\n", 93 (long)(size+extra_space-1), 94 (long)((LONG_MAX-sizeof(struct array))/sizeof(struct svalue)) ); >>> CID 1400854: Insecure data handling (INTEGER_OVERFLOW) >>> Overflowed or truncated value (or a value computed from an overflowed or truncated value) "64UL + (size + extra_space - 1L) * 16UL" used as critical argument to function. 95 v=malloc(sizeof(struct array)+ 96 (size+extra_space-1)*sizeof(struct svalue)); 97 if(!v) 98 Pike_error(msg_out_of_mem_2, sizeof(struct array)+ 99 (size+extra_space-1)*sizeof(struct svalue)); 100 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

Pike-automation