Pike-automation November 2016

pike-automation@lists.lysator.liu.se

1 participants
2 discussions

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 05 Nov '16

05 Nov '16

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 2 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1376003: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 2359 in gc_mark_object_as_referenced() ________________________________________________________________________________________________________ *** CID 1376003: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 2359 in gc_mark_object_as_referenced() 2353 struct svalue *s; 2354 s=(struct svalue *)(pike_frame->current_storage + id->func.offset); 2355 dmalloc_touch_svalue(s); 2356 if ((TYPEOF(*s) != T_OBJECT && TYPEOF(*s) != T_FUNCTION) || 2357 s->u.object != o || !(id_flags & IDENTIFIER_NO_THIS_REF)) { 2358 if (id_flags & IDENTIFIER_WEAK) { >>> CID 1376003: Error handling issues (CHECKED_RETURN) >>> Calling "gc_mark_weak_svalues" without checking return value (as is done elsewhere 5 out of 6 times). 2359 gc_mark_weak_svalues(s, 1); 2360 } else { 2361 gc_mark_svalues(s, 1); 2362 } 2363 } 2364 }else{ ** CID 1376002: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 2435 in real_gc_cycle_check_object() ________________________________________________________________________________________________________ *** CID 1376002: Error handling issues (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 2435 in real_gc_cycle_check_object() 2429 struct svalue *s; 2430 s=(struct svalue *)(pike_frame->current_storage + id->func.offset); 2431 dmalloc_touch_svalue(s); 2432 if ((TYPEOF(*s) != T_OBJECT && TYPEOF(*s) != T_FUNCTION) || 2433 s->u.object != o || !(id_flags & IDENTIFIER_NO_THIS_REF)) { 2434 if (id_flags & IDENTIFIER_WEAK) { >>> CID 1376002: Error handling issues (CHECKED_RETURN) >>> Calling "gc_cycle_check_weak_svalues" without checking return value (as is done elsewhere 5 out of 6 times). 2435 gc_cycle_check_weak_svalues(s, 1); 2436 } else { 2437 gc_cycle_check_svalues(s, 1); 2438 } 2439 } 2440 }else{ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 04 Nov '16

04 Nov '16

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1375989: (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 3872 in low_pike_types_le() /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 3895 in low_pike_types_le() /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 4090 in low_pike_types_le() ________________________________________________________________________________________________________ *** CID 1375989: (CHECKED_RETURN) /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 3872 in low_pike_types_le() 3866 goto recurse; 3867 } 3868 if ((a->flags | b->flags) & PT_FLAG_ASSIGN) { 3869 /* Note that we need to recurse, since there are T_ASSIGN nodes 3870 * in the cdr that need to be executed. 3871 */ >>> CID 1375989: (CHECKED_RETURN) >>> Calling "low_pike_types_le" without checking return value (as is done elsewhere 28 out of 35 times). 3872 low_pike_types_le(a->cdr, b, array_cnt, flags); 3873 } 3874 return 1; 3875 3876 case T_OR: 3877 /* OK, if both of the parts are a subset, /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 3895 in low_pike_types_le() 3889 } else { 3890 ret = low_pike_types_le(a->car, b, array_cnt, flags); 3891 #ifdef TYPE_GROUPING 3892 if (!ret == !(flags & LE_A_GROUPED)) { 3893 if ((a->flags | b->flags) & PT_FLAG_ASSIGN) { 3894 /* Note: Needed for side effects... */ >>> CID 1375989: (CHECKED_RETURN) >>> Calling "low_pike_types_le" without checking return value (as is done elsewhere 28 out of 35 times). 3895 low_pike_types_le(a->cdr, b, array_cnt, flags); 3896 } 3897 return ret; 3898 } 3899 #else 3900 if (!ret) return 0; /home/covscan/pike/Pike-v8.1-snapshot/src/pike_types.c: 4090 in low_pike_types_le() 4084 */ 4085 ret = low_pike_types_le(a, b->car, array_cnt, flags); 4086 #ifdef TYPE_GROUPING 4087 if (!ret != !(flags & LE_B_GROUPED)) { 4088 if ((a->flags | b->flags) & PT_FLAG_ASSIGN) { 4089 /* Note: Needed for side effects... */ >>> CID 1375989: (CHECKED_RETURN) >>> Calling "low_pike_types_le" without checking return value (as is done elsewhere 28 out of 35 times). 4090 low_pike_types_le(a, b->cdr, array_cnt, flags); 4091 } 4092 return ret; 4093 } 4094 #else 4095 if (ret) return ret; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

Pike-automation November 2016