Pike-automation August 2018

pike-automation@lists.lysator.liu.se

1 participants
1 discussions

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 09 Aug '18

09 Aug '18

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 4 new defect(s) introduced to Pike-master found with Coverity Scan. 8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1438385: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/cpp.cmod: 230 in f_define_cq__backtick_28_29() ________________________________________________________________________________________________________ *** CID 1438385: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/cpp.cmod: 230 in f_define_cq__backtick_28_29() 224 init_string_builder(&s, 0); 225 if(d->magic) 226 { 227 struct pike_string *a = NULL; 228 229 if (d->args > 0) { >>> CID 1438385: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "arguments". 230 a = ITEM(arguments)[0].u.string; 231 } 232 d->magic(context_obj, d, a, &s); 233 234 /* NB: The variable 'a' does not holdany refs. */ 235 ** CID 1438384: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1438384: Null pointer dereferences (FORWARD_NULL) /home/covbuilder/pike/Pike-v8.1-snapshot/src/cpp.cmod: 302 in f_define_cq__backtick_28_29() 296 /* NB: Evaluate the argument before insertion. */ 297 int save_flags = d->flags; 298 d->flags |= CPP_MACRO_IN_USE; 299 300 ref_push_string(str); 301 push_int(flags & ~(CPP_EXPECT_ENDIF | CPP_EXPECT_ELSE)); >>> CID 1438384: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "context_obj" to "safe_apply", which dereferences it. 302 safe_apply(context_obj, "cpp", 2); 303 string_builder_shared_strcat(&s, Pike_sp[-1].u.string); 304 pop_stack(); 305 306 d->flags = save_flags; 307 ** CID 1438383: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 362 in _pixel_apply_matrix() ________________________________________________________________________________________________________ *** CID 1438383: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 362 in _pixel_apply_matrix() 356 sumb += (int)matrix[i+j*width].b; 357 } 358 if (sumr) res.r=testrange(default_rgb.r+r/(sumr*div)); 359 else res.r=testrange(r*qdiv+default_rgb.r); 360 if (sumg) res.g=testrange(default_rgb.g+g/(sumg*div)); 361 else res.g=testrange(g*qdiv+default_rgb.g); >>> CID 1438383: Incorrect expression (COPY_PASTE_ERROR) >>> "g" in "default_rgb.g" looks like a copy-paste error. 362 if (sumb) res.b=testrange(default_rgb.g+b/(sumb*div)); 363 else res.b=testrange(b*qdiv+default_rgb.b); 364 #ifdef MATRIX_DEBUG 365 fprintf(stderr,"->%d,%d,%d\n",res.r,res.g,res.b); 366 #endif 367 return res; ** CID 1438382: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/search.c: 481 in _pixel_apply_max() ________________________________________________________________________________________________________ *** CID 1438382: Incorrect expression (COPY_PASTE_ERROR) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/search.c: 481 in _pixel_apply_max() 475 res.r = (COLORTYPE)testrange(r * qdiv + default_rgb.r); 476 if (sumg) 477 res.g = (COLORTYPE)testrange(default_rgb.g + g/(sumg * div)); 478 else 479 res.g = (COLORTYPE)testrange(g * qdiv + default_rgb.g); 480 if (sumb) >>> CID 1438382: Incorrect expression (COPY_PASTE_ERROR) >>> "g" in "default_rgb.g" looks like a copy-paste error. 481 res.b = (COLORTYPE)testrange(default_rgb.g + b/(sumb * div)); 482 else 483 res.b = (COLORTYPE)testrange(b * qdiv + default_rgb.b); 484 #ifdef MATRIX_DEBUG 485 fprintf(stderr,"->%d,%d,%d\n",res.r,res.g,res.b); 486 #endif ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

Pike-automation August 2018