Pike-automation February 2017

pike-automation@lists.lysator.liu.se

1 participants
6 discussions

New Defects reported by Coverity Scan for Pike-experiment
by scan-admin＠coverity.com 27 Feb '17

27 Feb '17

Hi, Please find the latest report on new defect(s) introduced to Pike-experiment found with Coverity Scan. 2 new defect(s) introduced to Pike-experiment found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1401352: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() ________________________________________________________________________________________________________ *** CID 1401352: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() 4456 callsite_set_args(&C, 0); 4457 callsite_resolve_svalue(&C, fun); 4458 callsite_prepare(&C); 4459 /* We need to do this manually, because 4460 * currently no arguments are on the stack, yet */ 4461 C.args = args; >>> CID 1401352: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 4462 if (C.frame) { 4463 C.frame->args = args; 4464 C.frame->flags |= PIKE_FRAME_NO_REUSE; 4465 } 4466 4467 for(x=0;x<size;x++) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() 4456 callsite_set_args(&C, 0); 4457 callsite_resolve_svalue(&C, fun); 4458 callsite_prepare(&C); 4459 /* We need to do this manually, because 4460 * currently no arguments are on the stack, yet */ 4461 C.args = args; >>> CID 1401352: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 4462 if (C.frame) { 4463 C.frame->args = args; 4464 C.frame->flags |= PIKE_FRAME_NO_REUSE; 4465 } 4466 4467 for(x=0;x<size;x++) ** CID 1400860: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() ________________________________________________________________________________________________________ *** CID 1400860: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() 8537 callsite_resolve_svalue(&C, mysp-2); 8538 callsite_prepare(&C); 8539 8540 /* We need to do this manually, because 8541 * currently no arguments are on the stack, yet */ 8542 C.args = 1+splice; >>> CID 1400860: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 8543 if (C.frame) { 8544 C.frame->args = 1+splice; 8545 C.frame->flags |= PIKE_FRAME_NO_REUSE; 8546 } 8547 8548 for (i=0; i<n; i++) /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() 8537 callsite_resolve_svalue(&C, mysp-2); 8538 callsite_prepare(&C); 8539 8540 /* We need to do this manually, because 8541 * currently no arguments are on the stack, yet */ 8542 C.args = 1+splice; >>> CID 1400860: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 8543 if (C.frame) { 8544 C.frame->args = 1+splice; 8545 C.frame->flags |= PIKE_FRAME_NO_REUSE; 8546 } 8547 8548 for (i=0; i<n; i++) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-experiment
by scan-admin＠coverity.com 21 Feb '17

21 Feb '17

Hi, Please find the latest report on new defect(s) introduced to Pike-experiment found with Coverity Scan. 1 new defect(s) introduced to Pike-experiment found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1401352: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() /home/covbuilder/pike/pike-git/src/builtin.cmod: 4484 in low_automap() ________________________________________________________________________________________________________ *** CID 1401352: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin.cmod: 4462 in low_automap() 4456 callsite_set_args(&C, 0); 4457 callsite_resolve_svalue(&C, fun); 4458 callsite_prepare(&C); 4459 /* We need to do this manually, because 4460 * currently no arguments are on the stack, yet */ 4461 C.args = args; >>> CID 1401352: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 4462 if (C.frame) C.frame->args = args; 4463 4464 for(x=0;x<size;x++) 4465 { 4466 for(e=0;e<args;e++) 4467 { /home/covbuilder/pike/pike-git/src/builtin.cmod: 4484 in low_automap() 4478 push_svalue(tmpargs+e); 4479 } 4480 } 4481 4482 if (x) callsite_reset(&C); 4483 callsite_execute(&C); >>> CID 1401352: (FORWARD_NULL) >>> Although "callsite_return" does overwrite "C.frame" on some paths, it also contains at least one feasible path which does not overwrite it. 4484 callsite_return(&C); 4485 stack_pop_to_no_free (ITEM(ret) + x); 4486 types |= 1 << TYPEOF(ITEM(ret)[x]); 4487 } 4488 callsite_free(&C); 4489 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 21 Feb '17

21 Feb '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 8 new defect(s) introduced to Pike-master found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 8 of 8 defect(s) ** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 748 in i_img_bmp__decode() /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 761 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 748 in i_img_bmp__decode() 742 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 743 push_int(2); 744 push_object(o=clone_object(image_colortable_program,2)); 745 nct=get_storage(o,image_colortable_program); 746 747 s+=(4<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (4 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 748 len-=(4<<bpp); 749 } 750 else 751 { 752 if ((3<<bpp)>len) 753 Pike_error("Image.BMP.decode: unexpected EOF in palette\n"); /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 761 in i_img_bmp__decode() 755 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 756 push_int(1); 757 push_object(o=clone_object(image_colortable_program,2)); 758 nct=get_storage(o,image_colortable_program); 759 760 s+=(3<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (3 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 761 len-=(3<<bpp); 762 } 763 764 n++; 765 } 766 ** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 747 in i_img_bmp__decode() /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 760 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 747 in i_img_bmp__decode() 741 742 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 743 push_int(2); 744 push_object(o=clone_object(image_colortable_program,2)); 745 nct=get_storage(o,image_colortable_program); 746 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (4 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 747 s+=(4<<bpp); 748 len-=(4<<bpp); 749 } 750 else 751 { 752 if ((3<<bpp)>len) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/encodings/bmp.c: 760 in i_img_bmp__decode() 754 755 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 756 push_int(1); 757 push_object(o=clone_object(image_colortable_program,2)); 758 nct=get_storage(o,image_colortable_program); 759 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (3 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 760 s+=(3<<bpp); 761 len-=(3<<bpp); 762 } 763 764 n++; 765 } ** CID 1400857: (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 4152 in image_apply_curve() /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 4232 in image_apply_curve() ________________________________________________________________________________________________________ *** CID 1400857: (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 4152 in image_apply_curve() 4146 pop_n_elems( args ); 4147 image_apply_curve_3( curve ); 4148 return; 4149 } 4150 case 2: 4151 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4152 unsigned char curve[256]; 4153 int chan = 0, co = 0; 4154 struct object *o; 4155 4156 if( TYPEOF(sp[-args]) != T_STRING ) 4157 SIMPLE_ARG_TYPE_ERROR("apply_curve", 1, "string"); /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Image/image.c: 4232 in image_apply_curve() 4226 pop_stack(); 4227 } 4228 return; 4229 } 4230 case 1: 4231 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4232 unsigned char curve[256]; 4233 if( TYPEOF(sp[-args]) != T_ARRAY || 4234 sp[-args].u.array->size != 256 ) 4235 bad_arg_error("apply_curve", 4236 sp-args, args, 0, "", sp-args, 4237 "Bad arguments to apply_curve.\n" ); ** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Gz/zlibmod.c: 948 in low_zlibmod_unpack() ________________________________________________________________________________________________________ *** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Gz/zlibmod.c: 948 in low_zlibmod_unpack() 942 else 943 Pike_error("Failed to initialize Gz.uncompress (%d).\n", ret); 944 } 945 946 mt_init(&z.lock); 947 ret = do_inflate(buf, &z, Z_SYNC_FLUSH); >>> CID 1400856: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 948 mt_destroy(&z.lock); 949 inflateEnd( &z.gz ); 950 951 if(ret==Z_OK) 952 Pike_error("Compressed data is truncated.\n"); 953 if(ret!=Z_STREAM_END) ** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Gz/zlibmod.c: 447 in low_zlibmod_pack() ________________________________________________________________________________________________________ *** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/Pike-v8.1-snapshot/src/modules/Gz/zlibmod.c: 447 in low_zlibmod_pack() 441 442 mt_init(&z.lock); 443 444 ret = do_deflate(buf, &z, Z_FINISH); 445 446 deflateEnd(&z.gz); >>> CID 1400855: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 447 mt_destroy(&z.lock); 448 449 if(ret != Z_STREAM_END) 450 Pike_error("Error while deflating data (%d).\n",ret); 451 } 452 ** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/Pike-v8.1-snapshot/src/array.c: 97 in real_allocate_array() ________________________________________________________________________________________________________ *** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/Pike-v8.1-snapshot/src/array.c: 97 in real_allocate_array() 91 /* Limits size to (1<<29)-4 */ 92 if( (size_t)(size+extra_space-1) > 93 (LONG_MAX-sizeof(struct array))/sizeof(struct svalue) ) 94 Pike_error("Too large array (size %ld exceeds %ld).\n", 95 (long)(size+extra_space-1), 96 (long)((LONG_MAX-sizeof(struct array))/sizeof(struct svalue)) ); >>> CID 1400854: Insecure data handling (INTEGER_OVERFLOW) >>> Overflowed or truncated value (or a value computed from an overflowed or truncated value) "56UL + (size + extra_space - 1L) * 16UL" used as critical argument to function. 97 v=malloc(sizeof(struct array)+ 98 (size+extra_space-1)*sizeof(struct svalue)); 99 if(!v) 100 Pike_error(msg_out_of_mem_2, sizeof(struct array)+ 101 (size+extra_space-1)*sizeof(struct svalue)); 102 ** CID 1400853: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 2255 in o_subtract() ________________________________________________________________________________________________________ *** CID 1400853: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/operators.c: 2255 in o_subtract() 2249 return; 2250 2251 case T_INT: 2252 if(INT_TYPE_SUB_OVERFLOW(sp[-2].u.integer, sp[-1].u.integer)) 2253 { 2254 convert_stack_top_to_bignum(); >>> CID 1400853: Error handling issues (CHECKED_RETURN) >>> Calling "call_lfun" without checking return value (as is done elsewhere 18 out of 22 times). 2255 call_lfun(LFUN_SUBTRACT, LFUN_RSUBTRACT); 2256 return; 2257 } 2258 sp--; 2259 SET_SVAL(sp[-1], PIKE_T_INT, NUMBER_NUMBER, integer, 2260 sp[-1].u.integer - sp[0].u.integer); ** CID 1400852: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Nettle/hogweed.cmod: 422 in f_Nettle_ECC_Curve_create() ________________________________________________________________________________________________________ *** CID 1400852: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Nettle/hogweed.cmod: 422 in f_Nettle_ECC_Curve_create() 416 Pike_error("Invalid curve\n"); 417 break; 418 } 419 420 ecc_scalar_init(&THIS->scalar_one, THIS->curve); 421 mpz_init_set_si(mpz_one, 1); >>> CID 1400852: Error handling issues (CHECKED_RETURN) >>> Calling "nettle_ecc_scalar_set" without checking return value (as is done elsewhere 4 out of 5 times). 422 ecc_scalar_set(&THIS->scalar_one, mpz_one); 423 mpz_clear(mpz_one); 424 } 425 426 /*! @decl protected local int(0..1) `==(mixed x) 427 *! ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-experiment
by scan-admin＠coverity.com 19 Feb '17

19 Feb '17

Hi, Please find the latest report on new defect(s) introduced to Pike-experiment found with Coverity Scan. 1 new defect(s) introduced to Pike-experiment found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1400860: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8553 in f_map() ________________________________________________________________________________________________________ *** CID 1400860: (FORWARD_NULL) /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8543 in f_map() 8537 callsite_resolve_svalue(&C, mysp-2); 8538 callsite_prepare(&C); 8539 8540 /* We need to do this manually, because 8541 * currently no arguments are on the stack, yet */ 8542 C.args = 1+splice; >>> CID 1400860: (FORWARD_NULL) >>> Comparing "C.frame" to null implies that "C.frame" might be null. 8543 if (C.frame) C.frame->args = 1+splice; 8544 8545 for (i=0; i<n; i++) 8546 { 8547 push_svalue(ITEM(a)+i); 8548 if (splice) /home/covbuilder/pike/pike-git/src/builtin_functions.c: 8553 in f_map() 8547 push_svalue(ITEM(a)+i); 8548 if (splice) 8549 { 8550 add_ref_svalue(mysp-1); 8551 push_array_items(mysp[-1].u.array); 8552 } >>> CID 1400860: (FORWARD_NULL) >>> Although "callsite_reset" does overwrite "C.frame" on some paths, it also contains at least one feasible path which does not overwrite it. 8553 if (i) callsite_reset(&C); 8554 callsite_execute(&C); 8555 callsite_return(&C); 8556 8557 stack_pop_to_no_free (ITEM(d) + i); 8558 types |= 1 << TYPEOF(ITEM(d)[i]); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-experiment
by scan-admin＠coverity.com 19 Feb '17

19 Feb '17

Hi, Please find the latest report on new defect(s) introduced to Pike-experiment found with Coverity Scan. 9 new defect(s) introduced to Pike-experiment found with Coverity Scan. 10 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 9 of 9 defect(s) ** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/pike-git/src/modules/Image/encodings/bmp.c: 748 in i_img_bmp__decode() /home/covbuilder/pike/pike-git/src/modules/Image/encodings/bmp.c: 761 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400859: (UNUSED_VALUE) /home/covbuilder/pike/pike-git/src/modules/Image/encodings/bmp.c: 748 in i_img_bmp__decode() 742 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 743 push_int(2); 744 push_object(o=clone_object(image_colortable_program,2)); 745 nct=get_storage(o,image_colortable_program); 746 747 s+=(4<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (4 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 748 len-=(4<<bpp); 749 } 750 else 751 { 752 if ((3<<bpp)>len) 753 Pike_error("Image.BMP.decode: unexpected EOF in palette\n"); /home/covbuilder/pike/pike-git/src/modules/Image/encodings/bmp.c: 761 in i_img_bmp__decode() 755 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 756 push_int(1); 757 push_object(o=clone_object(image_colortable_program,2)); 758 nct=get_storage(o,image_colortable_program); 759 760 s+=(3<<bpp); >>> CID 1400859: (UNUSED_VALUE) >>> Assigning value from "len - (3 << bpp)" to "len" here, but that stored value is overwritten before it can be used. 761 len-=(3<<bpp); 762 } 763 764 n++; 765 } 766 ** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/pike-git/src/modules/Image/encodings/bmp.c: 747 in i_img_bmp__decode() /home/covbuilder/pike/pike-git/src/modules/Image/encodings/bmp.c: 760 in i_img_bmp__decode() ________________________________________________________________________________________________________ *** CID 1400858: (UNUSED_VALUE) /home/covbuilder/pike/pike-git/src/modules/Image/encodings/bmp.c: 747 in i_img_bmp__decode() 741 742 push_string(make_shared_binary_string((char *)s,(4<<bpp))); 743 push_int(2); 744 push_object(o=clone_object(image_colortable_program,2)); 745 nct=get_storage(o,image_colortable_program); 746 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (4 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 747 s+=(4<<bpp); 748 len-=(4<<bpp); 749 } 750 else 751 { 752 if ((3<<bpp)>len) /home/covbuilder/pike/pike-git/src/modules/Image/encodings/bmp.c: 760 in i_img_bmp__decode() 754 755 push_string(make_shared_binary_string((char *)s,(3<<bpp))); 756 push_int(1); 757 push_object(o=clone_object(image_colortable_program,2)); 758 nct=get_storage(o,image_colortable_program); 759 >>> CID 1400858: (UNUSED_VALUE) >>> Assigning value from "s + (3 << bpp)" to "s" here, but that stored value is overwritten before it can be used. 760 s+=(3<<bpp); 761 len-=(3<<bpp); 762 } 763 764 n++; 765 } ** CID 1400857: (UNINIT) /home/covbuilder/pike/pike-git/src/modules/Image/image.c: 4152 in image_apply_curve() /home/covbuilder/pike/pike-git/src/modules/Image/image.c: 4232 in image_apply_curve() ________________________________________________________________________________________________________ *** CID 1400857: (UNINIT) /home/covbuilder/pike/pike-git/src/modules/Image/image.c: 4152 in image_apply_curve() 4146 pop_n_elems( args ); 4147 image_apply_curve_3( curve ); 4148 return; 4149 } 4150 case 2: 4151 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4152 unsigned char curve[256]; 4153 int chan = 0, co = 0; 4154 struct object *o; 4155 4156 if( TYPEOF(sp[-args]) != T_STRING ) 4157 SIMPLE_ARG_TYPE_ERROR("apply_curve", 1, "string"); /home/covbuilder/pike/pike-git/src/modules/Image/image.c: 4232 in image_apply_curve() 4226 pop_stack(); 4227 } 4228 return; 4229 } 4230 case 1: 4231 { >>> CID 1400857: (UNINIT) >>> Declaring variable "curve" without initializer. 4232 unsigned char curve[256]; 4233 if( TYPEOF(sp[-args]) != T_ARRAY || 4234 sp[-args].u.array->size != 256 ) 4235 bad_arg_error("apply_curve", 4236 sp-args, args, 0, "", sp-args, 4237 "Bad arguments to apply_curve.\n" ); ** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/pike-git/src/modules/Gz/zlibmod.c: 948 in low_zlibmod_unpack() ________________________________________________________________________________________________________ *** CID 1400856: API usage errors (LOCK) /home/covbuilder/pike/pike-git/src/modules/Gz/zlibmod.c: 948 in low_zlibmod_unpack() 942 else 943 Pike_error("Failed to initialize Gz.uncompress (%d).\n", ret); 944 } 945 946 mt_init(&z.lock); 947 ret = do_inflate(buf, &z, Z_SYNC_FLUSH); >>> CID 1400856: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 948 mt_destroy(&z.lock); 949 inflateEnd( &z.gz ); 950 951 if(ret==Z_OK) 952 Pike_error("Compressed data is truncated.\n"); 953 if(ret!=Z_STREAM_END) ** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/pike-git/src/modules/Gz/zlibmod.c: 447 in low_zlibmod_pack() ________________________________________________________________________________________________________ *** CID 1400855: API usage errors (LOCK) /home/covbuilder/pike/pike-git/src/modules/Gz/zlibmod.c: 447 in low_zlibmod_pack() 441 442 mt_init(&z.lock); 443 444 ret = do_deflate(buf, &z, Z_FINISH); 445 446 deflateEnd(&z.gz); >>> CID 1400855: API usage errors (LOCK) >>> "pthread_mutex_destroy" destroys "z.lock" while it is locked. 447 mt_destroy(&z.lock); 448 449 if(ret != Z_STREAM_END) 450 Pike_error("Error while deflating data (%d).\n",ret); 451 } 452 ** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/pike-git/src/array.c: 97 in real_allocate_array() ________________________________________________________________________________________________________ *** CID 1400854: Insecure data handling (INTEGER_OVERFLOW) /home/covbuilder/pike/pike-git/src/array.c: 97 in real_allocate_array() 91 /* Limits size to (1<<29)-4 */ 92 if( (size_t)(size+extra_space-1) > 93 (LONG_MAX-sizeof(struct array))/sizeof(struct svalue) ) 94 Pike_error("Too large array (size %ld exceeds %ld).\n", 95 (long)(size+extra_space-1), 96 (long)((LONG_MAX-sizeof(struct array))/sizeof(struct svalue)) ); >>> CID 1400854: Insecure data handling (INTEGER_OVERFLOW) >>> Overflowed or truncated value (or a value computed from an overflowed or truncated value) "56UL + (size + extra_space - 1L) * 16UL" used as critical argument to function. 97 v=malloc(sizeof(struct array)+ 98 (size+extra_space-1)*sizeof(struct svalue)); 99 if(!v) 100 Pike_error(msg_out_of_mem_2, sizeof(struct array)+ 101 (size+extra_space-1)*sizeof(struct svalue)); 102 ** CID 1400853: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/pike-git/src/operators.c: 2255 in o_subtract() ________________________________________________________________________________________________________ *** CID 1400853: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/pike-git/src/operators.c: 2255 in o_subtract() 2249 return; 2250 2251 case T_INT: 2252 if(INT_TYPE_SUB_OVERFLOW(sp[-2].u.integer, sp[-1].u.integer)) 2253 { 2254 convert_stack_top_to_bignum(); >>> CID 1400853: Error handling issues (CHECKED_RETURN) >>> Calling "call_lfun" without checking return value (as is done elsewhere 18 out of 22 times). 2255 call_lfun(LFUN_SUBTRACT, LFUN_RSUBTRACT); 2256 return; 2257 } 2258 sp--; 2259 SET_SVAL(sp[-1], PIKE_T_INT, NUMBER_NUMBER, integer, 2260 sp[-1].u.integer - sp[0].u.integer); ** CID 1400852: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/pike-git/src/post_modules/Nettle/hogweed.cmod: 422 in f_Nettle_ECC_Curve_create() ________________________________________________________________________________________________________ *** CID 1400852: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/pike-git/src/post_modules/Nettle/hogweed.cmod: 422 in f_Nettle_ECC_Curve_create() 416 Pike_error("Invalid curve\n"); 417 break; 418 } 419 420 ecc_scalar_init(&THIS->scalar_one, THIS->curve); 421 mpz_init_set_si(mpz_one, 1); >>> CID 1400852: Error handling issues (CHECKED_RETURN) >>> Calling "nettle_ecc_scalar_set" without checking return value (as is done elsewhere 4 out of 5 times). 422 ecc_scalar_set(&THIS->scalar_one, mpz_one); 423 mpz_clear(mpz_one); 424 } 425 426 /*! @decl protected local int(0..1) `==(mixed x) 427 *! ** CID 1398324: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/pike-git/src/operators.c: 3996 in o_divide() ________________________________________________________________________________________________________ *** CID 1398324: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/pike-git/src/operators.c: 3996 in o_divide() 3990 3991 if(INT_TYPE_DIV_OVERFLOW(sp[-2].u.integer, sp[-1].u.integer)) 3992 { 3993 stack_swap(); 3994 convert_stack_top_to_bignum(); 3995 stack_swap(); >>> CID 1398324: Error handling issues (CHECKED_RETURN) >>> Calling "call_lfun" without checking return value (as is done elsewhere 18 out of 22 times). 3996 call_lfun(LFUN_DIVIDE,LFUN_RDIVIDE); 3997 return; 3998 } 3999 else 4000 tmp = sp[-2].u.integer/sp[-1].u.integer; 4001 sp--; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 12 Feb '17

12 Feb '17

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 1 new defect(s) introduced to Pike-master found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1400445: Integer handling issues (NEGATIVE_RETURNS) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 506 in low_read_file() ________________________________________________________________________________________________________ *** CID 1400445: Integer handling issues (NEGATIVE_RETURNS) /home/covscan/pike/Pike-v8.1-snapshot/src/object.c: 506 in low_read_file() 500 while(((f = fd_open(file, fd_RDONLY, 0666)) < 0) && (errno == EINTR)) 501 check_threads_etc(); 502 if(f >= 0) 503 { 504 PIKE_OFF_T tmp, pos = 0; 505 >>> CID 1400445: Integer handling issues (NEGATIVE_RETURNS) >>> Assigning: signed variable "len" = "lseek". 506 while (((len = fd_lseek(f, 0, SEEK_END)) < 0) && (errno == EINTR)) 507 check_threads_etc(); 508 while ((fd_lseek(f, 0, SEEK_SET) < 0) && (errno == EINTR)) 509 check_threads_etc(); 510 511 if (len > MAX_INT32) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "pike-automation(a)lists.lysator.liu.se", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

Pike-automation February 2017