Pike-automation July 2019

pike-automation@lists.lysator.liu.se

1 participants
1 discussions

New Defects reported by Coverity Scan for Pike-master
by scan-admin＠coverity.com 30 Jul '19

30 Jul '19

Hi, Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan. 3 new defect(s) introduced to Pike-master found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1452124: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/b_source_normal_file.c: 96 in source_normal_file_make() ________________________________________________________________________________________________________ *** CID 1452124: Error handling issues (CHECKED_RETURN) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/b_source_normal_file.c: 96 in source_normal_file_make() 90 pop_stack(); 91 92 if (fd_fstat(fd, &st) < 0 || !S_ISREG(st.st_mode)) 93 return 0; 94 95 if (start) >>> CID 1452124: Error handling issues (CHECKED_RETURN) >>> Calling "lseek(fd, (off_t)start, 1)" without checking return value. This library function may fail and return an error code. 96 fd_lseek(fd, (off_t)start, SEEK_CUR); 97 98 if (!(res = calloc(1, sizeof(struct fd_source)))) 99 return 0; 100 101 res->fd = fd; ** CID 1452123: (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/e_source_block_pikestream.c: 79 in get_data() /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/c_source_stream.c: 118 in get_data() /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/d_source_pikestream.c: 99 in get_data() ________________________________________________________________________________________________________ *** CID 1452123: (UNINIT) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/e_source_block_pikestream.c: 79 in get_data() 73 } 74 if (s->len >= 0) { 75 s->len -= res.len; 76 if(!s->len) 77 s->s.eof = 1; 78 } >>> CID 1452123: (UNINIT) >>> Using uninitialized value "res". Field "res.data" is uninitialized. 79 return res; 80 } 81 82 static void free_source( struct source *src ) 83 { 84 struct pf_source *s = (struct pf_source *)src; /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/c_source_stream.c: 118 in get_data() 112 * source_stream_make) 113 */ 114 res.len = -2; 115 setup_callbacks(src); 116 } 117 >>> CID 1452123: (UNINIT) >>> Using uninitialized value "res". Field "res.data" is uninitialized. 118 return res; 119 } 120 121 static void 122 set_callback(struct source *src, void (*cb)( void *a ), struct object *a) { 123 struct fd_source *s = (struct fd_source *)src; /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/d_source_pikestream.c: 99 in get_data() 93 * out of the range of data to send as specified by the arguments to 94 * source_stream_make) 95 */ 96 res.len = -2; 97 setup_callbacks(src); 98 } >>> CID 1452123: (UNINIT) >>> Using uninitialized value "res". Field "res.data" is uninitialized. 99 return res; 100 } 101 102 static void f_got_data( INT32 args ) 103 { 104 struct pf_source *s = (struct pf_source*)Pike_fp->current_object->storage; ** CID 1452122: Parse warnings (PW.PARAM_SET_BUT_NOT_USED) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/c_source_stream.c: 93 in () ________________________________________________________________________________________________________ *** CID 1452122: Parse warnings (PW.PARAM_SET_BUT_NOT_USED) /home/covbuilder/pike/Pike-v8.1-snapshot/src/post_modules/Shuffler/c_source_stream.c: 93 in () 87 88 static void setup_callbacks( struct source *src ) { 89 struct fd_source *s = (struct fd_source *)src; 90 set_read_callback( s->fd, (void*)read_callback, s ); 91 } 92 >>> CID 1452122: Parse warnings (PW.PARAM_SET_BUT_NOT_USED) >>> parameter "len" was set but never used 93 static struct data get_data(struct source *src, off_t len) 94 { 95 struct fd_source *s = (struct fd_source *)src; 96 struct data res; 97 98 reload: ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

Pike-automation July 2019