Pike-devel September 2011

pike-devel@lists.lysator.liu.se

3 participants
8 discussions

Sql.pgsql behavior in case of errors
by aldem-pikedev＠aldem.net 21 Aug '14

21 Aug '14

Hi everyone, I am preparing to use Postgres in my app, found the following strange behavior: ---snip--- Sql.Sql db = Sql.Sql("pgsql://localhost", "test", "test", "test"); db->query("BEGIN"); db->query("INSERT INTO requests (SvTrId) VALUES ('lala')"); catch(db->query("INSERT INTO requests (SvTrId) VALUES ('lala')")); db->query("INSERT INTO requests (SvTrId) VALUES ('juju')"); db->query("ROLLBACK"); ---snip--- Database is opened, row with 'lala' is inserted, second query (obviously) fails as SvTrId is the primary key, but row with 'juju' is inserted *and* appears in the database - i.e. the transaction is *committed*! Studying source code show, that once error is encounter, session is reset, i.e. running transaction is rolled back, everything is closed, temporary tables are deleted and session variables are reset as well, and after that, the next statement(s) will be committed immediately, as there is no active transaction. In my opinion, this is not exactly correct behavior when statement fails, as session still may be needed (especially temporary tables, open cursors etc). Im some cases, this is perfectly normal when SQL statement fails, especially in SERIALIZED transaction isolation level, and it would be more practical to leave the decision as of what to do to the application. Yes, this is true that it is impossible to continue executing statements in failed transaction, but temporary tables etc. may still be needed. Also, silent reconnection is not a good idea too - when there are many transactional statements are executed - it would be nice to have an option to modify this behavior. Best regards, /Alexander

5 6

pike.ida.liu.se offline?
by Ryan 18 Nov '11

18 Nov '11

I am unable to get to the pike homepage to download the latest bits and read the documents. Anyone have any information?

5 11

Re: Possible bug walking a GTK2.TreeModel in 7.9
by Lance Dillon 22 Sep '11

22 Sep '11

----- Original Message ---- > From: larcky <pclar7(a)yahoo.co.uk> > To: pike(a)roxen.com > Sent: Thu, September 22, 2011 3:17:33 AM > Subject: Possible bug walking a GTK2.TreeModel in 7.9 > > Hi > This works fine in Pike 7.8 but 7.9 crashes with a Segmentation Fault. I > think the problem's with GTK2.TreeModel->iter_next(). I can get the first > row OK but then the iterator becomes invalid. > Thanks, larcky > I believe I see the problem. In 7.9, in gtktreemodel.pre, function iter_next, it was changed to push the iter onto the stack, to return it. This way you can possibly do things like iter2=tm->iter_next(iter). The problem is that iter gets modified in place by gtk_tree_model_iter_next(), so it is there, then it gets pushed onto the stack also. So the same GtkTreeIter is present twice, once in the original object, and another on the stack. When the one on the stack doesn't get assigned to anything, it gets free'd by gtk, so the original iter gets free'd also. Then when you try to use it again, possibly the memory is fine and hasn't been overwritten yet, but when it tries to free it again, it gets the double free. 7.9 needs to be changed to either copy the iter, or to not return it. Does anybody have a preference? I don't think the copy would be the right thing to do, because it would usually consist of a copy and a free anyway, because you won't probably won't use the old one once you have the next one. I don't think there is any way to do it otherwise because gtk_tree_model_iter_next() replaces the iter, it doesn't return the next one as a new iter, leaving the old one alone.

1 1

Re: Val.true and Val.false [Was: XMLRPC] (from pike@roxen.com)
by Lance Dillon 11 Sep '11

11 Sep '11

Patch for boolean support for Protocols.XMLRPC --- module.pmod.orig 2011-08-31 16:02:19.838058384 -0400 +++ module.pmod 2011-09-07 10:17:21.848427570 -0400 @@ -15,12 +15,15 @@ //! Pike @expr{mapping@} is translated to XML-RPC @tt{<struct>@}. //! Pike @expr{array@} is translated to XML-RPC @tt{<array>@}. //! Pike @[Calendar] object is translated to XML-RPC @tt{<dateTime.iso8601@}. +//! Pike @expr{Val.false@} and @expr{Val.true@} is translated to +//! XML-RPC @tt{<boolean>@}. //! //! Translation rules for conversions from XML-RPC datatypes to Pike //! datatypes: //! -//! XML-RPC @tt{<i4>@}, @tt{<int>@} and @tt{<boolean>@} are -//! translated to Pike @expr{int@}. +//! XML-RPC @tt{<i4>@} and @tt{<int>@} are translated to Pike @expr{int@}. +//! XML-RPC @tt{<boolean>} is translated to Pike @expr{Val.true@} and +//! @expr{Val.false@}. //! XML-RPC @tt{<string>@} and @tt{<base64>@} are translated to //! Pike @expr{string@}. //! XML_RPC @tt{<double>@} is translated to Pike @expr{float@}. @@ -225,8 +228,9 @@ return sizeof(data)?data[0]:""; case "i4": case "int": - case "boolean": return (int)(data*"") || magic_zero; + case "boolean": + return ((int)(data*""))?Val.true:Val.false; case "double": return (float)(data*""); case "string": @@ -274,7 +278,7 @@ ({ "&", "<", ">", """, "'", "" })); } -protected string encode(int|float|string|mapping|array value) +protected string encode(int|float|string|mapping|array|object value) { string r = "<value>"; if(intp(value)) @@ -303,6 +307,8 @@ else if (objectp (value) && value->format_iso_short) r += "<dateTime.iso8601>" + value->format_iso_short() + "</dateTime.iso8601>"; + else if (objectp(value) && (value->is_val_true || value->is_val_false)) + r += sprintf("<boolean>%d</boolean>",(int)value); else error("Cannot encode %O.\n", value); return r+"</value>\n";

3 16

Re: Val.true and Val.false [Was: XMLRPC] (from pike@roxen.com)
by Lance Dillon 10 Sep '11

10 Sep '11

Okay I'll take care of that this afternoon. Sent from Yahoo! Mail on Android

1 0

pikefarm
by Lance Dillon 09 Sep '11

09 Sep '11

It looks like pikefarm isn't valid anymore. I went to this page: http://pike.ida.liu.se/development/pikefarm/7.8.xml, and it looks like the latest build was on 2010-10-01 16:15:54 (1197). Is it still being used, or is there a different url to go to?

1 0

Re: Val.true and Val.false [Was: XMLRPC]
by Lance Dillon 07 Sep '11

07 Sep '11

> > > Looks ok, but could you please update the docs accordingly as well? > > > > Getting (optional) boolean support when decoding would be nice from a > > feature and symmetry perspective, but that's not a requirement imo. > > > > > In order to backport Val.pmod to 7.8.526, I had to remove Null, because >it > > > references Builtin.Null, which doesn't exist. > > > > Right. That shouldn't be a problem in this case. > > > That last patch was for 7.8.526 with Val.pmod backported (meaning, minus Val.Null) to add boolean support to Protocols.XMLRPC using Val.

1 0

Mapping mixup
by Martin Nilsson (Opera Mini - AFK!) ＠ Pike (-) developers forum 06 Sep '11

06 Sep '11

We've seen this nasty little issue. The following code class C { mapping options = ([1:1]); void create() { werror("%O\n\n", options); } } void main() { C c = C(); c->options[3] = 3; C cc = C(); } will result in nilsson@riaa:~$ pike --dumpversion 7.9.5 nilsson@riaa:~$ uname -a Linux riaa 2.6.38-10-generic #46-Ubuntu SMP Tue Jun 28 15:07:17 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux nilsson@riaa:~$ pike test.pike ([ /* 1 element */ 1: 1 ]) ([ /* 2 elements */ 1: 1, 3: 3 ]) thought it works fine on nilsson@khora:~$ pike --dumpversion 7.9.5 nilsson@khora:~$ uname -a Linux khora 2.6.32-28-generic #55-Ubuntu SMP Mon Jan 10 21:21:01 UTC 2011 i686 GNU/Linux nilsson@khora:~$ pike test.pike ([ /* 1 element */ 1: 1 ]) ([ /* 1 element */ 1: 1 ])

3 12

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel September 2011