http://bugzilla.lysator.liu.se/show_bug.cgi?id=916
------- Additional Comments From ceder(a)lysator.liu.se 2002-11-26 23:19 -------
Created an attachment (id=33)
--> (http://bugzilla.lysator.liu.se/attachment.cgi?id=33&action=view)
Don't pass NULL pointers to accept().
This patch "fixes" the valgrind warnings by passing dummy arguments to
accept(). It does not address the performance issue. This patch may
be less portable than the current code, so I'm probably not going to
commit it.
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://bugzilla.lysator.liu.se/show_bug.cgi?id=916
Summary: Needless use of getpeername
Product: lyskomd
Version: 2.0.7
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: P2
Component: server
AssignedTo: ceder(a)lysator.liu.se
ReportedBy: ceder(a)lysator.liu.se
QAContact: lyskomd-qa(a)lists.lysator.liu.se
The ISC code does something similar to this:
s=accept(fd, NULL, NULL);
getpeername(s, &x, &y);
There are two problems with this:
- it is inefficient
- valgrind-1.1.0 complains about the NULL argument to accept()
See FIXME comments in src/server/testsuite/lyskomd.supp.
If we do something about bug 106, this problem may disappear.
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://bugzilla.lysator.liu.se/show_bug.cgi?id=563
------- Additional Comments From thorild(a)Update.UU.SE 2002-11-26 20:25 -------
KOM.Update.UU.SE has now been running with my latest IPv6 patch
for about 40 hours. Everything seems to work just fine. I haven't
tried running a binary compiled with IPv6 support on a IPv4 only
node though -- is anyone here willing to do that test?
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://bugzilla.lysator.liu.se/show_bug.cgi?id=913
Summary: Prohibit deletion of last recipient
Product: lyskomd
Version: 2.0.7
Platform: PC
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P2
Component: server
AssignedTo: ceder(a)lysator.liu.se
ReportedBy: byers(a)lysator.liu.se
QAContact: lyskomd-qa(a)lists.lysator.liu.se
It should be impossible to delete the last recipient of a text, unless it is
world-readable, or changing from world-readable to non-world-readable on a text
without recipients.
We have seen unintentional deletion of all recipients when industrious but not
particularly observant conference supervisors have deleted "their" conference
from the recipient list. A prohibition would eliminate this (and I think this is
the most important reason for prohibiting deletion of the last recipient).
Intentional removal of all recipients is a nasty and easy way of deleting a
text. Such behavior is generally undesirable -- if someone wants to delete a
text, let them delete it. If they don't want the original recipients to be
visible, let them remove the recipients and make the text world-readable or have
them move the text somewhere else.
This prohibition will not completely eliminate removing all recipients -- a user
can still move a text to a secret conference, which accomplishes the same thing.
But we can make it a bit harder.
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://bugzilla.lysator.liu.se/show_bug.cgi?id=686
------- Additional Comments From byers(a)lysator.liu.se 2002-11-26 00:01 -------
If we decide to go the route of deleting the author we should consider deleting
all information in the text except comment links, including all misc-items, all
aux-items and making the text world-readable (and somehow protecting it from the
garbage collector -- perhaps a secret aux-item containing the maximum garb-nice
of all original recipients).
There is too much information in a text that can be used to derive the author. A
recipient with only a small number of permitted submitters, something set by the
author's supervisor that can only be set by the author or supervisor. Footnotes
will give the author away too. There are probably other things.
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://bugzilla.lysator.liu.se/show_bug.cgi?id=93
ceder(a)lysator.liu.se changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |INVALID
------- Additional Comments From ceder(a)lysator.liu.se 2002-11-25 16:55 -------
This bug is too broad. It will never be possible to close it, becuase there
will always be something not covered.
See bug 7, bug 59, bug 904, bug 905, bug 906, bug 907, bug 908, bug 909,
bug 910, bug 911 and bug 912 (or all bugs with the keyword "async") instead.
I'm closing this. Move your votes to the more specific bug that you feel
are most important to you.
There are doubtless other situations where new async messages are needed.
Please write new bugs for them.
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://bugzilla.lysator.liu.se/show_bug.cgi?id=909
ceder(a)lysator.liu.se changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Keywords| |async
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://bugzilla.lysator.liu.se/show_bug.cgi?id=908
ceder(a)lysator.liu.se changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Keywords| |async
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://bugzilla.lysator.liu.se/show_bug.cgi?id=907
ceder(a)lysator.liu.se changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Keywords| |async
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
http://bugzilla.lysator.liu.se/show_bug.cgi?id=906
ceder(a)lysator.liu.se changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Keywords| |async
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.