Hi,
Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan.
** CID 1676053: (ARRAY_VS_SINGLETON)
_____________________________________________________________________________________________
*** CID 1676053: (ARRAY_VS_SINGLETON)
/home/covbuilder/pike/Pike-v9.1-snapshot/src/modules/HTTPLoop/requestobject.c: 590 in actually_send()
584 }
585
586 DWERROR("cork... \n");
587 oldbulkmode = bulkmode_start(a->to->fd);
588
589 fail = -1;
>>> CID 1676053: (ARRAY_VS_SINGLETON)
>>> Passing "data_ptr" to function "pike_sendfile" which uses it as an array. This might corrupt or misinterpret adjacent memory locations.
590 sent = pike_sendfile(a->to->fd, data_ptr, !!data_ptr,
591 a->len ? a->from_fd: -1, NULL, a->len,
592 NULL, 0);
593
594 if (sent >= 0) {
595 a->sent += sent;
/home/covbuilder/pike/Pike-v9.1-snapshot/src/modules/HTTPLoop/requestobject.c: 590 in actually_send()
584 }
585
586 DWERROR("cork... \n");
587 oldbulkmode = bulkmode_start(a->to->fd);
588
589 fail = -1;
>>> CID 1676053: (ARRAY_VS_SINGLETON)
>>> Passing "data_ptr" to function "pike_sendfile" which uses it as an array. This might corrupt or misinterpret adjacent memory locations.
590 sent = pike_sendfile(a->to->fd, data_ptr, !!data_ptr,
591 a->len ? a->from_fd: -1, NULL, a->len,
592 NULL, 0);
593
594 if (sent >= 0) {
595 a->sent += sent;
Best regards,
The Coverity Scan Admin Team