Hi,
Please find the latest report on new defect(s) introduced to Pike-master found with Coverity Scan.
** CID 1680319: (CHECKED_RETURN)
/home/covbuilder/pike/Pike-v9.1-snapshot/src/modules/_Image_TIFF/image_tiff.c: 460 in low_image_tiff_decode()
/home/covbuilder/pike/Pike-v9.1-snapshot/src/modules/_Image_TIFF/image_tiff.c: 459 in low_image_tiff_decode()
_____________________________________________________________________________________________
*** CID 1680319: (CHECKED_RETURN)
/home/covbuilder/pike/Pike-v9.1-snapshot/src/modules/_Image_TIFF/image_tiff.c: 460 in low_image_tiff_decode()
454 size_buffer, map_buffer,
455 unmap_buffer);
456 if(!tif)
457 Pike_error("Failed to 'open' tiff image: %s\n", last_tiff_error);
458
459 TIFFGetField(tif, TIFFTAG_IMAGEWIDTH, &w);
>>> CID 1680319: (CHECKED_RETURN)
>>> Calling "TIFFGetField" without checking return value (as is done elsewhere 25 out of 27 times).
460 TIFFGetField(tif, TIFFTAG_IMAGELENGTH, &h);
461
462 if (DO_UINT32_MUL_OVERFLOW(w, h, &pixels)
463 || pixels > 0x7fffffff) {
464 /* There is no need to continue, Image.Image does not support >2G
465 * pixels. */
/home/covbuilder/pike/Pike-v9.1-snapshot/src/modules/_Image_TIFF/image_tiff.c: 459 in low_image_tiff_decode()
453 seek_buffer, close_buffer,
454 size_buffer, map_buffer,
455 unmap_buffer);
456 if(!tif)
457 Pike_error("Failed to 'open' tiff image: %s\n", last_tiff_error);
458
>>> CID 1680319: (CHECKED_RETURN)
>>> Calling "TIFFGetField" without checking return value (as is done elsewhere 25 out of 27 times).
459 TIFFGetField(tif, TIFFTAG_IMAGEWIDTH, &w);
460 TIFFGetField(tif, TIFFTAG_IMAGELENGTH, &h);
461
462 if (DO_UINT32_MUL_OVERFLOW(w, h, &pixels)
463 || pixels > 0x7fffffff) {
464 /* There is no need to continue, Image.Image does not support >2G
Best regards,
The Coverity Scan Admin Team
