problems with --enable-shared

[James Ralston]

--==========1815049384==========
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On 2002-11-01 (Friday) at 11:32:26+0100 Niels M=F6ller <nisse@lysator.liu.se> wrote:

> Thanks for testing this.

Not a problem; thanks for all of your work on lsh/nettle.

> There seems to be one more problem with that command line:
> nettle-openssl_p.o should probably not be included in the shared
> library.  It is used only for benchmarking against openssl, and
> including it in the shared library will make the entire library
> depend on openssl, which isn't good.

Agreed.  (I was a bit surprised when I noticed the dependency, but I
wasn't sure why it was there.)

> Perhaps the file should simply be moved out of the library and down
> into the examples directory.  The same will apply whenever I add
> similar glue code for libgcrypt.

That seems like a reasonable solution.

> Can you try getting the current nettle from cvs and check if that
> works?

I found one problem (a simple variable renaming error); the enclosed
patch fixes it.

With the patch, as of today, current CVS works fine (with both
--enabled-shared and --disabled-shared) on Red Hat Linux 8.0 (x86
architecture; gcc 3.2).

I also tried to compile on Sun Solaris 8 (sparc; SunPro 5.2
2000/09/11), but the SunPro CC doesn't ISO C99 non-constant
initializers:

source=3D'des-compat.c' object=3D'des-compat.o' libtool=3Dno \
depfile=3D'.deps/des-compat.Po' tmpdepfile=3D'.deps/des-compat.TPo' \
depmode=3Dnone /bin/bash ./depcomp \
/opt/SUNWspro/bin/cc -DHAVE_CONFIG_H -I. -I. -I.      -g -c `test -f 'des-compat.c' || echo './'`des-compat.c
"des-compat.c", line 64: non-constant initializer: op "NAME"
"des-compat.c", line 64: non-constant initializer: op "NAME"
"des-compat.c", line 64: non-constant initializer: op "NAME"
"des-compat.c", line 145: non-constant initializer: op "NAME"
"des-compat.c", line 145: non-constant initializer: op "NAME"
"des-compat.c", line 145: non-constant initializer: op "NAME"
cc: acomp failed for des-compat.c
*** Error code 2
make: Fatal error: Command failed for target `des-compat.o'
Current working directory /tmp/qralston/nettle.CVS-2002-11-07
*** Error code 1
make: Fatal error: Command failed for target `all-recursive'
Current working directory /tmp/qralston/nettle.CVS-2002-11-07
*** Error code 1
make: Fatal error: Command failed for target `all'

If compatibility with SunPro CC is desired, I'll go ahead and
construct a patch to work around its limitation; let me know.

> (You may not want to install it, I won't promise that the current
> nettle is compatible with 1.6 nor with the next released version).

Thanks for the warning.  (I don't plan to use it in production; I was
mostly just interested in testing it out.)

Regards,
James

--==========1815049384==========
Content-Type: text/plain; charset=us-ascii;
 name="nettle.CVS-2002-11-07-dsa-bits.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="nettle.CVS-2002-11-07-dsa-bits.patch"; size=423

--- nettle.CVS-2002-11-07/testsuite/testutils.c.dsa-bits	2002-10-30 15:59:04.000000000 -0500
+++ nettle.CVS-2002-11-07/testsuite/testutils.c	2002-11-07 18:30:13.000000000 -0500
@@ -529,7 +529,7 @@
   mpz_init(t);
 
   ASSERT(mpz_sizeinbase(pub->q, 2) == 160);
-  ASSERT(mpz_sizeinbase(pub->p, 2) >= DSA_MINIMUM_BITS);
+  ASSERT(mpz_sizeinbase(pub->p, 2) >= DSA_MIN_P_BITS);
   
   ASSERT(mpz_probab_prime_p(pub->p, 10));
 

--==========1815049384==========--